| Message ID | OP472vRO_13s3y8PI5nplVOCz6jhAMLTrsiRNglJYpsVepytiMkTHLMJAgzi83RBq0Lbv9VU0QNCuLNKiTUtVPJebd8pQPSAvXgzU7QL35k=@lorenzosalvadore.it |
|---|---|
| State | New |
| Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D6BC43858D28 for <patchwork@sourceware.org>; Thu, 10 Nov 2022 23:08:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D6BC43858D28 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1668121686; bh=PTxHPyEXaiDNAu1ufAhMtjnKOQyumJgTmG8AdL7QSmc=; h=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=GPAIfVCzl/t2I5B7r64dD/ulHc5tyiA450XCqUPIO96+UUZB/Z91sCyHMkmAVUEyP Ue/Z+dTCMt/pHPhesOirplzCO3tedx/IkKXjzx66AK1rU/0JMbqnHxwEFzoK0Qf6pT QnkFvX90829vAFcc/qilaIdn1ZcxVymaHwvb4LPg= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-4323.proton.ch (mail-4323.proton.ch [185.70.43.23]) by sourceware.org (Postfix) with ESMTPS id BBE403857C44 for <gcc-patches@gcc.gnu.org>; Thu, 10 Nov 2022 23:07:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BBE403857C44 Date: Thu, 10 Nov 2022 23:07:30 +0000 To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org> Cc: "ibuclaw@gdcproject.org" <ibuclaw@gdcproject.org>, "andreast@gcc.gnu.org" <andreast@gcc.gnu.org>, Gerald Pfeifer <gerald@pfeifer.com> Subject: [PATCH] d: Update __FreeBSD_version values [PR107469] Message-ID: <OP472vRO_13s3y8PI5nplVOCz6jhAMLTrsiRNglJYpsVepytiMkTHLMJAgzi83RBq0Lbv9VU0QNCuLNKiTUtVPJebd8pQPSAvXgzU7QL35k=@lorenzosalvadore.it> Feedback-ID: 53711648:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: Lorenzo Salvadore via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: Lorenzo Salvadore <developer@lorenzosalvadore.it> Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> |
| Series |
d: Update __FreeBSD_version values [PR107469]
|
|
Commit Message
Lorenzo Salvadore
Nov. 10, 2022, 11:07 p.m. UTC
Hello, I would like to submit the patch below. Gerald Pfeifer already volunteered to commit it once approved. Thanks, Lorenzo Salvadore --- Update __FreeBSD_version values for the latest FreeBSD supported versions. In particular, add __FreeBSD_version for FreeBSD 14, which is necessary to compile libphobos successfully on FreeBSD 14. The patch has already been applied successfully in the official FreeBSD ports tree for the ports lang/gcc11 and lang/gcc11-devel. Please see the following commits: https://cgit.freebsd.org/ports/commit/?id=f61fb49b2e76fd4f7a5b7a11510b5109206c19f2 https://cgit.freebsd.org/ports/commit/?id=57936dba89ea208e5dbc1bd2d7fda3d29a1838b3 libphobos/ChangeLog: 2022-11-10 Lorenzo Salvadore <developer@lorenzosalvadore.it> PR d/107469. * libdruntime/core/sys/freebsd/config.d: Update __FreeBSD_version. --- libphobos/libdruntime/core/sys/freebsd/config.d | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.38.0
Comments
Hello, Ping https://gcc.gnu.org/pipermail/gcc-patches/2022-November/605685.html I would like to remind that Gerald Pfeifer already volunteered to commit this patch when it is approved. However the patch has not been approved yet. Thanks, Lorenzo Salvadore ------- Original Message ------- On Friday, November 11th, 2022 at 12:07 AM, Lorenzo Salvadore <developer@lorenzosalvadore.it> wrote: > Update __FreeBSD_version values for the latest FreeBSD supported > versions. In particular, add __FreeBSD_version for FreeBSD 14, which is > necessary to compile libphobos successfully on FreeBSD 14. > > The patch has already been applied successfully in the official FreeBSD > ports tree for the ports lang/gcc11 and lang/gcc11-devel. Please see the > following commits: > > https://cgit.freebsd.org/ports/commit/?id=f61fb49b2e76fd4f7a5b7a11510b5109206c19f2 > https://cgit.freebsd.org/ports/commit/?id=57936dba89ea208e5dbc1bd2d7fda3d29a1838b3 > > libphobos/ChangeLog: > > 2022-11-10 Lorenzo Salvadore developer@lorenzosalvadore.it > > > PR d/107469. > * libdruntime/core/sys/freebsd/config.d: Update __FreeBSD_version. > > --- > libphobos/libdruntime/core/sys/freebsd/config.d | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libphobos/libdruntime/core/sys/freebsd/config.d b/libphobos/libdruntime/core/sys/freebsd/config.d > index 5e3129e2422..9d502e52e32 100644 > --- a/libphobos/libdruntime/core/sys/freebsd/config.d > +++ b/libphobos/libdruntime/core/sys/freebsd/config.d > @@ -14,8 +14,9 @@ public import core.sys.posix.config; > // NOTE: When adding newer versions of FreeBSD, verify all current versioned > // bindings are still compatible with the release. > > - version (FreeBSD_13) enum __FreeBSD_version = 1300000; > -else version (FreeBSD_12) enum __FreeBSD_version = 1202000; > + version (FreeBSD_14) enum __FreeBSD_version = 1400000; > +else version (FreeBSD_13) enum __FreeBSD_version = 1301000; > +else version (FreeBSD_12) enum __FreeBSD_version = 1203000; > else version (FreeBSD_11) enum __FreeBSD_version = 1104000; > else version (FreeBSD_10) enum __FreeBSD_version = 1004000; > else version (FreeBSD_9) enum __FreeBSD_version = 903000; > -- > 2.38.0
Hello, Ping https://gcc.gnu.org/pipermail/gcc-patches/2022-November/605685.html I would like to remind that Gerald Pfeifer already volunteered to commit this patch when it is approved. However the patch has not been approved yet. Thanks, Lorenzo Salvadore > ------- Original Message ------- > On Friday, November 11th, 2022 at 12:07 AM, Lorenzo Salvadore developer@lorenzosalvadore.it wrote: > > > Update __FreeBSD_version values for the latest FreeBSD supported > > versions. In particular, add __FreeBSD_version for FreeBSD 14, which is > > necessary to compile libphobos successfully on FreeBSD 14. > > > > The patch has already been applied successfully in the official FreeBSD > > ports tree for the ports lang/gcc11 and lang/gcc11-devel. Please see the > > following commits: > > > > https://cgit.freebsd.org/ports/commit/?id=f61fb49b2e76fd4f7a5b7a11510b5109206c19f2 > > https://cgit.freebsd.org/ports/commit/?id=57936dba89ea208e5dbc1bd2d7fda3d29a1838b3 > > > > libphobos/ChangeLog: > > > > 2022-11-10 Lorenzo Salvadore developer@lorenzosalvadore.it > > > > PR d/107469. > > * libdruntime/core/sys/freebsd/config.d: Update __FreeBSD_version. > > > > --- > > libphobos/libdruntime/core/sys/freebsd/config.d | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/libphobos/libdruntime/core/sys/freebsd/config.d b/libphobos/libdruntime/core/sys/freebsd/config.d > > index 5e3129e2422..9d502e52e32 100644 > > --- a/libphobos/libdruntime/core/sys/freebsd/config.d > > +++ b/libphobos/libdruntime/core/sys/freebsd/config.d > > @@ -14,8 +14,9 @@ public import core.sys.posix.config; > > // NOTE: When adding newer versions of FreeBSD, verify all current versioned > > // bindings are still compatible with the release. > > > > - version (FreeBSD_13) enum __FreeBSD_version = 1300000; > > -else version (FreeBSD_12) enum __FreeBSD_version = 1202000; > > + version (FreeBSD_14) enum __FreeBSD_version = 1400000; > > +else version (FreeBSD_13) enum __FreeBSD_version = 1301000; > > +else version (FreeBSD_12) enum __FreeBSD_version = 1203000; > > else version (FreeBSD_11) enum __FreeBSD_version = 1104000; > > else version (FreeBSD_10) enum __FreeBSD_version = 1004000; > > else version (FreeBSD_9) enum __FreeBSD_version = 903000; > > -- > > 2.38.0
Hi Ian (and Andreas), On Wed, 14 Dec 2022, Lorenzo Salvadore wrote: > Ping https://gcc.gnu.org/pipermail/gcc-patches/2022-November/605685.html > > I would like to remind that Gerald Pfeifer already volunteered to commit > this patch when it is approved. However the patch has not been approved > yet. I am tempted to commit this under our obvious rule (and this has been part of the FreeBSD ports for weeks now). It still would be preferable to get your review (and approval ideally ;-), though. Would you mind having a look? (Andreas, any take as GCC's FreeBSD maintainer?) Thanks, Gerald >> ------- Original Message ------- >> On Friday, November 11th, 2022 at 12:07 AM, Lorenzo Salvadore developer@lorenzosalvadore.it wrote: >> >>> Update __FreeBSD_version values for the latest FreeBSD supported >>> versions. In particular, add __FreeBSD_version for FreeBSD 14, which is >>> necessary to compile libphobos successfully on FreeBSD 14. >>> >>> The patch has already been applied successfully in the official FreeBSD >>> ports tree for the ports lang/gcc11 and lang/gcc11-devel. Please see the >>> following commits: >>> >>> https://cgit.freebsd.org/ports/commit/?id=f61fb49b2e76fd4f7a5b7a11510b5109206c19f2 >>> https://cgit.freebsd.org/ports/commit/?id=57936dba89ea208e5dbc1bd2d7fda3d29a1838b3 >>> >>> libphobos/ChangeLog: >>> >>> 2022-11-10 Lorenzo Salvadore developer@lorenzosalvadore.it >>> >>> PR d/107469. >>> * libdruntime/core/sys/freebsd/config.d: Update __FreeBSD_version. >>> >>> --- >>> libphobos/libdruntime/core/sys/freebsd/config.d | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/libphobos/libdruntime/core/sys/freebsd/config.d b/libphobos/libdruntime/core/sys/freebsd/config.d >>> index 5e3129e2422..9d502e52e32 100644 >>> --- a/libphobos/libdruntime/core/sys/freebsd/config.d >>> +++ b/libphobos/libdruntime/core/sys/freebsd/config.d >>> @@ -14,8 +14,9 @@ public import core.sys.posix.config; >>> // NOTE: When adding newer versions of FreeBSD, verify all current versioned >>> // bindings are still compatible with the release. >>> >>> - version (FreeBSD_13) enum __FreeBSD_version = 1300000; >>> -else version (FreeBSD_12) enum __FreeBSD_version = 1202000; >>> + version (FreeBSD_14) enum __FreeBSD_version = 1400000; >>> +else version (FreeBSD_13) enum __FreeBSD_version = 1301000; >>> +else version (FreeBSD_12) enum __FreeBSD_version = 1203000; >>> else version (FreeBSD_11) enum __FreeBSD_version = 1104000; >>> else version (FreeBSD_10) enum __FreeBSD_version = 1004000; >>> else version (FreeBSD_9) enum __FreeBSD_version = 903000; >>> -- >>> 2.38.0
Hello, Ping https://gcc.gnu.org/pipermail/gcc-patches/2022-November/605685.html I would like to remind that Gerald Pfeifer already volunteered to commit this patch when it is approved. However the patch has not been approved yet. Thanks, Lorenzo Salvadore > ------- Original Message ------- > On Friday, November 11th, 2022 at 12:07 AM, Lorenzo Salvadore developer@lorenzosalvadore.it wrote: > > > Update __FreeBSD_version values for the latest FreeBSD supported > > versions. In particular, add __FreeBSD_version for FreeBSD 14, which is > > necessary to compile libphobos successfully on FreeBSD 14. > > > > The patch has already been applied successfully in the official FreeBSD > > ports tree for the ports lang/gcc11 and lang/gcc11-devel. Please see the > > following commits: > > > > https://cgit.freebsd.org/ports/commit/?id=f61fb49b2e76fd4f7a5b7a11510b5109206c19f2 > > https://cgit.freebsd.org/ports/commit/?id=57936dba89ea208e5dbc1bd2d7fda3d29a1838b3 > > > > libphobos/ChangeLog: > > > > 2022-11-10 Lorenzo Salvadore developer@lorenzosalvadore.it > > > > PR d/107469. > > * libdruntime/core/sys/freebsd/config.d: Update __FreeBSD_version. > > > > --- > > libphobos/libdruntime/core/sys/freebsd/config.d | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/libphobos/libdruntime/core/sys/freebsd/config.d b/libphobos/libdruntime/core/sys/freebsd/config.d > > index 5e3129e2422..9d502e52e32 100644 > > --- a/libphobos/libdruntime/core/sys/freebsd/config.d > > +++ b/libphobos/libdruntime/core/sys/freebsd/config.d > > @@ -14,8 +14,9 @@ public import core.sys.posix.config; > > // NOTE: When adding newer versions of FreeBSD, verify all current versioned > > // bindings are still compatible with the release. > > > > - version (FreeBSD_13) enum __FreeBSD_version = 1300000; > > -else version (FreeBSD_12) enum __FreeBSD_version = 1202000; > > + version (FreeBSD_14) enum __FreeBSD_version = 1400000; > > +else version (FreeBSD_13) enum __FreeBSD_version = 1301000; > > +else version (FreeBSD_12) enum __FreeBSD_version = 1203000; > > else version (FreeBSD_11) enum __FreeBSD_version = 1104000; > > else version (FreeBSD_10) enum __FreeBSD_version = 1004000; > > else version (FreeBSD_9) enum __FreeBSD_version = 903000; > > -- > > 2.38.0
Excerpts from Lorenzo Salvadore's message of Januar 10, 2023 5:10 pm: > Hello, > > Ping https://gcc.gnu.org/pipermail/gcc-patches/2022-November/605685.html > > I would like to remind that Gerald Pfeifer already volunteered to commit this patch > when it is approved. However the patch has not been approved yet. > Hi, sorry for belated reply. Yes is fine for now, I'm concerned that it'll just be the same again come FreeBSD 15, 16, 17... There needs to be a better mechanism to determine which FreeBSD version is being compiled for, but that shouldn't block this going in. OK.
------- Original Message ------- On Monday, January 23rd, 2023 at 3:45 PM, Iain Buclaw <ibuclaw@gdcproject.org> wrote: > > > Excerpts from Lorenzo Salvadore's message of Januar 10, 2023 5:10 pm: > > > Hello, > > > > Ping https://gcc.gnu.org/pipermail/gcc-patches/2022-November/605685.html > > > > I would like to remind that Gerald Pfeifer already volunteered to commit this patch > > when it is approved. However the patch has not been approved yet. > > > Hi, sorry for belated reply. > > Yes is fine for now, I'm concerned that it'll just be the same again > come FreeBSD 15, 16, 17... > > There needs to be a better mechanism to determine which FreeBSD version > is being compiled for, but that shouldn't block this going in. > > OK. Thanks, I will keep this concern in mind when FreeBSD 15 starts its development and then I will try to submit a patch proposing a better mechanism. Cheers, Lorenzo Salvadore
diff --git a/libphobos/libdruntime/core/sys/freebsd/config.d b/libphobos/libdruntime/core/sys/freebsd/config.d index 5e3129e2422..9d502e52e32 100644 --- a/libphobos/libdruntime/core/sys/freebsd/config.d +++ b/libphobos/libdruntime/core/sys/freebsd/config.d @@ -14,8 +14,9 @@ public import core.sys.posix.config; // NOTE: When adding newer versions of FreeBSD, verify all current versioned // bindings are still compatible with the release. - version (FreeBSD_13) enum __FreeBSD_version = 1300000; -else version (FreeBSD_12) enum __FreeBSD_version = 1202000; + version (FreeBSD_14) enum __FreeBSD_version = 1400000; +else version (FreeBSD_13) enum __FreeBSD_version = 1301000; +else version (FreeBSD_12) enum __FreeBSD_version = 1203000; else version (FreeBSD_11) enum __FreeBSD_version = 1104000; else version (FreeBSD_10) enum __FreeBSD_version = 1004000; else version (FreeBSD_9) enum __FreeBSD_version = 903000;