[v2] gdb/mi: add no-history stop reason
Commit Message
When executing in reverse and runs out of recorded history, GDB prints
a warning to the user, but does not add a reason in the stopped record,
for example:
*stopped,frame={addr="0x000000000040113e",func="main",args=[],file="/home/blarsen/Documents/fsf_build/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.reverse/solib-reverse.c",fullname="/home/blarsen/Documents/binutils-gdb/gdb/testsuite/gdb.reverse/solib-reverse.c",line="27",arch="i386:x86-64"},thread-id="1",stopped-threads="all",core="1"
This problem was reported as record/29260.
This commit adds the reason no-history to the record, making it easier
for interfaces using the mi interpreter to report the result. It also
changes the test gdb.mi/mi-reverse.exp to test that the reason shows up
correctly.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29260
---
Relevant changes for v2:
* Changed the gdb.mi test to confirm the stop reason shows up correctly.
* Used the correct method to report mi stop reason.
---
gdb/NEWS | 5 +++++
gdb/doc/gdb.texinfo | 2 ++
gdb/infrun.c | 5 ++++-
gdb/mi/mi-common.c | 1 +
gdb/mi/mi-common.h | 1 +
gdb/testsuite/gdb.mi/mi-reverse.exp | 2 +-
6 files changed, 14 insertions(+), 2 deletions(-)
Comments
>>>>> Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes:
> This problem was reported as record/29260.
> This commit adds the reason no-history to the record, making it easier
> for interfaces using the mi interpreter to report the result. It also
> changes the test gdb.mi/mi-reverse.exp to test that the reason shows up
> correctly.
Thank you. This is ok.
Tom
On 05/01/2023 21:00, Tom Tromey wrote:
>>>>>> Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes:
>> This problem was reported as record/29260.
>> This commit adds the reason no-history to the record, making it easier
>> for interfaces using the mi interpreter to report the result. It also
>> changes the test gdb.mi/mi-reverse.exp to test that the reason shows up
>> correctly.
> Thank you. This is ok.
Thanks!
pushed
> Tom
>
@@ -17,6 +17,11 @@ maintenance print record-instruction [ N ]
prints how GDB would undo the N-th previous instruction, and if N is
positive, it prints how GDB will redo the N-th following instruction.
+* MI changes
+
+** mi now reports 'no-history' as a stop reason when hitting the end of the
+ reverse execution history.
+
*** Changes in GDB 13
* MI version 1 is deprecated, and will be removed in GDB 14.
@@ -30860,6 +30860,8 @@ The inferior returned from a system call. This is reported when
@item exec
The inferior called @code{exec}. This is reported when @code{catch exec}
(@pxref{Set Catchpoints}) has been used.
+@item no-history
+There isn't enough history recorded to continue reverse execution.
@end table
The @var{id} field identifies the global thread ID of the thread
@@ -8406,7 +8406,10 @@ print_signal_received_reason (struct ui_out *uiout, enum gdb_signal siggnal)
void
print_no_history_reason (struct ui_out *uiout)
{
- uiout->text ("\nNo more reverse-execution history.\n");
+ if (uiout->is_mi_like_p ())
+ uiout->field_string ("reason", async_reason_lookup (EXEC_ASYNC_NO_HISTORY));
+ else
+ uiout->text ("\nNo more reverse-execution history.\n");
}
/* Print current location without a level number, if we have changed
@@ -39,6 +39,7 @@ static const char * const async_reason_string_lookup[] =
"syscall-entry",
"syscall-return",
"exec",
+ "no-history",
NULL
};
@@ -42,6 +42,7 @@ enum async_reply_reason
EXEC_ASYNC_SYSCALL_ENTRY,
EXEC_ASYNC_SYSCALL_RETURN,
EXEC_ASYNC_EXEC,
+ EXEC_ASYNC_NO_HISTORY,
/* This is here only to represent the number of enums. */
EXEC_ASYNC_LAST
};
@@ -159,7 +159,7 @@ proc test_controlled_execution_reverse {} {
"reverse-continue at callee3"
mi_execute_to "exec-continue --reverse" \
- "" "main" "" \
+ "no-history" "main" "" \
"basics.c" $line_main_body "" \
"reverse-continue at main"
}