Message ID | 20220921164737.3258130-1-tom@tromey.com |
---|---|
State | Superseded |
Headers |
Return-Path: <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0D0F93858293 for <patchwork@sourceware.org>; Wed, 21 Sep 2022 16:48:44 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by sourceware.org (Postfix) with ESMTPS id D50823858C53 for <gdb-patches@sourceware.org>; Wed, 21 Sep 2022 16:48:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D50823858C53 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id 2DC9E1005631C for <gdb-patches@sourceware.org>; Wed, 21 Sep 2022 16:47:50 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id b2t3odWhdvlAab2t3oh0Zz; Wed, 21 Sep 2022 16:47:50 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=S+wcfKgP c=1 sm=1 tr=0 ts=632b4036 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=xOM3xZuef0cA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=obUB_xv6KfrxGT96YCcA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=RBy4228A3wItX+kT7DbiT3TNcDD5oo69jOWEt06y4QM=; b=CpdhdIigVAamTFBhPOTalGotKW 7c+HVSGGy0NGPj24N0bZAncPlsy/M0kjYnjtOLTM+hAX1EFBHTD+O8BIZOCEHoIsMSTdVBjHV8Iv9 iCzs6ufs2BIYHqcLWdTuXjSVc; Received: from 71-211-160-49.hlrn.qwest.net ([71.211.160.49]:47174 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from <tom@tromey.com>) id 1ob2t3-001R0H-1R; Wed, 21 Sep 2022 10:47:49 -0600 From: Tom Tromey <tom@tromey.com> To: gdb-patches@sourceware.org Subject: [PATCH] Deprecate MI version 1 Date: Wed, 21 Sep 2022 10:47:37 -0600 Message-Id: <20220921164737.3258130-1-tom@tromey.com> X-Mailer: git-send-email 2.34.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.160.49 X-Source-L: No X-Exim-ID: 1ob2t3-001R0H-1R X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-160-49.hlrn.qwest.net (localhost.localdomain) [71.211.160.49]:47174 X-Source-Auth: tom+tromey.com X-Email-Count: 12 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3028.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> Cc: Tom Tromey <tom@tromey.com> Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
Deprecate MI version 1
|
|
Commit Message
Tom Tromey
Sept. 21, 2022, 4:47 p.m. UTC
MI version 1 is long since obsolete. Rather than remove it immediately (though I did send a patch for that), instead let's deprecate it in GDB 13 and then remove it for GDB 14. --- gdb/NEWS | 2 ++ 1 file changed, 2 insertions(+)
Comments
On 2022-09-21 12:47, Tom Tromey wrote: > MI version 1 is long since obsolete. Rather than remove it > immediately (though I did send a patch for that), instead let's > deprecate it in GDB 13 and then remove it for GDB 14. > --- > gdb/NEWS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gdb/NEWS b/gdb/NEWS > index 555ef2ddf77..e834e97dacc 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -3,6 +3,8 @@ > > *** Changes since GDB 12 > > +* MI version 1 is deprecated, and will be removed in GDB 14. > + > * GDB now supports dumping memory tag data for AArch64 MTE. It also supports > reading memory tag data for AArch64 MTE from core files generated by > the gcore command or the Linux kernel. LGTM. Do you think it would be worth printing a warning when initializing an mi1 interp, something like this? There might be some people using / maintaing some frontend somewhere that are more likely to see this than the NEWS file. From f2d148e8787d1c4b4c1c4218646a87157f5fac82 Mon Sep 17 00:00:00 2001 From: Simon Marchi <simon.marchi@polymtl.ca> Date: Wed, 21 Sep 2022 13:06:47 -0400 Subject: [PATCH] warn Change-Id: Ia38707b24ce0d0ab519b189464ded828f5669c27 --- gdb/interps.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/gdb/interps.c b/gdb/interps.c index 3a9c590b8c87..c26bc0f0f6fd 100644 --- a/gdb/interps.c +++ b/gdb/interps.c @@ -171,11 +171,16 @@ interp_set (struct interp *interp, bool top_level) if (interpreter_p != interp->name ()) interpreter_p = interp->name (); + bool warn_about_mi1 = false; + /* Run the init proc. */ if (!interp->inited) { interp->init (top_level); interp->inited = true; + + if (streq (interp->name (), "mi1")) + warn_about_mi1 = true; } /* Do this only after the interpreter is initialized. */ @@ -185,6 +190,10 @@ interp_set (struct interp *interp, bool top_level) clear_interpreter_hooks (); interp->resume (); + + if (warn_about_mi1) + warning (_("MI version 1 is deprecated and will be removed in a future " + "version, please upgrade to a newer MI version.")); } /* Look up the interpreter for NAME. If no such interpreter exists, base-commit: fbe8f9569eb56a007cace0be366dd137e2821e2a
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
Simon> LGTM. Do you think it would be worth printing a warning when
Simon> initializing an mi1 interp, something like this? There might be some
Simon> people using / maintaing some frontend somewhere that are more likely to
Simon> see this than the NEWS file.
It would be fine by me.
Tom
On 2022-09-21 14:38, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes: > > Simon> LGTM. Do you think it would be worth printing a warning when > Simon> initializing an mi1 interp, something like this? There might be some > Simon> people using / maintaing some frontend somewhere that are more likely to > Simon> see this than the NEWS file. > > It would be fine by me. > > Tom Feel free to integrate it in your patch if you'd like. Simon
On 9/21/22 18:07, Simon Marchi via Gdb-patches wrote: > > > On 2022-09-21 12:47, Tom Tromey wrote: >> MI version 1 is long since obsolete. Rather than remove it >> immediately (though I did send a patch for that), instead let's >> deprecate it in GDB 13 and then remove it for GDB 14. >> --- >> gdb/NEWS | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/gdb/NEWS b/gdb/NEWS >> index 555ef2ddf77..e834e97dacc 100644 >> --- a/gdb/NEWS >> +++ b/gdb/NEWS >> @@ -3,6 +3,8 @@ >> >> *** Changes since GDB 12 >> >> +* MI version 1 is deprecated, and will be removed in GDB 14. >> + >> * GDB now supports dumping memory tag data for AArch64 MTE. It also supports >> reading memory tag data for AArch64 MTE from core files generated by >> the gcore command or the Linux kernel. > > > LGTM. Do you think it would be worth printing a warning when > initializing an mi1 interp, something like this? There might be some > people using / maintaing some frontend somewhere that are more likely to > see this than the NEWS file. > > >>From f2d148e8787d1c4b4c1c4218646a87157f5fac82 Mon Sep 17 00:00:00 2001 > From: Simon Marchi <simon.marchi@polymtl.ca> > Date: Wed, 21 Sep 2022 13:06:47 -0400 > Subject: [PATCH] warn > > Change-Id: Ia38707b24ce0d0ab519b189464ded828f5669c27 > --- > gdb/interps.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/gdb/interps.c b/gdb/interps.c > index 3a9c590b8c87..c26bc0f0f6fd 100644 > --- a/gdb/interps.c > +++ b/gdb/interps.c > @@ -171,11 +171,16 @@ interp_set (struct interp *interp, bool top_level) > if (interpreter_p != interp->name ()) > interpreter_p = interp->name (); > > + bool warn_about_mi1 = false; > + > /* Run the init proc. */ > if (!interp->inited) > { > interp->init (top_level); > interp->inited = true; > + > + if (streq (interp->name (), "mi1")) > + warn_about_mi1 = true; > } > > /* Do this only after the interpreter is initialized. */ > @@ -185,6 +190,10 @@ interp_set (struct interp *interp, bool top_level) > clear_interpreter_hooks (); > > interp->resume (); > + > + if (warn_about_mi1) > + warning (_("MI version 1 is deprecated and will be removed in a future " > + "version, please upgrade to a newer MI version.")); > } We should probably be more explicit about deprecating it for GDB 13 and then removing it in GDB 14. What do you think?
> We should probably be more explicit about deprecating it for GDB 13 and then removing > it in GDB 14. What do you think? Yeah, good idea. Simon
diff --git a/gdb/NEWS b/gdb/NEWS index 555ef2ddf77..e834e97dacc 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -3,6 +3,8 @@ *** Changes since GDB 12 +* MI version 1 is deprecated, and will be removed in GDB 14. + * GDB now supports dumping memory tag data for AArch64 MTE. It also supports reading memory tag data for AArch64 MTE from core files generated by the gcore command or the Linux kernel.