diff mbox series

Add myself for write after approval

Message ID 20220701020204.58464-1-haochen.jiang@intel.com
State Committed
Commit 53b2a1a5d6f848a3e54228daefa47c3565c2ac3a
Headers
Series Add myself for write after approval |

Commit Message

Jiang, Haochen July 1, 2022, 2:02 a.m. UTC 
  Hi all,

I want to add myself in MAINTAINERS for write after approval.

Ok for trunk?

BRs,
Haochen

ChangeLog:

	* MAINTAINERS (Write After Approval): Add myself.
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

Comments

Hongtao Liu July 1, 2022, 2:22 a.m. UTC | #1 
I think this can be taken as an obvious fix without prior approval.
"Obvious fixes can be committed without prior approval. Just check in
the fix and copy it to gcc-patches."
Quoted from https://gcc.gnu.org/gitwrite.html

On Fri, Jul 1, 2022 at 10:02 AM Haochen Jiang via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Hi all,
>
> I want to add myself in MAINTAINERS for write after approval.
>
> Ok for trunk?
>
> BRs,
> Haochen
>
> ChangeLog:
>
>         * MAINTAINERS (Write After Approval): Add myself.
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 151770f59f4..3c448ba9eb6 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -464,6 +464,7 @@ Harsha Jagasia                                      <harsha.jagasia@amd.com>
>  Fariborz Jahanian                              <fjahanian@apple.com>
>  Surya Kumari Jangala                           <jskumari@linux.ibm.com>
>  Qian Jianhua                                   <qianjh@fujitsu.com>
> +Haochen Jiang                                  <haochen.jiang@intel.com>
>  Janis Johnson                                  <janis.marie.johnson@gmail.com>
>  Teresa Johnson                                 <tejohnson@google.com>
>  Kean Johnston                                  <jkj@sco.com>
> --
> 2.18.1
>
Jeff Law July 1, 2022, 5:43 a.m. UTC | #2 
On 6/30/2022 8:22 PM, Hongtao Liu via Gcc-patches wrote:
> I think this can be taken as an obvious fix without prior approval.
> "Obvious fixes can be committed without prior approval. Just check in
> the fix and copy it to gcc-patches."
> Quoted from https://gcc.gnu.org/gitwrite.html
If we've given someone write access, they need to be listed in the 
MAINTAINERsS file, so yes, this is something I'd consider obvious.

In fact, I thought the template message we sent to folks when they're 
given write access includes a request to add a new entry to the 
MAINTAINERS file.

Jeff
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 151770f59f4..3c448ba9eb6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -464,6 +464,7 @@  Harsha Jagasia					<harsha.jagasia@amd.com>
 Fariborz Jahanian				<fjahanian@apple.com>
 Surya Kumari Jangala				<jskumari@linux.ibm.com>
 Qian Jianhua					<qianjh@fujitsu.com>
+Haochen Jiang					<haochen.jiang@intel.com>
 Janis Johnson					<janis.marie.johnson@gmail.com>
 Teresa Johnson					<tejohnson@google.com>
 Kean Johnston					<jkj@sco.com>