Message ID | ec8ebf7a-793d-6aa1-f550-0f1cc0b15ce0@suse.com |
---|---|
State | New |
Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D84E038356A9 for <patchwork@sourceware.org>; Fri, 27 May 2022 08:02:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D84E038356A9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1653638533; bh=P63eL+bAn1nrNkkaX/oi7jqgi9qwoQldAM838crUzRw=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Oi/aXLOVD29PHnvc961/YJaRkLMMvhwmHhzoy0VKBlXmQjqFpuU99OFrGsYlQL9WX 4gR0fbJbQ/yjYv0oGJeIe+PT3onIRyhE596S9nHEUf2n94NkcLwN7sTtTmdb426mxc TaP7WvmEC1mUFDzQYv9jH5ie3gE8r8WiSSIyRC4o= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by sourceware.org (Postfix) with ESMTPS id 183C93836650 for <gcc-patches@gcc.gnu.org>; Fri, 27 May 2022 08:01:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 183C93836650 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2051.outbound.protection.outlook.com [104.47.13.51]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-41-Wt8gZ0eDNR-0MbvMimNaSw-1; Fri, 27 May 2022 10:01:41 +0200 X-MC-Unique: Wt8gZ0eDNR-0MbvMimNaSw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HTbW7lwTg7Dt6hBzSjNnbwE4Yg9T8CrD6afQbFWgzcybbrPpfnd5QiNHfUsK79DCgT+7x4vbIwuJ75/ZhcS2jRYdssYvtGrFBwR6WFZVCMeMNBf+QEK9JdEspDMPL0WwJgb1cSzIUAVmXo6VxEXST0c1hGqXg8GOalZnyVOPFFsloLloN8OIpFU+EGviU87kOn76rtqdd7FgtT3qibXRElBoNfW9QSrac7H8YGaC9qoH7v472ejMKdy4UAViu5mYvqcXxJz+Z47edIfYLf0fpltixX/iYMWWvh5iXZhGYeYLTuu4oGCRTTH+89J/Ue/8R1QsBPUT7t+2AiBvpLVPgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P63eL+bAn1nrNkkaX/oi7jqgi9qwoQldAM838crUzRw=; b=VXc2Sc7xt+xzMKEEwz2gWIRQ1sQdxpSkPcQlhCRKFmD4yvGyYjfWf8XNH0GTDVtW+/RE1UJ3+opZ+/dtyi/hOHiw0K7mUAbLqb51StXciVp+YLf36nYkWDSJNnxht2CpGhB/jifKnpK0PEYaYZez2Jl1cm1/4TGgpCOhgmfNRiWmdtC9bghZfKizw4Lep0njcLY9NjaLjFHnOj1rQhilPzZbGqVtMzt0ba8Fvq3Q29M11bIkHrpM1OfR/bk3JAEWmfRuZIK3Agd8FO+ExZdIS0SE3qmYR/lr30vOmeqcVLjlsVtcxPXX5ThfqfCUMnKnVYmknNoZ+dVO2Ljpwnl9Fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7847.eurprd04.prod.outlook.com (2603:10a6:20b:2ad::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Fri, 27 May 2022 08:01:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5293.013; Fri, 27 May 2022 08:01:39 +0000 Message-ID: <ec8ebf7a-793d-6aa1-f550-0f1cc0b15ce0@suse.com> Date: Fri, 27 May 2022 10:01:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US To: gcc-patches@gcc.gnu.org Subject: libatomic: drop redundant all-multi command Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0398.eurprd06.prod.outlook.com (2603:10a6:20b:461::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e12a7882-3930-4b2f-4490-08da3fb7214e X-MS-TrafficTypeDiagnostic: AS8PR04MB7847:EE_ X-Microsoft-Antispam-PRVS: <AS8PR04MB7847DDC9C0D4BBBC9D40BC5CB3D89@AS8PR04MB7847.eurprd04.prod.outlook.com> X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1I+FLLnhde7KR3MmWPRDy86a10kjRhNcPbWrmIgBnFZgOI5H0cVfcxsfTCvO2b+mFhqS1OkHfbUuKXsaD9ccxn3kPQZOdGS24JX0gHtJqgrfzB2rFG7z2tY1AFJRi6yUU1FVDz+LwH72bFTiz3HVchTnRy6to2nAx0CHugSbCno0H5s3Lx4fS0lW6xkRgeWO3tNjhsWGbeEGwpLh6nVUQqBdl2/uOzku6L4S+MyJsAu7cpQ4LYvvqsz86Y5apEw+zIVUn1jUqvW+0prYXy0G9pUXXIUPu1+az4tGq2DR4Ia8cndE9yfuIUAJPx3vEere4m+saaijuFujQ0j3E2lhk/37ctQ/7bQrqb8jCpQ9yMnZaBjdwjLgPt9mxJOnXhMeth1eAdyrc4VKC4YR7DLG26VGm+SUzplmaKlfaKj+GJtBwjB6OSBDhQ7/mlSQ7cD3PdUDcYGYYsXB5t0yhO2aDOSLd2oBRtBvEH+/ipxu+NBB21p/M5B0zzOvfjJpKmem6Nf+Ovl8NYtyVQz1ypJXUHql7kWenqRulYJpwTz/JJYZY2zsBNaUL9wtRXGz2IaGKgFehPmTfrzuwRCFBFVxg22UjY1pnZdip2vyiofC1e+OG+pna0hDNEmsk3ZJe/eN+BTI9B9CTQSUwIDRw8qK3voHWuQ8WPrz5eELQgZZvi7Hf5OJevszV7H1B4+M/nGq8zbia2/inODOqRjPLFhBbDu1z1v0kKmeXg01HVhiKtFoxNyrT+AgZ0B06l5sXovM X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(31686004)(66476007)(2616005)(83380400001)(66556008)(66946007)(36756003)(2906002)(6512007)(6506007)(26005)(86362001)(31696002)(186003)(8676002)(38100700002)(508600001)(5660300002)(6486002)(8936002)(316002)(6916009)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?/5BxJcO+uQ/Ijk3sQJSSsECuUVZj?= =?utf-8?q?LaKBRsLtdbF/A1BXKFNRXxt6pawPptWk5NFyxs/JGYC9s1xa7irV91373H49c1T7I?= =?utf-8?q?Rx2wzaSQe1ClcF7le1XO5KY0c40FMJUMju3esGf0qLp3XBpMxKZ3PsIsBAkoIJElt?= =?utf-8?q?xFWOtYjqgNt2DPsTtkocWNBb4Gd1DgEd5IHwGaaT5FLZiUEKnCZo5Y4UmN2S0BrPv?= =?utf-8?q?y28VU5zvRCK9Nn1ujFDJux9XZ7opMJ9hF+f/PYaDV3BtaNF84woKRyj80ZJp/oDfo?= =?utf-8?q?7KR26NYyARnolB69zXuUkFuk26ElTPJ97DjuOX++ktARsgBBZ7jdIvw5axXmWk+kR?= =?utf-8?q?ev8CIZPp1sbsNfUaIJ4UpE1QiYfw6nGL2EJcOU+L6KZi0G/WUbbuxqkrN+fmI89Fc?= =?utf-8?q?XBgk8LirmIe/33znFmUJb3aalPQYLqEANBbtV2lhIKg5DStJb2C+2WEm0JnDlrgbL?= =?utf-8?q?uzemG5X21XRb5hEOtQm9vhUSyokN0huP2YgV3FuaKApz7piL7/LCun9sA4/3gHfJP?= =?utf-8?q?wuEl7E5bAgJ5YcFhejROQoRhiRXHbG3TUiPI60wENRP0DhtQz0bnznVv3oAlKjfjo?= =?utf-8?q?vnPoPcipkELJ2CPlVC45x662tglnX38TRNEL7qehjfRRwzL/3ISvn0V/thse172ih?= =?utf-8?q?MkdkjY/GYGwN5rRb/JvkrbTtQlF407W5HTDE4Wp0saCLzwZlouJhoADeIHXx22U+H?= =?utf-8?q?xe3vE5JPVP4vkjBXe0/4Hw+COQxBxQK37D3dyxs44Kbgem/N4MATscfV7jkUioOV/?= =?utf-8?q?piokakFkmBj7qxOJ/zFYxDvKLetpmkNmw5H0rMHipHRUIgasvzGjkhhh4rph4zUWs?= =?utf-8?q?Z4q5UfUOeWGCb1hXjsyPHyVGsnMkViVRxgCJ/uqB1i045F0Vam8E7HWSQ9Glnnlzp?= =?utf-8?q?QzQFz6kJYymk4h7qqJyZD3CMFu6zvf3fJ+/bEqtu8vIDb8cvukeWJwiKghEpI653k?= =?utf-8?q?Rm4TgUrK3xFKtjmQYQ/En/QZxLOQ/mDa3RY0AJFpQZre50G8H6jQboGAtYGb3lki9?= =?utf-8?q?iUeW/zy0mESlsnG30rbb3LM3OABk/ogNJmZ78NMoE7uZmm2TUdsq9NfOSiMS7BNXF?= =?utf-8?q?E5iQ3/BQM9n1JTT5sPpU+6Th+DvgPjqqU5+pScav8PspvcAlbkz2WANW3mFefDgpv?= =?utf-8?q?OCblkZSgv3iZZRIy0yNIfxOTtqqOtKMlEKBmyAsq+Ts0DHkAohAvMI9kpQ0QoXzDV?= =?utf-8?q?LrOH7hxG2L6gMfasrialjYX6xyinGqmRPsq5o+aOChSaCCYP4rYlK+AmeHuGCJ97f?= =?utf-8?q?JwNgn82XcLPLyiX2cIOpSH/jk6w0xzuVJsDJQMjxMm6OUoZBuMWQo4RIgTtSMQy7v?= =?utf-8?q?TQ6J8ynuQlVhEd2p84Dap/uEIk6pzdaf14G6rRrtq5Pkcs4y7ow7MISy4toxdjhGW?= =?utf-8?q?13SonkhBsQmQXSOV+SkrzOWbTcfj1XNKhnXO2yvhjQj20iPqSqa7fhtcHO/LrAc+M?= =?utf-8?q?1BAwLzhnCzmoK0f6LeoNBsyzVhtVHV+8686M10hPKaErl9FvUauWq9NQJMk84ag83?= =?utf-8?q?ceQ83OVTrteIHmNtdRljXfeGyyel4EUUtdIWx+4I+Z0bX3cq9IYzm3FH+eX21WUg2?= =?utf-8?q?oM2vlX9mHeZn4umDNvRCfRbWsSe7cB4tv50KIzJKe5t398LbKNEzz2fSilm+mYnMX?= =?utf-8?q?o2ejmrETIx0DiWWZaqm4RbOnQRVK0bkg=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e12a7882-3930-4b2f-4490-08da3fb7214e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2022 08:01:39.8095 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5b/+gY6Lus5C2imxH6ZSWYlpqhbQFzedGYdma1QgJrPX8TorHnGXvapoKHc7uO4Y9DiJxDYoTeBntEpGbY6Rtg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7847 X-Spam-Status: No, score=-3031.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: Jan Beulich via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: Jan Beulich <jbeulich@suse.com> Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> |
Series |
libatomic: drop redundant all-multi command
|
|
Commit Message
Jan Beulich
May 27, 2022, 8:01 a.m. UTC
./multilib.am already specifies this same command, and make warns about the earlier one being ignored when seeing the later one. All that needs retaining to still satisfy the preceding comment is the extra dependency. libatomic/ 2022-05-XX Jan Beulich <jbeulich@suse.com> * Makefile.am (all-multi): Drop commands. * Makefile.in: Update accordingly.
Comments
On 5/27/2022 2:01 AM, Jan Beulich via Gcc-patches wrote: > ./multilib.am already specifies this same command, and make warns about > the earlier one being ignored when seeing the later one. All that needs > retaining to still satisfy the preceding comment is the extra > dependency. > > libatomic/ > 2022-05-XX Jan Beulich <jbeulich@suse.com> > > * Makefile.am (all-multi): Drop commands. > * Makefile.in: Update accordingly. OK for the trunk. jeff
On 27.05.2022 10:01, Jan Beulich wrote: > ./multilib.am already specifies this same command, and make warns about > the earlier one being ignored when seeing the later one. All that needs > retaining to still satisfy the preceding comment is the extra > dependency. > > libatomic/ > > * Makefile.am (all-multi): Drop commands. > * Makefile.in: Update accordingly. Ping? Thanks, Jan > --- a/libatomic/Makefile.am > +++ b/libatomic/Makefile.am > @@ -147,12 +147,11 @@ > libatomic_convenience_la_SOURCES = $(libatomic_la_SOURCES) > libatomic_convenience_la_LIBADD = $(libatomic_la_LIBADD) > > -# Override the automake generated all-multi rule to guarantee that all-multi > +# Amend the automake generated all-multi rule to guarantee that all-multi > # is not run in parallel with the %_.lo rules which generate $(DEPDIR)/*.Ppo > # makefile fragments to avoid broken *.Ppo getting included into the Makefile > # when it is reloaded during the build of all-multi. > all-multi: $(libatomic_la_LIBADD) > - $(MULTIDO) $(AM_MAKEFLAGS) DO=all multi-do # $(MAKE) > > # target overrides > -include $(tmake_file) > --- a/libatomic/Makefile.in > +++ b/libatomic/Makefile.in > @@ -858,12 +858,11 @@ > %_.lo: Makefile > $(LTCOMPILE) $(M_DEPS) $(M_SIZE) $(M_IFUNC) -c -o $@ $(M_SRC) > > -# Override the automake generated all-multi rule to guarantee that all-multi > +# Amend the automake generated all-multi rule to guarantee that all-multi > # is not run in parallel with the %_.lo rules which generate $(DEPDIR)/*.Ppo > # makefile fragments to avoid broken *.Ppo getting included into the Makefile > # when it is reloaded during the build of all-multi. > all-multi: $(libatomic_la_LIBADD) > - $(MULTIDO) $(AM_MAKEFLAGS) DO=all multi-do # $(MAKE) > > # target overrides > -include $(tmake_file)
On 6/28/2022 12:52 AM, Jan Beulich via Gcc-patches wrote: > On 27.05.2022 10:01, Jan Beulich wrote: >> ./multilib.am already specifies this same command, and make warns about >> the earlier one being ignored when seeing the later one. All that needs >> retaining to still satisfy the preceding comment is the extra >> dependency. >> >> libatomic/ >> >> * Makefile.am (all-multi): Drop commands. >> * Makefile.in: Update accordingly. > Ping? Weird, I thought I'd acked this already, but I can't find it in my outbox. OK for the trunk. jeff
--- a/libatomic/Makefile.am +++ b/libatomic/Makefile.am @@ -147,12 +147,11 @@ libatomic_convenience_la_SOURCES = $(libatomic_la_SOURCES) libatomic_convenience_la_LIBADD = $(libatomic_la_LIBADD) -# Override the automake generated all-multi rule to guarantee that all-multi +# Amend the automake generated all-multi rule to guarantee that all-multi # is not run in parallel with the %_.lo rules which generate $(DEPDIR)/*.Ppo # makefile fragments to avoid broken *.Ppo getting included into the Makefile # when it is reloaded during the build of all-multi. all-multi: $(libatomic_la_LIBADD) - $(MULTIDO) $(AM_MAKEFLAGS) DO=all multi-do # $(MAKE) # target overrides -include $(tmake_file) --- a/libatomic/Makefile.in +++ b/libatomic/Makefile.in @@ -858,12 +858,11 @@ %_.lo: Makefile $(LTCOMPILE) $(M_DEPS) $(M_SIZE) $(M_IFUNC) -c -o $@ $(M_SRC) -# Override the automake generated all-multi rule to guarantee that all-multi +# Amend the automake generated all-multi rule to guarantee that all-multi # is not run in parallel with the %_.lo rules which generate $(DEPDIR)/*.Ppo # makefile fragments to avoid broken *.Ppo getting included into the Makefile # when it is reloaded during the build of all-multi. all-multi: $(libatomic_la_LIBADD) - $(MULTIDO) $(AM_MAKEFLAGS) DO=all multi-do # $(MAKE) # target overrides -include $(tmake_file)