| Message ID | a2ecdd37-91e6-f67b-7e47-d7ddeaa1fbf5@suse.com |
|---|---|
| State | New |
| Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7A779396E47F for <patchwork@sourceware.org>; Thu, 2 Jun 2022 15:05:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7A779396E47F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1654182313; bh=GW+dHUqs1G5BplrZLNT1EqTkWzjaxIqLzz8IKdvVark=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=UCZU7C9IyMRg6/jSocMqVRwlassIWKaZuPEx9dgJvpVNnQq8QfJuf1oAjE6PuvEk/ KYTKLm1Jtx24aq2vD6QHkHR3XNdDO5WxG9wBYd7bbjohOYmRR62hM2pItSLB36s7uL FfsA1OYMdqhAt4kRMyYIK8/RIDTPvFA3khaqi3RU= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by sourceware.org (Postfix) with ESMTPS id 8A9BB396E05C for <gcc-patches@gcc.gnu.org>; Thu, 2 Jun 2022 15:04:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8A9BB396E05C Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2170.outbound.protection.outlook.com [104.47.17.170]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-20-Snx62OWFMLiyFKiy5Gv63g-1; Thu, 02 Jun 2022 17:04:38 +0200 X-MC-Unique: Snx62OWFMLiyFKiy5Gv63g-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GDg6iDRkhXt4aP6k+PjI5d3HfOZswBnNMtBRFboHYj6OwZzhr/qIpAHj8paphCxhE3TwGOzZkKMw0GcsDKjPFxtfxesrI536o7GL48jfJLTyGuQ1DrpO7rKIrf8JG/Jm1LzloCuQ8/UwMjMTIPk9Yf08xn5vyJnIBdOsuMadVLPRfk+RHjvrvNHsXNOeKPVmOseUsmhsA1anTr/5uDZWOvfeDHKeu+vHx9OVEF2WnkJH4e+CROBeUC3M7zexQi3ZEUObcUbA2qthqBlRuc/ysHddIekR9Laum2RYgpDpdKn9C6JrlPKnaPYK/KgY+J39S3s2hydOod9WknBZnWqibw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GW+dHUqs1G5BplrZLNT1EqTkWzjaxIqLzz8IKdvVark=; b=AaJ6HqMnl7E8zMBojI2UjCO0Z2FZBm4HdEU3J5D4EWx/8e+A0bbz1wPVa5guUTbdf7REynJIxZXZwuMG2rPnBnCvZQRfF75jkAfHB7Zgk7uwXGdphGCIAJpAQFwBBaFlOArTetwV7vB0ZUZVx8htLD4DsnTkg5XvlOHweMP2MkOEbFSXYf7J03cexigzQdzrIVm4v9C2uxD9dWCOqBrxuS7Oq4otJDaLPwHuSamtafD724vChbsmgWgcy2Us7ChqCqMcGrb6ucHqWR2alblBV5ah0NOZjK6aTgm/ekIE818BsUR+358C9yTUZu+xxZtiz0Rcoey0SlISwQTBOTP8Nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR0401MB2552.eurprd04.prod.outlook.com (2603:10a6:4:37::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13; Thu, 2 Jun 2022 15:04:36 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5314.013; Thu, 2 Jun 2022 15:04:36 +0000 Message-ID: <a2ecdd37-91e6-f67b-7e47-d7ddeaa1fbf5@suse.com> Date: Thu, 2 Jun 2022 17:04:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: [PATCH] x86: harmonize __builtin_ia32_psadbw*() types To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org> Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR10CA0106.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::47) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 50d6d338-1bc1-4c6c-d3ec-08da44a93531 X-MS-TrafficTypeDiagnostic: DB6PR0401MB2552:EE_ X-Microsoft-Antispam-PRVS: <DB6PR0401MB255245802DD10E1752E7E733B3DE9@DB6PR0401MB2552.eurprd04.prod.outlook.com> X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Pqk8qBfyZ9ec7iVZyTR8O27quoxbaB2NSyff+zKBqD7cJ4a08jxt0i9eHbpbuWElGUkitkV6k7PTAg4LEmS41NWZQch+nsF8Kta6ACONhEGv7FRelEeVB0WUBst+szzHoxKuXPZk6dyBRxhdVbIRDezLEu8XIwTOPZ4lVMRsVn/lQ8uccUGK0BfW8L5UrSHT7cX3iyca+DW+bZyOnTxBipLcbL+8q0G9Yxbc6PjOK7ALSCHeb/YKr+cDaBquVhRVVfE/VLfG5SC4WvO+DUj0oPA3wmZG6Cz8kWjKeSOB488iR6e12bUkHMmWLl/Q26B7MHAVSwXC9hP+PTLr+1E+KC1fJxvHDEtQAaVIu/D2F3VieRFF2h+97z9B5kykFHH5xLRHckuXdP+K765U16amsLzRo4z1uj3HGvBQ8+/kp8CBOTMkgno4STwvtfdkNlU0jHWoEB1rCUsinTga1EEGk9P1gQMK9/4bbzQVRMyxiCeR86Hl5/ywIQh0yUd4HrD6BAuxW3AiRw3CBP42rxqrfWmeuijIBcS/Ra7G8PQFOz9jFGRJVki3tDTW9g/iimacSFn6ek9uvlkPQRUr9clrCLf1rZiWXiGd69oO0JR4xQYa5XH1R+nwOcHdaNgZurHXCn6s6jo9ZGruGM7XffnVcSODpHTGY8Ey4jHzpzzFJMj9rOQIvuOSe2wP/ceW68qOGo/XYAx2NViPbn6eqRzgdu/NJTjI5FLuK9GB7+rdGf2kewXfwJquZcY+g8YT4a4o X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(36756003)(4326008)(8676002)(2906002)(66476007)(66556008)(66946007)(316002)(54906003)(6916009)(6486002)(508600001)(6512007)(31686004)(26005)(6506007)(5660300002)(2616005)(31696002)(38100700002)(86362001)(8936002)(186003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?BMMv9Xi3mQ5oepiHXuNc4gxhEoXQ?= =?utf-8?q?hqioCGHfrrnXafT5oOc3DmlDoKKWS/+0u0VYuSQ+DIAl8PF8qUf0T1uPCU2R0ojZD?= =?utf-8?q?MJR30C9ZdhdQcLptQs6t72/IErFuSBjJk6chbRFn9t5FrMNi7vDnvAc/qvvb0VpxV?= =?utf-8?q?IC9hDGtdsknaJDHln088v7CjC0WXHhQ3Im2UKI40YkE+2bSxOBerxua+NA2RFjxQd?= =?utf-8?q?W5uk2SX3zEfY+0QHglc1XleGZO/JMO8F2bbA2s6pVSOyZ+YvJYKpcXfVtgsOUTCEo?= =?utf-8?q?BliMgTUH1w4rxnzncHAiA4PQ3PKUq5DGGdXtP10PpK/QRrujMlmrKay5nEsvCpbMs?= =?utf-8?q?I0oOU/tj5ytnls6RWQX52fa7K3co5+9a7HredElbYn8MqLMqu+c0MR0rq9utfNtWh?= =?utf-8?q?B2RQ/BB/FecWrlLvROryvIQc2c5uRc33LI79koEr/MQ6tjtFbyI3cLhb+PV59WBIa?= =?utf-8?q?mVEKlRNk7g5IAsV5O2xiLU1BsUorbpWty/e5JUcP1LP8bbLTI3OhAnDqO7/7+oyeA?= =?utf-8?q?T/vT2ikbfttke3APXWcIZf1Z3DzCr4FdBubsl/o60NqzCarpwtbqCAAHqNt8q46Hi?= =?utf-8?q?Oh5EhRqGNIoy5OOeZ0uAczzkYPv63lPPYHU/Wiu6voHGYbmcC4DnOw3hOL7WNsNCA?= =?utf-8?q?mHhP9GhTrWUxesoWodB3+wVOTUi7YV68ITFk7Gh5clpdGnFFhOc+eKALzPTBYeYE0?= =?utf-8?q?0W+cR+yrppZzNy9BZcJTZdiwO45J5YNaCNbEiVO0y69zUnbwBAI26tEHYqFJklEaF?= =?utf-8?q?6OJXh0q3DP58rvawt8GMO3OsztqeO3XG/DDh0068xfkXt4D+ast2viRxO9e4w/sw6?= =?utf-8?q?gm6xSal/8oQa37/KcS3RGThYn8x5A0iCMyMSstumqGTj/uIH2UEoLoOgHZvUnY7Y9?= =?utf-8?q?MYxoF2P32cbpo2UjpCbrNYR0c/t1PlIMO5PNzRIQTXdYwTxIMQWskg5e02VC6h7QZ?= =?utf-8?q?NCFRfnRZCGJcjjnKF/vFXUyaI2fKTini6twQ/w0aL5T9WsARLpn2SR1sf6dRTmpoV?= =?utf-8?q?K4y3ObAxtshtn6lHL61VAHxE0szUMmYG4VhNrd1cq6qxnXNgQdAxrOA1d6kHpvop/?= =?utf-8?q?mN9bCTPLZ7aqmR++VsrjnuvFbjdstyeJdKBWbSlzRI7a1Ohc0HWMsKwdawh7mcjr4?= =?utf-8?q?j4/iC3/n1U4tsM04/j0wP3mtije+MogwFCmn9dggzGcPFG4WPKM5BF2AyR6xCr6sG?= =?utf-8?q?yZqvJiIHH5+bMSdZ+QJqBNI+/1z/IseKjLZmlSk9W5FNvFHZAr87RdvMOrb1eH2Vy?= =?utf-8?q?ASLaWPVeiKHUvMZ/bCfGbN4mPiFv+qcIuIOPTpZnNKE8d93Q4Mbv3NOza5pmR44bP?= =?utf-8?q?AJ2M7gkXUGk7SZ8aUyXo0U1+H9IYluTqbcApWyQzY89Ive2hJcqD/2lkhsocpr6/S?= =?utf-8?q?ceMs2T0BTfTiEabIlAfewOaAqFw+ektLsECzg7TfUqBklLc4TGq54LepmWfIDZ+AD?= =?utf-8?q?kqkdBHubZXH22/nbcvmtT6HJXcOhjl7N6Iki6Mets3QlFSulis1HF2FSdCwcciPln?= =?utf-8?q?utKMFFKyMOPdrF4pF913XbwpuTK/nJoaglXTE/y7HoU5FC76UuX23i5/GmClRl8Po?= =?utf-8?q?OPq8XYnfHSvNDx6fDYqPL2eurJ3tpKQ4+mSnylGqWW4sYCR8aPP7KwOSz8/G8vwbh?= =?utf-8?q?uDmtOKQVjZ/NGdfhjxP0zsVYTCyoVYoQ=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50d6d338-1bc1-4c6c-d3ec-08da44a93531 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2022 15:04:36.0216 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3SYQIe2yvdP5MD1aGooprJxeQx8jQVtcYzSX/a6sbAS/9F3Yc+4idBebv60tTAZJ80Idm+GWAHSfFGxMKnLx7w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2552 X-Spam-Status: No, score=-3031.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: Jan Beulich via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: Jan Beulich <jbeulich@suse.com> Cc: Hongtao Liu <hongtao.liu@intel.com>, "hubicka@ucw.cz" <hubicka@ucw.cz> Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> |
| Series |
x86: harmonize __builtin_ia32_psadbw*() types
|
|
Commit Message
Jan Beulich
June 2, 2022, 3:04 p.m. UTC
The 64-bit, 128-bit, and 512-bit variants have V<n>DI return type, in line with instruction behavior. Make the 256-bit builtin match, thus also making it match the insn it expands to (using VI8_AVX2_AVX512BW). gcc/ * config/i386/i386-builtin.def (__builtin_ia32_psadbw256): Change type. * config/i386/i386-builtin-types.def: New function type (V4DI, V32QI, V32QI). * config/i386/i386-expand.cc (ix86_expand_args_builtin): Handle V4DI_FTYPE_V32QI_V32QI.
Comments
On Thu, Jun 2, 2022 at 5:04 PM Jan Beulich <jbeulich@suse.com> wrote: > > The 64-bit, 128-bit, and 512-bit variants have V<n>DI return type, in > line with instruction behavior. Make the 256-bit builtin match, thus > also making it match the insn it expands to (using VI8_AVX2_AVX512BW). > > gcc/ > > * config/i386/i386-builtin.def (__builtin_ia32_psadbw256): > Change type. > * config/i386/i386-builtin-types.def: New function type > (V4DI, V32QI, V32QI). > * config/i386/i386-expand.cc (ix86_expand_args_builtin): Handle > V4DI_FTYPE_V32QI_V32QI. LGTM, but please let HJ have the final approval. Uros. > > --- a/gcc/config/i386/i386-builtin.def > +++ b/gcc/config/i386/i386-builtin.def > @@ -1217,7 +1217,7 @@ BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR > BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_mulv8si3, "__builtin_ia32_pmulld256" , IX86_BUILTIN_PMULLD256 , UNKNOWN, (int) V8SI_FTYPE_V8SI_V8SI) > BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_vec_widen_umult_even_v8si, "__builtin_ia32_pmuludq256", IX86_BUILTIN_PMULUDQ256, UNKNOWN, (int) V4DI_FTYPE_V8SI_V8SI) > BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_iorv4di3, "__builtin_ia32_por256", IX86_BUILTIN_POR256, UNKNOWN, (int) V4DI_FTYPE_V4DI_V4DI) > -BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_avx2_psadbw, "__builtin_ia32_psadbw256", IX86_BUILTIN_PSADBW256, UNKNOWN, (int) V16HI_FTYPE_V32QI_V32QI) > +BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_avx2_psadbw, "__builtin_ia32_psadbw256", IX86_BUILTIN_PSADBW256, UNKNOWN, (int) V4DI_FTYPE_V32QI_V32QI) > BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_avx2_pshufbv32qi3, "__builtin_ia32_pshufb256", IX86_BUILTIN_PSHUFB256, UNKNOWN, (int) V32QI_FTYPE_V32QI_V32QI) > BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_avx2_pshufdv3, "__builtin_ia32_pshufd256", IX86_BUILTIN_PSHUFD256, UNKNOWN, (int) V8SI_FTYPE_V8SI_INT) > BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_avx2_pshufhwv3, "__builtin_ia32_pshufhw256", IX86_BUILTIN_PSHUFHW256, UNKNOWN, (int) V16HI_FTYPE_V16HI_INT) > --- a/gcc/config/i386/i386-builtin-types.def > +++ b/gcc/config/i386/i386-builtin-types.def > @@ -516,6 +516,7 @@ DEF_FUNCTION_TYPE (V8DI, V8DI, V2DI, INT > DEF_FUNCTION_TYPE (V8DI, V8DI, V2DI, INT, V8DI, UQI) > DEF_FUNCTION_TYPE (V8DI, V8DI, V4DI, INT, V8DI, UQI) > DEF_FUNCTION_TYPE (V4DI, V8SI, V8SI) > +DEF_FUNCTION_TYPE (V4DI, V32QI, V32QI) > DEF_FUNCTION_TYPE (V8DI, V64QI, V64QI) > DEF_FUNCTION_TYPE (V4DI, V4DI, V2DI) > DEF_FUNCTION_TYPE (V4DI, PCV4DI, V4DI) > --- a/gcc/config/i386/i386-expand.cc > +++ b/gcc/config/i386/i386-expand.cc > @@ -10359,6 +10359,7 @@ ix86_expand_args_builtin (const struct b > case V8SI_FTYPE_V16HI_V16HI: > case V4DI_FTYPE_V4DI_V4DI: > case V4DI_FTYPE_V8SI_V8SI: > + case V4DI_FTYPE_V32QI_V32QI: > case V8DI_FTYPE_V64QI_V64QI: > if (comparison == UNKNOWN) > return ix86_expand_binop_builtin (icode, exp, target); >
On Mon, Jun 6, 2022 at 3:17 AM Uros Bizjak via Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > > On Thu, Jun 2, 2022 at 5:04 PM Jan Beulich <jbeulich@suse.com> wrote: > > > > The 64-bit, 128-bit, and 512-bit variants have V<n>DI return type, in > > line with instruction behavior. Make the 256-bit builtin match, thus > > also making it match the insn it expands to (using VI8_AVX2_AVX512BW). > > > > gcc/ > > > > * config/i386/i386-builtin.def (__builtin_ia32_psadbw256): > > Change type. > > * config/i386/i386-builtin-types.def: New function type > > (V4DI, V32QI, V32QI). > > * config/i386/i386-expand.cc (ix86_expand_args_builtin): Handle > > V4DI_FTYPE_V32QI_V32QI. > > LGTM, but please let HJ have the final approval. I think it was just a typo and not intentional, so Ok for the trunk. > > Uros. > > > > > --- a/gcc/config/i386/i386-builtin.def > > +++ b/gcc/config/i386/i386-builtin.def > > @@ -1217,7 +1217,7 @@ BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR > > BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_mulv8si3, "__builtin_ia32_pmulld256" , IX86_BUILTIN_PMULLD256 , UNKNOWN, (int) V8SI_FTYPE_V8SI_V8SI) > > BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_vec_widen_umult_even_v8si, "__builtin_ia32_pmuludq256", IX86_BUILTIN_PMULUDQ256, UNKNOWN, (int) V4DI_FTYPE_V8SI_V8SI) > > BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_iorv4di3, "__builtin_ia32_por256", IX86_BUILTIN_POR256, UNKNOWN, (int) V4DI_FTYPE_V4DI_V4DI) > > -BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_avx2_psadbw, "__builtin_ia32_psadbw256", IX86_BUILTIN_PSADBW256, UNKNOWN, (int) V16HI_FTYPE_V32QI_V32QI) > > +BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_avx2_psadbw, "__builtin_ia32_psadbw256", IX86_BUILTIN_PSADBW256, UNKNOWN, (int) V4DI_FTYPE_V32QI_V32QI) > > BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_avx2_pshufbv32qi3, "__builtin_ia32_pshufb256", IX86_BUILTIN_PSHUFB256, UNKNOWN, (int) V32QI_FTYPE_V32QI_V32QI) > > BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_avx2_pshufdv3, "__builtin_ia32_pshufd256", IX86_BUILTIN_PSHUFD256, UNKNOWN, (int) V8SI_FTYPE_V8SI_INT) > > BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_avx2_pshufhwv3, "__builtin_ia32_pshufhw256", IX86_BUILTIN_PSHUFHW256, UNKNOWN, (int) V16HI_FTYPE_V16HI_INT) > > --- a/gcc/config/i386/i386-builtin-types.def > > +++ b/gcc/config/i386/i386-builtin-types.def > > @@ -516,6 +516,7 @@ DEF_FUNCTION_TYPE (V8DI, V8DI, V2DI, INT > > DEF_FUNCTION_TYPE (V8DI, V8DI, V2DI, INT, V8DI, UQI) > > DEF_FUNCTION_TYPE (V8DI, V8DI, V4DI, INT, V8DI, UQI) > > DEF_FUNCTION_TYPE (V4DI, V8SI, V8SI) > > +DEF_FUNCTION_TYPE (V4DI, V32QI, V32QI) > > DEF_FUNCTION_TYPE (V8DI, V64QI, V64QI) > > DEF_FUNCTION_TYPE (V4DI, V4DI, V2DI) > > DEF_FUNCTION_TYPE (V4DI, PCV4DI, V4DI) > > --- a/gcc/config/i386/i386-expand.cc > > +++ b/gcc/config/i386/i386-expand.cc > > @@ -10359,6 +10359,7 @@ ix86_expand_args_builtin (const struct b > > case V8SI_FTYPE_V16HI_V16HI: > > case V4DI_FTYPE_V4DI_V4DI: > > case V4DI_FTYPE_V8SI_V8SI: > > + case V4DI_FTYPE_V32QI_V32QI: > > case V8DI_FTYPE_V64QI_V64QI: > > if (comparison == UNKNOWN) > > return ix86_expand_binop_builtin (icode, exp, target); > >
On Sun, Jun 5, 2022 at 7:27 PM Hongtao Liu via Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > > On Mon, Jun 6, 2022 at 3:17 AM Uros Bizjak via Gcc-patches > <gcc-patches@gcc.gnu.org> wrote: > > > > On Thu, Jun 2, 2022 at 5:04 PM Jan Beulich <jbeulich@suse.com> wrote: > > > > > > The 64-bit, 128-bit, and 512-bit variants have V<n>DI return type, in > > > line with instruction behavior. Make the 256-bit builtin match, thus > > > also making it match the insn it expands to (using VI8_AVX2_AVX512BW). > > > > > > gcc/ > > > > > > * config/i386/i386-builtin.def (__builtin_ia32_psadbw256): > > > Change type. > > > * config/i386/i386-builtin-types.def: New function type > > > (V4DI, V32QI, V32QI). > > > * config/i386/i386-expand.cc (ix86_expand_args_builtin): Handle > > > V4DI_FTYPE_V32QI_V32QI. > > > > LGTM, but please let HJ have the final approval. > I think it was just a typo and not intentional, so Ok for the trunk. LGTM too. Thanks. > > > > Uros. > > > > > > > > --- a/gcc/config/i386/i386-builtin.def > > > +++ b/gcc/config/i386/i386-builtin.def > > > @@ -1217,7 +1217,7 @@ BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR > > > BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_mulv8si3, "__builtin_ia32_pmulld256" , IX86_BUILTIN_PMULLD256 , UNKNOWN, (int) V8SI_FTYPE_V8SI_V8SI) > > > BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_vec_widen_umult_even_v8si, "__builtin_ia32_pmuludq256", IX86_BUILTIN_PMULUDQ256, UNKNOWN, (int) V4DI_FTYPE_V8SI_V8SI) > > > BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_iorv4di3, "__builtin_ia32_por256", IX86_BUILTIN_POR256, UNKNOWN, (int) V4DI_FTYPE_V4DI_V4DI) > > > -BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_avx2_psadbw, "__builtin_ia32_psadbw256", IX86_BUILTIN_PSADBW256, UNKNOWN, (int) V16HI_FTYPE_V32QI_V32QI) > > > +BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_avx2_psadbw, "__builtin_ia32_psadbw256", IX86_BUILTIN_PSADBW256, UNKNOWN, (int) V4DI_FTYPE_V32QI_V32QI) > > > BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_avx2_pshufbv32qi3, "__builtin_ia32_pshufb256", IX86_BUILTIN_PSHUFB256, UNKNOWN, (int) V32QI_FTYPE_V32QI_V32QI) > > > BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_avx2_pshufdv3, "__builtin_ia32_pshufd256", IX86_BUILTIN_PSHUFD256, UNKNOWN, (int) V8SI_FTYPE_V8SI_INT) > > > BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_avx2_pshufhwv3, "__builtin_ia32_pshufhw256", IX86_BUILTIN_PSHUFHW256, UNKNOWN, (int) V16HI_FTYPE_V16HI_INT) > > > --- a/gcc/config/i386/i386-builtin-types.def > > > +++ b/gcc/config/i386/i386-builtin-types.def > > > @@ -516,6 +516,7 @@ DEF_FUNCTION_TYPE (V8DI, V8DI, V2DI, INT > > > DEF_FUNCTION_TYPE (V8DI, V8DI, V2DI, INT, V8DI, UQI) > > > DEF_FUNCTION_TYPE (V8DI, V8DI, V4DI, INT, V8DI, UQI) > > > DEF_FUNCTION_TYPE (V4DI, V8SI, V8SI) > > > +DEF_FUNCTION_TYPE (V4DI, V32QI, V32QI) > > > DEF_FUNCTION_TYPE (V8DI, V64QI, V64QI) > > > DEF_FUNCTION_TYPE (V4DI, V4DI, V2DI) > > > DEF_FUNCTION_TYPE (V4DI, PCV4DI, V4DI) > > > --- a/gcc/config/i386/i386-expand.cc > > > +++ b/gcc/config/i386/i386-expand.cc > > > @@ -10359,6 +10359,7 @@ ix86_expand_args_builtin (const struct b > > > case V8SI_FTYPE_V16HI_V16HI: > > > case V4DI_FTYPE_V4DI_V4DI: > > > case V4DI_FTYPE_V8SI_V8SI: > > > + case V4DI_FTYPE_V32QI_V32QI: > > > case V8DI_FTYPE_V64QI_V64QI: > > > if (comparison == UNKNOWN) > > > return ix86_expand_binop_builtin (icode, exp, target); > > > > > > > -- > BR, > Hongtao
--- a/gcc/config/i386/i386-builtin.def +++ b/gcc/config/i386/i386-builtin.def @@ -1217,7 +1217,7 @@ BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_mulv8si3, "__builtin_ia32_pmulld256" , IX86_BUILTIN_PMULLD256 , UNKNOWN, (int) V8SI_FTYPE_V8SI_V8SI) BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_vec_widen_umult_even_v8si, "__builtin_ia32_pmuludq256", IX86_BUILTIN_PMULUDQ256, UNKNOWN, (int) V4DI_FTYPE_V8SI_V8SI) BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_iorv4di3, "__builtin_ia32_por256", IX86_BUILTIN_POR256, UNKNOWN, (int) V4DI_FTYPE_V4DI_V4DI) -BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_avx2_psadbw, "__builtin_ia32_psadbw256", IX86_BUILTIN_PSADBW256, UNKNOWN, (int) V16HI_FTYPE_V32QI_V32QI) +BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_avx2_psadbw, "__builtin_ia32_psadbw256", IX86_BUILTIN_PSADBW256, UNKNOWN, (int) V4DI_FTYPE_V32QI_V32QI) BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_avx2_pshufbv32qi3, "__builtin_ia32_pshufb256", IX86_BUILTIN_PSHUFB256, UNKNOWN, (int) V32QI_FTYPE_V32QI_V32QI) BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_avx2_pshufdv3, "__builtin_ia32_pshufd256", IX86_BUILTIN_PSHUFD256, UNKNOWN, (int) V8SI_FTYPE_V8SI_INT) BDESC (OPTION_MASK_ISA_AVX2, 0, CODE_FOR_avx2_pshufhwv3, "__builtin_ia32_pshufhw256", IX86_BUILTIN_PSHUFHW256, UNKNOWN, (int) V16HI_FTYPE_V16HI_INT) --- a/gcc/config/i386/i386-builtin-types.def +++ b/gcc/config/i386/i386-builtin-types.def @@ -516,6 +516,7 @@ DEF_FUNCTION_TYPE (V8DI, V8DI, V2DI, INT DEF_FUNCTION_TYPE (V8DI, V8DI, V2DI, INT, V8DI, UQI) DEF_FUNCTION_TYPE (V8DI, V8DI, V4DI, INT, V8DI, UQI) DEF_FUNCTION_TYPE (V4DI, V8SI, V8SI) +DEF_FUNCTION_TYPE (V4DI, V32QI, V32QI) DEF_FUNCTION_TYPE (V8DI, V64QI, V64QI) DEF_FUNCTION_TYPE (V4DI, V4DI, V2DI) DEF_FUNCTION_TYPE (V4DI, PCV4DI, V4DI) --- a/gcc/config/i386/i386-expand.cc +++ b/gcc/config/i386/i386-expand.cc @@ -10359,6 +10359,7 @@ ix86_expand_args_builtin (const struct b case V8SI_FTYPE_V16HI_V16HI: case V4DI_FTYPE_V4DI_V4DI: case V4DI_FTYPE_V8SI_V8SI: + case V4DI_FTYPE_V32QI_V32QI: case V8DI_FTYPE_V64QI_V64QI: if (comparison == UNKNOWN) return ix86_expand_binop_builtin (icode, exp, target);