x86: Add missing .note.GNU-stack to assembly source
Commit Message
Add .note.GNU-stack assembly source to avoid linker warning:
ld: warning: /tmp/ccPZSZ7Z.o: missing .note.GNU-stack section implies executable stack
ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
FAIL: gcc.target/i386/iamcu/test_3_element_struct_and_unions.c compilation, -O0
PR testsuite/105433
* gcc.target/i386/iamcu/asm-support.S: Add .note.GNU-stack.
* gcc.target/x86_64/abi/asm-support.S: Likewise.
* gcc.target/x86_64/abi/avx/asm-support.S: Likewise.
* gcc.target/x86_64/abi/avx512f/asm-support.S: Likewise.
* gcc.target/x86_64/abi/avx512fp16/asm-support.S: Likewise.
* gcc.target/x86_64/abi/avx512fp16/m256h/asm-support.S: Likewise.
* gcc.target/x86_64/abi/avx512fp16/m512h/asm-support.S: Likewise.
* gcc.target/x86_64/abi/ms-sysv/do-test.S: Likewise.
---
gcc/testsuite/gcc.target/i386/iamcu/asm-support.S | 1 +
gcc/testsuite/gcc.target/x86_64/abi/asm-support.S | 1 +
gcc/testsuite/gcc.target/x86_64/abi/avx/asm-support.S | 1 +
gcc/testsuite/gcc.target/x86_64/abi/avx512f/asm-support.S | 1 +
gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/asm-support.S | 1 +
.../gcc.target/x86_64/abi/avx512fp16/m256h/asm-support.S | 1 +
.../gcc.target/x86_64/abi/avx512fp16/m512h/asm-support.S | 1 +
gcc/testsuite/gcc.target/x86_64/abi/ms-sysv/do-test.S | 1 +
8 files changed, 8 insertions(+)
Comments
On Fri, Apr 29, 2022 at 10:38 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> Add .note.GNU-stack assembly source to avoid linker warning:
>
> ld: warning: /tmp/ccPZSZ7Z.o: missing .note.GNU-stack section implies executable stack
> ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
> FAIL: gcc.target/i386/iamcu/test_3_element_struct_and_unions.c compilation, -O0
>
> PR testsuite/105433
> * gcc.target/i386/iamcu/asm-support.S: Add .note.GNU-stack.
> * gcc.target/x86_64/abi/asm-support.S: Likewise.
> * gcc.target/x86_64/abi/avx/asm-support.S: Likewise.
> * gcc.target/x86_64/abi/avx512f/asm-support.S: Likewise.
> * gcc.target/x86_64/abi/avx512fp16/asm-support.S: Likewise.
> * gcc.target/x86_64/abi/avx512fp16/m256h/asm-support.S: Likewise.
> * gcc.target/x86_64/abi/avx512fp16/m512h/asm-support.S: Likewise.
> * gcc.target/x86_64/abi/ms-sysv/do-test.S: Likewise.
> ---
> gcc/testsuite/gcc.target/i386/iamcu/asm-support.S | 1 +
> gcc/testsuite/gcc.target/x86_64/abi/asm-support.S | 1 +
> gcc/testsuite/gcc.target/x86_64/abi/avx/asm-support.S | 1 +
> gcc/testsuite/gcc.target/x86_64/abi/avx512f/asm-support.S | 1 +
> gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/asm-support.S | 1 +
> .../gcc.target/x86_64/abi/avx512fp16/m256h/asm-support.S | 1 +
> .../gcc.target/x86_64/abi/avx512fp16/m512h/asm-support.S | 1 +
> gcc/testsuite/gcc.target/x86_64/abi/ms-sysv/do-test.S | 1 +
> 8 files changed, 8 insertions(+)
>
> diff --git a/gcc/testsuite/gcc.target/i386/iamcu/asm-support.S b/gcc/testsuite/gcc.target/i386/iamcu/asm-support.S
> index b4a4a140e54..db08f52a34f 100644
> --- a/gcc/testsuite/gcc.target/i386/iamcu/asm-support.S
> +++ b/gcc/testsuite/gcc.target/i386/iamcu/asm-support.S
> @@ -300,3 +300,4 @@ iamcu_noprintf:
> .align 4
> .LCiamcu_noprintf1:
> .long 1132527616
> + .section .note.GNU-stack,"",@progbits
> diff --git a/gcc/testsuite/gcc.target/x86_64/abi/asm-support.S b/gcc/testsuite/gcc.target/x86_64/abi/asm-support.S
> index 7a8ed03d119..2f8d3a09c6b 100644
> --- a/gcc/testsuite/gcc.target/x86_64/abi/asm-support.S
> +++ b/gcc/testsuite/gcc.target/x86_64/abi/asm-support.S
> @@ -82,3 +82,4 @@ snapshot_ret:
> .comm xmm_regs,256,32
> .comm x87_regs,128,32
> .comm volatile_var,8,8
> + .section .note.GNU-stack,"",@progbits
> diff --git a/gcc/testsuite/gcc.target/x86_64/abi/avx/asm-support.S b/gcc/testsuite/gcc.target/x86_64/abi/avx/asm-support.S
> index 73a59191d6d..77b3480ac32 100644
> --- a/gcc/testsuite/gcc.target/x86_64/abi/avx/asm-support.S
> +++ b/gcc/testsuite/gcc.target/x86_64/abi/avx/asm-support.S
> @@ -79,3 +79,4 @@ snapshot_ret:
> .comm ymm_regs,512,32
> .comm x87_regs,128,32
> .comm volatile_var,8,8
> + .section .note.GNU-stack,"",@progbits
> diff --git a/gcc/testsuite/gcc.target/x86_64/abi/avx512f/asm-support.S b/gcc/testsuite/gcc.target/x86_64/abi/avx512f/asm-support.S
> index 0ef82876dd9..2e3306c44cb 100644
> --- a/gcc/testsuite/gcc.target/x86_64/abi/avx512f/asm-support.S
> +++ b/gcc/testsuite/gcc.target/x86_64/abi/avx512f/asm-support.S
> @@ -95,3 +95,4 @@ snapshot_ret:
> .comm zmm_regs,2048,64
> .comm x87_regs,128,32
> .comm volatile_var,8,8
> + .section .note.GNU-stack,"",@progbits
> diff --git a/gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/asm-support.S b/gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/asm-support.S
> index 7849acd2649..0793acf048b 100644
> --- a/gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/asm-support.S
> +++ b/gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/asm-support.S
> @@ -79,3 +79,4 @@ snapshot_ret:
> .comm xmm_regs,256,32
> .comm x87_regs,128,32
> .comm volatile_var,8,8
> + .section .note.GNU-stack,"",@progbits
> diff --git a/gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/m256h/asm-support.S b/gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/m256h/asm-support.S
> index 73a59191d6d..77b3480ac32 100644
> --- a/gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/m256h/asm-support.S
> +++ b/gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/m256h/asm-support.S
> @@ -79,3 +79,4 @@ snapshot_ret:
> .comm ymm_regs,512,32
> .comm x87_regs,128,32
> .comm volatile_var,8,8
> + .section .note.GNU-stack,"",@progbits
> diff --git a/gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/m512h/asm-support.S b/gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/m512h/asm-support.S
> index 0ef82876dd9..2e3306c44cb 100644
> --- a/gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/m512h/asm-support.S
> +++ b/gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/m512h/asm-support.S
> @@ -95,3 +95,4 @@ snapshot_ret:
> .comm zmm_regs,2048,64
> .comm x87_regs,128,32
> .comm volatile_var,8,8
> + .section .note.GNU-stack,"",@progbits
> diff --git a/gcc/testsuite/gcc.target/x86_64/abi/ms-sysv/do-test.S b/gcc/testsuite/gcc.target/x86_64/abi/ms-sysv/do-test.S
> index 7b891a140dc..f5dff4c10ab 100644
> --- a/gcc/testsuite/gcc.target/x86_64/abi/ms-sysv/do-test.S
> +++ b/gcc/testsuite/gcc.target/x86_64/abi/ms-sysv/do-test.S
> @@ -30,6 +30,7 @@ see the files COPYING3 and COPYING.RUNTIME respectively. If not, see
> #ifdef __ELF__
> # define FN_TYPE(fn) .type fn,@function
> # define FN_SIZE(fn) .size fn,.-fn
> + .section .note.GNU-stack,"",@progbits
> #else
> # define FN_TYPE(fn)
> # define FN_SIZE(fn)
> --
> 2.35.1
>
I am checking it in.
On Mon, May 2, 2022 at 11:37 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Fri, Apr 29, 2022 at 10:38 AM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > Add .note.GNU-stack assembly source to avoid linker warning:
> >
> > ld: warning: /tmp/ccPZSZ7Z.o: missing .note.GNU-stack section implies executable stack
> > ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
> > FAIL: gcc.target/i386/iamcu/test_3_element_struct_and_unions.c compilation, -O0
> >
> > PR testsuite/105433
> > * gcc.target/i386/iamcu/asm-support.S: Add .note.GNU-stack.
> > * gcc.target/x86_64/abi/asm-support.S: Likewise.
> > * gcc.target/x86_64/abi/avx/asm-support.S: Likewise.
> > * gcc.target/x86_64/abi/avx512f/asm-support.S: Likewise.
> > * gcc.target/x86_64/abi/avx512fp16/asm-support.S: Likewise.
> > * gcc.target/x86_64/abi/avx512fp16/m256h/asm-support.S: Likewise.
> > * gcc.target/x86_64/abi/avx512fp16/m512h/asm-support.S: Likewise.
> > * gcc.target/x86_64/abi/ms-sysv/do-test.S: Likewise.
> > ---
> > gcc/testsuite/gcc.target/i386/iamcu/asm-support.S | 1 +
> > gcc/testsuite/gcc.target/x86_64/abi/asm-support.S | 1 +
> > gcc/testsuite/gcc.target/x86_64/abi/avx/asm-support.S | 1 +
> > gcc/testsuite/gcc.target/x86_64/abi/avx512f/asm-support.S | 1 +
> > gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/asm-support.S | 1 +
> > .../gcc.target/x86_64/abi/avx512fp16/m256h/asm-support.S | 1 +
> > .../gcc.target/x86_64/abi/avx512fp16/m512h/asm-support.S | 1 +
> > gcc/testsuite/gcc.target/x86_64/abi/ms-sysv/do-test.S | 1 +
> > 8 files changed, 8 insertions(+)
> >
> > diff --git a/gcc/testsuite/gcc.target/i386/iamcu/asm-support.S b/gcc/testsuite/gcc.target/i386/iamcu/asm-support.S
> > index b4a4a140e54..db08f52a34f 100644
> > --- a/gcc/testsuite/gcc.target/i386/iamcu/asm-support.S
> > +++ b/gcc/testsuite/gcc.target/i386/iamcu/asm-support.S
> > @@ -300,3 +300,4 @@ iamcu_noprintf:
> > .align 4
> > .LCiamcu_noprintf1:
> > .long 1132527616
> > + .section .note.GNU-stack,"",@progbits
> > diff --git a/gcc/testsuite/gcc.target/x86_64/abi/asm-support.S b/gcc/testsuite/gcc.target/x86_64/abi/asm-support.S
> > index 7a8ed03d119..2f8d3a09c6b 100644
> > --- a/gcc/testsuite/gcc.target/x86_64/abi/asm-support.S
> > +++ b/gcc/testsuite/gcc.target/x86_64/abi/asm-support.S
> > @@ -82,3 +82,4 @@ snapshot_ret:
> > .comm xmm_regs,256,32
> > .comm x87_regs,128,32
> > .comm volatile_var,8,8
> > + .section .note.GNU-stack,"",@progbits
> > diff --git a/gcc/testsuite/gcc.target/x86_64/abi/avx/asm-support.S b/gcc/testsuite/gcc.target/x86_64/abi/avx/asm-support.S
> > index 73a59191d6d..77b3480ac32 100644
> > --- a/gcc/testsuite/gcc.target/x86_64/abi/avx/asm-support.S
> > +++ b/gcc/testsuite/gcc.target/x86_64/abi/avx/asm-support.S
> > @@ -79,3 +79,4 @@ snapshot_ret:
> > .comm ymm_regs,512,32
> > .comm x87_regs,128,32
> > .comm volatile_var,8,8
> > + .section .note.GNU-stack,"",@progbits
> > diff --git a/gcc/testsuite/gcc.target/x86_64/abi/avx512f/asm-support.S b/gcc/testsuite/gcc.target/x86_64/abi/avx512f/asm-support.S
> > index 0ef82876dd9..2e3306c44cb 100644
> > --- a/gcc/testsuite/gcc.target/x86_64/abi/avx512f/asm-support.S
> > +++ b/gcc/testsuite/gcc.target/x86_64/abi/avx512f/asm-support.S
> > @@ -95,3 +95,4 @@ snapshot_ret:
> > .comm zmm_regs,2048,64
> > .comm x87_regs,128,32
> > .comm volatile_var,8,8
> > + .section .note.GNU-stack,"",@progbits
> > diff --git a/gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/asm-support.S b/gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/asm-support.S
> > index 7849acd2649..0793acf048b 100644
> > --- a/gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/asm-support.S
> > +++ b/gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/asm-support.S
> > @@ -79,3 +79,4 @@ snapshot_ret:
> > .comm xmm_regs,256,32
> > .comm x87_regs,128,32
> > .comm volatile_var,8,8
> > + .section .note.GNU-stack,"",@progbits
> > diff --git a/gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/m256h/asm-support.S b/gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/m256h/asm-support.S
> > index 73a59191d6d..77b3480ac32 100644
> > --- a/gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/m256h/asm-support.S
> > +++ b/gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/m256h/asm-support.S
> > @@ -79,3 +79,4 @@ snapshot_ret:
> > .comm ymm_regs,512,32
> > .comm x87_regs,128,32
> > .comm volatile_var,8,8
> > + .section .note.GNU-stack,"",@progbits
> > diff --git a/gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/m512h/asm-support.S b/gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/m512h/asm-support.S
> > index 0ef82876dd9..2e3306c44cb 100644
> > --- a/gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/m512h/asm-support.S
> > +++ b/gcc/testsuite/gcc.target/x86_64/abi/avx512fp16/m512h/asm-support.S
> > @@ -95,3 +95,4 @@ snapshot_ret:
> > .comm zmm_regs,2048,64
> > .comm x87_regs,128,32
> > .comm volatile_var,8,8
> > + .section .note.GNU-stack,"",@progbits
> > diff --git a/gcc/testsuite/gcc.target/x86_64/abi/ms-sysv/do-test.S b/gcc/testsuite/gcc.target/x86_64/abi/ms-sysv/do-test.S
> > index 7b891a140dc..f5dff4c10ab 100644
> > --- a/gcc/testsuite/gcc.target/x86_64/abi/ms-sysv/do-test.S
> > +++ b/gcc/testsuite/gcc.target/x86_64/abi/ms-sysv/do-test.S
> > @@ -30,6 +30,7 @@ see the files COPYING3 and COPYING.RUNTIME respectively. If not, see
> > #ifdef __ELF__
> > # define FN_TYPE(fn) .type fn,@function
> > # define FN_SIZE(fn) .size fn,.-fn
> > + .section .note.GNU-stack,"",@progbits
> > #else
> > # define FN_TYPE(fn)
> > # define FN_SIZE(fn)
> > --
> > 2.35.1
> >
>
> I am checking it in.
>
>
> --
> H.J.
I am backporting this to release branches.
Hi H.J,
> On Mon, May 2, 2022 at 11:37 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>>
>> On Fri, Apr 29, 2022 at 10:38 AM H.J. Lu <hjl.tools@gmail.com> wrote:
>> >
>> > Add .note.GNU-stack assembly source to avoid linker warning:
>> >
>> > ld: warning: /tmp/ccPZSZ7Z.o: missing .note.GNU-stack section implies executable stack
>> > ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
>> > FAIL: gcc.target/i386/iamcu/test_3_element_struct_and_unions.c compilation, -O0
>> >
>> > PR testsuite/105433
>> > * gcc.target/i386/iamcu/asm-support.S: Add .note.GNU-stack.
>> > * gcc.target/x86_64/abi/asm-support.S: Likewise.
>> > * gcc.target/x86_64/abi/avx/asm-support.S: Likewise.
>> > * gcc.target/x86_64/abi/avx512f/asm-support.S: Likewise.
>> > * gcc.target/x86_64/abi/avx512fp16/asm-support.S: Likewise.
>> > * gcc.target/x86_64/abi/avx512fp16/m256h/asm-support.S: Likewise.
>> > * gcc.target/x86_64/abi/avx512fp16/m512h/asm-support.S: Likewise.
>> > * gcc.target/x86_64/abi/ms-sysv/do-test.S: Likewise.
[...]
> I am backporting this to release branches.
Wait: please fix PR target/105472 first rather than causing massive
breakage on release branches, too.
Rainer
@@ -300,3 +300,4 @@ iamcu_noprintf:
.align 4
.LCiamcu_noprintf1:
.long 1132527616
+ .section .note.GNU-stack,"",@progbits
@@ -82,3 +82,4 @@ snapshot_ret:
.comm xmm_regs,256,32
.comm x87_regs,128,32
.comm volatile_var,8,8
+ .section .note.GNU-stack,"",@progbits
@@ -79,3 +79,4 @@ snapshot_ret:
.comm ymm_regs,512,32
.comm x87_regs,128,32
.comm volatile_var,8,8
+ .section .note.GNU-stack,"",@progbits
@@ -95,3 +95,4 @@ snapshot_ret:
.comm zmm_regs,2048,64
.comm x87_regs,128,32
.comm volatile_var,8,8
+ .section .note.GNU-stack,"",@progbits
@@ -79,3 +79,4 @@ snapshot_ret:
.comm xmm_regs,256,32
.comm x87_regs,128,32
.comm volatile_var,8,8
+ .section .note.GNU-stack,"",@progbits
@@ -79,3 +79,4 @@ snapshot_ret:
.comm ymm_regs,512,32
.comm x87_regs,128,32
.comm volatile_var,8,8
+ .section .note.GNU-stack,"",@progbits
@@ -95,3 +95,4 @@ snapshot_ret:
.comm zmm_regs,2048,64
.comm x87_regs,128,32
.comm volatile_var,8,8
+ .section .note.GNU-stack,"",@progbits
@@ -30,6 +30,7 @@ see the files COPYING3 and COPYING.RUNTIME respectively. If not, see
#ifdef __ELF__
# define FN_TYPE(fn) .type fn,@function
# define FN_SIZE(fn) .size fn,.-fn
+ .section .note.GNU-stack,"",@progbits
#else
# define FN_TYPE(fn)
# define FN_SIZE(fn)