| Message ID | YlmcDyv8Zt+Bz1dS@troutmask.apl.washington.edu |
|---|---|
| State | New |
| Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 23212385737C for <patchwork@sourceware.org>; Fri, 15 Apr 2022 16:24:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 23212385737C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1650039857; bh=C9niCU5nx7Pz2pNrqaMflAkTMGkv4gGtthFkg2i1fYk=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=JVdetUwClNIMq6S96WecQjvM20xNwy49Ki65jd8mQiq6oBfhrtjatlSHBTmGCYOLE uuU/f7yQfM3rBVPqK50SEycUlLGRrXkBFHEZoK1BdEspsUIh/o6TgztDHuYlwvla7P dS8jrYi/0+Bp72rI5jVT9zW6u3Nfwfj8/AgPBgLc= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) by sourceware.org (Postfix) with ESMTPS id 1EEA4385801E; Fri, 15 Apr 2022 16:23:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1EEA4385801E Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.16.1/8.16.1) with ESMTPS id 23FGNhLF094932 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 15 Apr 2022 09:23:43 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.16.1/8.16.1/Submit) id 23FGNhll094931; Fri, 15 Apr 2022 09:23:43 -0700 (PDT) (envelope-from sgk) Date: Fri, 15 Apr 2022 09:23:43 -0700 To: gcc-patches@gcc.gnu.org Subject: [PATCH] PR target/89125 Message-ID: <YlmcDyv8Zt+Bz1dS@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="IQvrcB6WnYzP+DvR" Content-Disposition: inline X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_NUMSUBJECT, KAM_SHORT, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: Steve Kargl via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: sgk@troutmask.apl.washington.edu Cc: kargl@gcc.gnu.org Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> |
| Series |
PR target/89125
|
|
Commit Message
Li, Pan2 via Gcc-patches
April 15, 2022, 4:23 p.m. UTC
Can someone, anyone, please commit the attach patch, which is
also attached to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89125
where one can read the audit trail. The original patch was
submitted 2 years ago, and required manual intervention due to
the recent *.c to *.cc rename.
Back story: When GCC is configured and built on non-glibc platforms,
it seems very little to no effort is made to enumerate the available
C99 libm functions. It is all or nothing for C99 libm. The patch
introduces a new function, used on only FreeBSD, to inform gcc that
it has C99 libm functions (minus a few which clearly GCC does not check
nor test).
The patch introduces no regression on x86_64-*-freebsd while
allowing an additional 31 new passes.
=== gcc Summary ===
w/o patch w patch
# of expected passes 175405 175434
# of unexpected failures 1081 1051
# of unexpected successes 20 20
# of expected failures 1459 1459
# of unresolved testcases 10 10
# of unsupported tests 3252 3252
=== g++ Summary ===
w/o patch w patch
# of expected passes 225338 225341
# of unexpected failures 678 676
# of expected failures 2071 2071
# of unresolved testcases 11 11
# of unsupported tests 10353 10353
=== gfortran Summary ===
w/o patch w patch
# of expected passes 65901 65901
# of unexpected failures 12 12
# of expected failures 272 272
# of unsupported tests 100 100
2022-04-15 Steven G. Kargl <kargl@gcc.gnu.org>
PR target/89125
* config/freebsd.h: Define TARGET_LIBC_HAS_FUNCTION to be
bsd_libc_has_function.
* gcc/targhooks.cc(bsd_libc_has_function): New function.
Expand the supported math functions to inclue C99 libm.
* gcc/targhooks.h: Prototype for bsd_libc_has_function.
Comments
ping. On Fri, Apr 15, 2022 at 09:23:43AM -0700, Steve Kargl wrote: > Can someone, anyone, please commit the attach patch, which is > also attached to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89125 > where one can read the audit trail. The original patch was > submitted 2 years ago, and required manual intervention due to > the recent *.c to *.cc rename. > > Back story: When GCC is configured and built on non-glibc platforms, > it seems very little to no effort is made to enumerate the available > C99 libm functions. It is all or nothing for C99 libm. The patch > introduces a new function, used on only FreeBSD, to inform gcc that > it has C99 libm functions (minus a few which clearly GCC does not check > nor test). > > The patch introduces no regression on x86_64-*-freebsd while > allowing an additional 31 new passes. > > === gcc Summary === > w/o patch w patch > # of expected passes 175405 175434 > # of unexpected failures 1081 1051 > # of unexpected successes 20 20 > # of expected failures 1459 1459 > # of unresolved testcases 10 10 > # of unsupported tests 3252 3252 > > === g++ Summary === > w/o patch w patch > # of expected passes 225338 225341 > # of unexpected failures 678 676 > # of expected failures 2071 2071 > # of unresolved testcases 11 11 > # of unsupported tests 10353 10353 > > === gfortran Summary === > w/o patch w patch > # of expected passes 65901 65901 > # of unexpected failures 12 12 > # of expected failures 272 272 > # of unsupported tests 100 100 > > > 2022-04-15 Steven G. Kargl <kargl@gcc.gnu.org> > > PR target/89125 > * config/freebsd.h: Define TARGET_LIBC_HAS_FUNCTION to be > bsd_libc_has_function. > * gcc/targhooks.cc(bsd_libc_has_function): New function. > Expand the supported math functions to inclue C99 libm. > * gcc/targhooks.h: Prototype for bsd_libc_has_function. > > -- > Steve > diff --git a/gcc/config/freebsd.h b/gcc/config/freebsd.h > index 28ebcad88d4..d89ee7dfc97 100644 > --- a/gcc/config/freebsd.h > +++ b/gcc/config/freebsd.h > @@ -55,7 +55,7 @@ along with GCC; see the file COPYING3. If not see > #endif > > #undef TARGET_LIBC_HAS_FUNCTION > -#define TARGET_LIBC_HAS_FUNCTION no_c99_libc_has_function > +#define TARGET_LIBC_HAS_FUNCTION bsd_libc_has_function > > /* Use --as-needed -lgcc_s for eh support. */ > #ifdef HAVE_LD_AS_NEEDED > diff --git a/gcc/targhooks.cc b/gcc/targhooks.cc > index e22bc66a6c8..ff127763cf2 100644 > --- a/gcc/targhooks.cc > +++ b/gcc/targhooks.cc > @@ -1843,6 +1843,20 @@ no_c99_libc_has_function (enum function_class fn_class ATTRIBUTE_UNUSED, > return false; > } > > +/* Assume some c99 functions are present at the runtime including sincos. */ > +bool > +bsd_libc_has_function (enum function_class fn_class, > + tree type ATTRIBUTE_UNUSED) > +{ > + if (fn_class == function_c94 > + || fn_class == function_c99_misc > + || fn_class == function_sincos) > + return true; > + > + return false; > +} > + > + > tree > default_builtin_tm_load_store (tree ARG_UNUSED (type)) > { > diff --git a/gcc/targhooks.h b/gcc/targhooks.h > index ecfa11287ef..ecce55ebe79 100644 > --- a/gcc/targhooks.h > +++ b/gcc/targhooks.h > @@ -212,6 +212,7 @@ extern bool default_libc_has_function (enum function_class, tree); > extern bool default_libc_has_fast_function (int fcode); > extern bool no_c99_libc_has_function (enum function_class, tree); > extern bool gnu_libc_has_function (enum function_class, tree); > +extern bool bsd_libc_has_function (enum function_class, tree); > > extern tree default_builtin_tm_load_store (tree); >
On Sat, Apr 23, 2022 at 8:40 PM Steve Kargl via Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > > ping. I have tested the patch on x86_64-linux and pushed it. Richard. > On Fri, Apr 15, 2022 at 09:23:43AM -0700, Steve Kargl wrote: > > Can someone, anyone, please commit the attach patch, which is > > also attached to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89125 > > where one can read the audit trail. The original patch was > > submitted 2 years ago, and required manual intervention due to > > the recent *.c to *.cc rename. > > > > Back story: When GCC is configured and built on non-glibc platforms, > > it seems very little to no effort is made to enumerate the available > > C99 libm functions. It is all or nothing for C99 libm. The patch > > introduces a new function, used on only FreeBSD, to inform gcc that > > it has C99 libm functions (minus a few which clearly GCC does not check > > nor test). > > > > The patch introduces no regression on x86_64-*-freebsd while > > allowing an additional 31 new passes. > > > > === gcc Summary === > > w/o patch w patch > > # of expected passes 175405 175434 > > # of unexpected failures 1081 1051 > > # of unexpected successes 20 20 > > # of expected failures 1459 1459 > > # of unresolved testcases 10 10 > > # of unsupported tests 3252 3252 > > > > === g++ Summary === > > w/o patch w patch > > # of expected passes 225338 225341 > > # of unexpected failures 678 676 > > # of expected failures 2071 2071 > > # of unresolved testcases 11 11 > > # of unsupported tests 10353 10353 > > > > === gfortran Summary === > > w/o patch w patch > > # of expected passes 65901 65901 > > # of unexpected failures 12 12 > > # of expected failures 272 272 > > # of unsupported tests 100 100 > > > > > > 2022-04-15 Steven G. Kargl <kargl@gcc.gnu.org> > > > > PR target/89125 > > * config/freebsd.h: Define TARGET_LIBC_HAS_FUNCTION to be > > bsd_libc_has_function. > > * gcc/targhooks.cc(bsd_libc_has_function): New function. > > Expand the supported math functions to inclue C99 libm. > > * gcc/targhooks.h: Prototype for bsd_libc_has_function. > > > > -- > > Steve > > > diff --git a/gcc/config/freebsd.h b/gcc/config/freebsd.h > > index 28ebcad88d4..d89ee7dfc97 100644 > > --- a/gcc/config/freebsd.h > > +++ b/gcc/config/freebsd.h > > @@ -55,7 +55,7 @@ along with GCC; see the file COPYING3. If not see > > #endif > > > > #undef TARGET_LIBC_HAS_FUNCTION > > -#define TARGET_LIBC_HAS_FUNCTION no_c99_libc_has_function > > +#define TARGET_LIBC_HAS_FUNCTION bsd_libc_has_function > > > > /* Use --as-needed -lgcc_s for eh support. */ > > #ifdef HAVE_LD_AS_NEEDED > > diff --git a/gcc/targhooks.cc b/gcc/targhooks.cc > > index e22bc66a6c8..ff127763cf2 100644 > > --- a/gcc/targhooks.cc > > +++ b/gcc/targhooks.cc > > @@ -1843,6 +1843,20 @@ no_c99_libc_has_function (enum function_class fn_class ATTRIBUTE_UNUSED, > > return false; > > } > > > > +/* Assume some c99 functions are present at the runtime including sincos. */ > > +bool > > +bsd_libc_has_function (enum function_class fn_class, > > + tree type ATTRIBUTE_UNUSED) > > +{ > > + if (fn_class == function_c94 > > + || fn_class == function_c99_misc > > + || fn_class == function_sincos) > > + return true; > > + > > + return false; > > +} > > + > > + > > tree > > default_builtin_tm_load_store (tree ARG_UNUSED (type)) > > { > > diff --git a/gcc/targhooks.h b/gcc/targhooks.h > > index ecfa11287ef..ecce55ebe79 100644 > > --- a/gcc/targhooks.h > > +++ b/gcc/targhooks.h > > @@ -212,6 +212,7 @@ extern bool default_libc_has_function (enum function_class, tree); > > extern bool default_libc_has_fast_function (int fcode); > > extern bool no_c99_libc_has_function (enum function_class, tree); > > extern bool gnu_libc_has_function (enum function_class, tree); > > +extern bool bsd_libc_has_function (enum function_class, tree); > > > > extern tree default_builtin_tm_load_store (tree); > > > > > -- > Steve
On Mon, Apr 25, 2022 at 09:26:26AM +0200, Richard Biener wrote: > On Sat, Apr 23, 2022 at 8:40 PM Steve Kargl via Gcc-patches > <gcc-patches@gcc.gnu.org> wrote: > > > > ping. > > I have tested the patch on x86_64-linux and pushed it. > Thanks.
diff --git a/gcc/config/freebsd.h b/gcc/config/freebsd.h index 28ebcad88d4..d89ee7dfc97 100644 --- a/gcc/config/freebsd.h +++ b/gcc/config/freebsd.h @@ -55,7 +55,7 @@ along with GCC; see the file COPYING3. If not see #endif #undef TARGET_LIBC_HAS_FUNCTION -#define TARGET_LIBC_HAS_FUNCTION no_c99_libc_has_function +#define TARGET_LIBC_HAS_FUNCTION bsd_libc_has_function /* Use --as-needed -lgcc_s for eh support. */ #ifdef HAVE_LD_AS_NEEDED diff --git a/gcc/targhooks.cc b/gcc/targhooks.cc index e22bc66a6c8..ff127763cf2 100644 --- a/gcc/targhooks.cc +++ b/gcc/targhooks.cc @@ -1843,6 +1843,20 @@ no_c99_libc_has_function (enum function_class fn_class ATTRIBUTE_UNUSED, return false; } +/* Assume some c99 functions are present at the runtime including sincos. */ +bool +bsd_libc_has_function (enum function_class fn_class, + tree type ATTRIBUTE_UNUSED) +{ + if (fn_class == function_c94 + || fn_class == function_c99_misc + || fn_class == function_sincos) + return true; + + return false; +} + + tree default_builtin_tm_load_store (tree ARG_UNUSED (type)) { diff --git a/gcc/targhooks.h b/gcc/targhooks.h index ecfa11287ef..ecce55ebe79 100644 --- a/gcc/targhooks.h +++ b/gcc/targhooks.h @@ -212,6 +212,7 @@ extern bool default_libc_has_function (enum function_class, tree); extern bool default_libc_has_fast_function (int fcode); extern bool no_c99_libc_has_function (enum function_class, tree); extern bool gnu_libc_has_function (enum function_class, tree); +extern bool bsd_libc_has_function (enum function_class, tree); extern tree default_builtin_tm_load_store (tree);