Message ID | 8b943a67-4b1e-9fa1-4422-220d984387ac@suse.cz |
---|---|
State | New |
Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C50EE3857C47 for <patchwork@sourceware.org>; Tue, 28 Dec 2021 13:10:26 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 396C33858C60 for <gcc-patches@gcc.gnu.org>; Tue, 28 Dec 2021 13:10:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 396C33858C60 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E0351210FD; Tue, 28 Dec 2021 13:10:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1640697006; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=e7KqBc7Bsubczx/72GGzxj7nfJvQhz3jHxJCHLYkdGA=; b=FAE8el7ogpJ5Lc05CoSnn6utskMv9sPsszOhvhZpJKd3mMuFmfnB7nMKWu6l5LkikWMIPw +pNsoDzHOAZ7JPLrhtkOQA0OGITpHLxailBV21oiBu1B3k5CFnt6nJHBxTiTMmsqluyK7q EhLzJ+wxoGCGvhrxI19R2Hr9jX3g+60= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1640697006; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=e7KqBc7Bsubczx/72GGzxj7nfJvQhz3jHxJCHLYkdGA=; b=yJhXRZ+KVc+G//AHCnc+toTNTRj2lTWrMU59ifEaDqDYOHZyIVXTk9k7GPtvEezQJEwZm4 0JBR7IFg4EBR+mDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C972E13ADF; Tue, 28 Dec 2021 13:10:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 0AShL64My2GHIQAAMHmgww (envelope-from <mliska@suse.cz>); Tue, 28 Dec 2021 13:10:06 +0000 Message-ID: <8b943a67-4b1e-9fa1-4422-220d984387ac@suse.cz> Date: Tue, 28 Dec 2021 14:10:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 From: =?utf-8?q?Martin_Li=C5=A1ka?= <mliska@suse.cz> Subject: [PATCH] Support ld.mold linker. To: gcc-patches@gcc.gnu.org Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Cc: rui314@gmail.com Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> |
Series |
Support ld.mold linker.
|
|
Commit Message
Martin Liška
Dec. 28, 2021, 1:10 p.m. UTC
Hello. The mold linker is getting quite popular and I think we should support it: https://github.com/rui314/mold Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin --- gcc/collect2.c | 10 +++++++--- gcc/common.opt | 4 ++++ gcc/gcc.c | 4 ++++ gcc/opts.c | 1 + 4 files changed, 16 insertions(+), 3 deletions(-)
Comments
On Tue, Dec 28, 2021 at 5:10 AM Martin Liška <mliska@suse.cz> wrote: > > Hello. > > The mold linker is getting quite popular and I think we should support it: > https://github.com/rui314/mold > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > > --- > gcc/collect2.c | 10 +++++++--- > gcc/common.opt | 4 ++++ > gcc/gcc.c | 4 ++++ > gcc/opts.c | 1 + > 4 files changed, 16 insertions(+), 3 deletions(-) Missing invoke.texi change. > diff --git a/gcc/collect2.c b/gcc/collect2.c > index d47fe3f9195..b322527847c 100644 > --- a/gcc/collect2.c > +++ b/gcc/collect2.c > @@ -776,6 +776,7 @@ main (int argc, char **argv) > USE_GOLD_LD, > USE_BFD_LD, > USE_LLD_LD, > + USE_MOLD_LD, > USE_LD_MAX > } selected_linker = USE_DEFAULT_LD; > static const char *const ld_suffixes[USE_LD_MAX] = > @@ -784,7 +785,8 @@ main (int argc, char **argv) > PLUGIN_LD_SUFFIX, > "ld.gold", > "ld.bfd", > - "ld.lld" > + "ld.lld", > + "ld.mold" > }; > static const char *const real_ld_suffix = "real-ld"; > static const char *const collect_ld_suffix = "collect-ld"; > @@ -957,6 +959,8 @@ main (int argc, char **argv) > selected_linker = USE_GOLD_LD; > else if (strcmp (argv[i], "-fuse-ld=lld") == 0) > selected_linker = USE_LLD_LD; > + else if (strcmp (argv[i], "-fuse-ld=mold") == 0) > + selected_linker = USE_MOLD_LD; > else if (startswith (argv[i], "-o")) > { > /* Parse the output filename if it's given so that we can make > @@ -1048,7 +1052,7 @@ main (int argc, char **argv) > ld_file_name = 0; > #ifdef DEFAULT_LINKER > if (selected_linker == USE_BFD_LD || selected_linker == USE_GOLD_LD || > - selected_linker == USE_LLD_LD) > + selected_linker == USE_LLD_LD || selected_linker == USE_MOLD_LD) > { > char *linker_name; > # ifdef HOST_EXECUTABLE_SUFFIX > @@ -1283,7 +1287,7 @@ main (int argc, char **argv) > else if (!use_collect_ld > && startswith (arg, "-fuse-ld=")) > { > - /* Do not pass -fuse-ld={bfd|gold|lld} to the linker. */ > + /* Do not pass -fuse-ld={bfd|gold|lld|mold} to the linker. */ > ld1--; > ld2--; > } > diff --git a/gcc/common.opt b/gcc/common.opt > index 2ed818d6057..dba3fa886f9 100644 > --- a/gcc/common.opt > +++ b/gcc/common.opt > @@ -3046,6 +3046,10 @@ fuse-ld=lld > Common Driver Negative(fuse-ld=lld) > Use the lld LLVM linker instead of the default linker. > > +fuse-ld=mold > +Common Driver Negative(fuse-ld=mold) > +Use the Modern linker (MOLD) linker instead of the default linker. > + > fuse-linker-plugin > Common Undocumented Var(flag_use_linker_plugin) > > diff --git a/gcc/gcc.c b/gcc/gcc.c > index b75b50b87b2..06e18a75b52 100644 > --- a/gcc/gcc.c > +++ b/gcc/gcc.c > @@ -4282,6 +4282,10 @@ driver_handle_option (struct gcc_options *opts, > use_ld = ".gold"; > break; > > + case OPT_fuse_ld_mold: > + use_ld = ".mold"; > + break; > + > case OPT_fcompare_debug_second: > compare_debug_second = 1; > break; > diff --git a/gcc/opts.c b/gcc/opts.c > index cdd6463e49b..60f1cf045c9 100644 > --- a/gcc/opts.c > +++ b/gcc/opts.c > @@ -3094,6 +3094,7 @@ common_handle_option (struct gcc_options *opts, > case OPT_fuse_ld_bfd: > case OPT_fuse_ld_gold: > case OPT_fuse_ld_lld: > + case OPT_fuse_ld_mold: > case OPT_fuse_linker_plugin: > /* No-op. Used by the driver and passed to us because it starts with f.*/ > break; > -- > 2.34.1 >
On 12/28/21 14:21, H.J. Lu wrote:
> Missing invoke.texi change.
Oh, sure and I also missed ChangeLog entry.
Fixed in the attached patch.
Martin
On 12/28/2021 7:19 AM, Martin Liška wrote: > On 12/28/21 14:21, H.J. Lu wrote: >> Missing invoke.texi change. > > Oh, sure and I also missed ChangeLog entry. > > Fixed in the attached patch. > Martin > > 0001-Support-ld.mold-linker.patch > > From ca60317a60ee20ce848b36588b905b5a63d81350 Mon Sep 17 00:00:00 2001 > From: Martin Liska <mliska@suse.cz> > Date: Tue, 21 Dec 2021 17:43:55 +0100 > Subject: [PATCH] Support ld.mold linker. > > gcc/ChangeLog: > > * collect2.c (main): Add ld.mold. > * common.opt: Add -fuse-ld=mold. > * doc/invoke.texi: Document it. > * gcc.c (driver_handle_option): Handle -fuse-ld=mold. > * opts.c (common_handle_option): Likewise. OK. jeff
On Tue, Dec 28, 2021 at 2:10 PM Martin Liška <mliska@suse.cz> wrote: > > Hello. > > The mold linker is getting quite popular and I think we should support it: > https://github.com/rui314/mold Does it support the gold plugin API/ABI and thus proper LTO? If not I'm not sure we should encourage use. For example using -flto -fuse-ld=lld will report strange ld.lld: error: undefined symbol: main >>> referenced by start.S:104 (../sysdeps/x86_64/start.S:104) >>> /usr/lib/../lib64/crt1.o:(_start) collect2: error: ld returned 1 exit status on a simple test with a main() unless I manually add -fno-use-linker-plugin. Richard. > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > > --- > gcc/collect2.c | 10 +++++++--- > gcc/common.opt | 4 ++++ > gcc/gcc.c | 4 ++++ > gcc/opts.c | 1 + > 4 files changed, 16 insertions(+), 3 deletions(-) > > diff --git a/gcc/collect2.c b/gcc/collect2.c > index d47fe3f9195..b322527847c 100644 > --- a/gcc/collect2.c > +++ b/gcc/collect2.c > @@ -776,6 +776,7 @@ main (int argc, char **argv) > USE_GOLD_LD, > USE_BFD_LD, > USE_LLD_LD, > + USE_MOLD_LD, > USE_LD_MAX > } selected_linker = USE_DEFAULT_LD; > static const char *const ld_suffixes[USE_LD_MAX] = > @@ -784,7 +785,8 @@ main (int argc, char **argv) > PLUGIN_LD_SUFFIX, > "ld.gold", > "ld.bfd", > - "ld.lld" > + "ld.lld", > + "ld.mold" > }; > static const char *const real_ld_suffix = "real-ld"; > static const char *const collect_ld_suffix = "collect-ld"; > @@ -957,6 +959,8 @@ main (int argc, char **argv) > selected_linker = USE_GOLD_LD; > else if (strcmp (argv[i], "-fuse-ld=lld") == 0) > selected_linker = USE_LLD_LD; > + else if (strcmp (argv[i], "-fuse-ld=mold") == 0) > + selected_linker = USE_MOLD_LD; > else if (startswith (argv[i], "-o")) > { > /* Parse the output filename if it's given so that we can make > @@ -1048,7 +1052,7 @@ main (int argc, char **argv) > ld_file_name = 0; > #ifdef DEFAULT_LINKER > if (selected_linker == USE_BFD_LD || selected_linker == USE_GOLD_LD || > - selected_linker == USE_LLD_LD) > + selected_linker == USE_LLD_LD || selected_linker == USE_MOLD_LD) > { > char *linker_name; > # ifdef HOST_EXECUTABLE_SUFFIX > @@ -1283,7 +1287,7 @@ main (int argc, char **argv) > else if (!use_collect_ld > && startswith (arg, "-fuse-ld=")) > { > - /* Do not pass -fuse-ld={bfd|gold|lld} to the linker. */ > + /* Do not pass -fuse-ld={bfd|gold|lld|mold} to the linker. */ > ld1--; > ld2--; > } > diff --git a/gcc/common.opt b/gcc/common.opt > index 2ed818d6057..dba3fa886f9 100644 > --- a/gcc/common.opt > +++ b/gcc/common.opt > @@ -3046,6 +3046,10 @@ fuse-ld=lld > Common Driver Negative(fuse-ld=lld) > Use the lld LLVM linker instead of the default linker. > > +fuse-ld=mold > +Common Driver Negative(fuse-ld=mold) > +Use the Modern linker (MOLD) linker instead of the default linker. > + > fuse-linker-plugin > Common Undocumented Var(flag_use_linker_plugin) > > diff --git a/gcc/gcc.c b/gcc/gcc.c > index b75b50b87b2..06e18a75b52 100644 > --- a/gcc/gcc.c > +++ b/gcc/gcc.c > @@ -4282,6 +4282,10 @@ driver_handle_option (struct gcc_options *opts, > use_ld = ".gold"; > break; > > + case OPT_fuse_ld_mold: > + use_ld = ".mold"; > + break; > + > case OPT_fcompare_debug_second: > compare_debug_second = 1; > break; > diff --git a/gcc/opts.c b/gcc/opts.c > index cdd6463e49b..60f1cf045c9 100644 > --- a/gcc/opts.c > +++ b/gcc/opts.c > @@ -3094,6 +3094,7 @@ common_handle_option (struct gcc_options *opts, > case OPT_fuse_ld_bfd: > case OPT_fuse_ld_gold: > case OPT_fuse_ld_lld: > + case OPT_fuse_ld_mold: > case OPT_fuse_linker_plugin: > /* No-op. Used by the driver and passed to us because it starts with f.*/ > break; > -- > 2.34.1 >
On 1/3/22 15:48, Richard Biener wrote: > On Tue, Dec 28, 2021 at 2:10 PM Martin Liška <mliska@suse.cz> wrote: >> >> Hello. >> >> The mold linker is getting quite popular and I think we should support it: >> https://github.com/rui314/mold > > Does it support the gold plugin API/ABI and thus proper LTO? No, but it's planned to be added: https://github.com/rui314/mold/issues/181 > If not > I'm not sure we should encourage use. For example using > -flto -fuse-ld=lld will report strange > > ld.lld: error: undefined symbol: main >>>> referenced by start.S:104 (../sysdeps/x86_64/start.S:104) >>>> /usr/lib/../lib64/crt1.o:(_start) > collect2: error: ld returned 1 exit status > > on a simple test with a main() unless I manually add -fno-use-linker-plugin. Yep, that's consequence of the fact a compiler is not built with such linker. Maybe we can add a documentation note, what do you think? Cheers, Martin > > Richard. > >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. >> >> Ready to be installed? >> Thanks, >> Martin >> >> --- >> gcc/collect2.c | 10 +++++++--- >> gcc/common.opt | 4 ++++ >> gcc/gcc.c | 4 ++++ >> gcc/opts.c | 1 + >> 4 files changed, 16 insertions(+), 3 deletions(-) >> >> diff --git a/gcc/collect2.c b/gcc/collect2.c >> index d47fe3f9195..b322527847c 100644 >> --- a/gcc/collect2.c >> +++ b/gcc/collect2.c >> @@ -776,6 +776,7 @@ main (int argc, char **argv) >> USE_GOLD_LD, >> USE_BFD_LD, >> USE_LLD_LD, >> + USE_MOLD_LD, >> USE_LD_MAX >> } selected_linker = USE_DEFAULT_LD; >> static const char *const ld_suffixes[USE_LD_MAX] = >> @@ -784,7 +785,8 @@ main (int argc, char **argv) >> PLUGIN_LD_SUFFIX, >> "ld.gold", >> "ld.bfd", >> - "ld.lld" >> + "ld.lld", >> + "ld.mold" >> }; >> static const char *const real_ld_suffix = "real-ld"; >> static const char *const collect_ld_suffix = "collect-ld"; >> @@ -957,6 +959,8 @@ main (int argc, char **argv) >> selected_linker = USE_GOLD_LD; >> else if (strcmp (argv[i], "-fuse-ld=lld") == 0) >> selected_linker = USE_LLD_LD; >> + else if (strcmp (argv[i], "-fuse-ld=mold") == 0) >> + selected_linker = USE_MOLD_LD; >> else if (startswith (argv[i], "-o")) >> { >> /* Parse the output filename if it's given so that we can make >> @@ -1048,7 +1052,7 @@ main (int argc, char **argv) >> ld_file_name = 0; >> #ifdef DEFAULT_LINKER >> if (selected_linker == USE_BFD_LD || selected_linker == USE_GOLD_LD || >> - selected_linker == USE_LLD_LD) >> + selected_linker == USE_LLD_LD || selected_linker == USE_MOLD_LD) >> { >> char *linker_name; >> # ifdef HOST_EXECUTABLE_SUFFIX >> @@ -1283,7 +1287,7 @@ main (int argc, char **argv) >> else if (!use_collect_ld >> && startswith (arg, "-fuse-ld=")) >> { >> - /* Do not pass -fuse-ld={bfd|gold|lld} to the linker. */ >> + /* Do not pass -fuse-ld={bfd|gold|lld|mold} to the linker. */ >> ld1--; >> ld2--; >> } >> diff --git a/gcc/common.opt b/gcc/common.opt >> index 2ed818d6057..dba3fa886f9 100644 >> --- a/gcc/common.opt >> +++ b/gcc/common.opt >> @@ -3046,6 +3046,10 @@ fuse-ld=lld >> Common Driver Negative(fuse-ld=lld) >> Use the lld LLVM linker instead of the default linker. >> >> +fuse-ld=mold >> +Common Driver Negative(fuse-ld=mold) >> +Use the Modern linker (MOLD) linker instead of the default linker. >> + >> fuse-linker-plugin >> Common Undocumented Var(flag_use_linker_plugin) >> >> diff --git a/gcc/gcc.c b/gcc/gcc.c >> index b75b50b87b2..06e18a75b52 100644 >> --- a/gcc/gcc.c >> +++ b/gcc/gcc.c >> @@ -4282,6 +4282,10 @@ driver_handle_option (struct gcc_options *opts, >> use_ld = ".gold"; >> break; >> >> + case OPT_fuse_ld_mold: >> + use_ld = ".mold"; >> + break; >> + >> case OPT_fcompare_debug_second: >> compare_debug_second = 1; >> break; >> diff --git a/gcc/opts.c b/gcc/opts.c >> index cdd6463e49b..60f1cf045c9 100644 >> --- a/gcc/opts.c >> +++ b/gcc/opts.c >> @@ -3094,6 +3094,7 @@ common_handle_option (struct gcc_options *opts, >> case OPT_fuse_ld_bfd: >> case OPT_fuse_ld_gold: >> case OPT_fuse_ld_lld: >> + case OPT_fuse_ld_mold: >> case OPT_fuse_linker_plugin: >> /* No-op. Used by the driver and passed to us because it starts with f.*/ >> break; >> -- >> 2.34.1 >>
On Mon, Jan 3, 2022 at 4:23 PM Martin Liška <mliska@suse.cz> wrote: > > On 1/3/22 15:48, Richard Biener wrote: > > On Tue, Dec 28, 2021 at 2:10 PM Martin Liška <mliska@suse.cz> wrote: > >> > >> Hello. > >> > >> The mold linker is getting quite popular and I think we should support it: > >> https://github.com/rui314/mold > > > > Does it support the gold plugin API/ABI and thus proper LTO? > > No, but it's planned to be added: > https://github.com/rui314/mold/issues/181 > > > If not > > I'm not sure we should encourage use. For example using > > -flto -fuse-ld=lld will report strange > > > > ld.lld: error: undefined symbol: main > >>>> referenced by start.S:104 (../sysdeps/x86_64/start.S:104) > >>>> /usr/lib/../lib64/crt1.o:(_start) > > collect2: error: ld returned 1 exit status > > > > on a simple test with a main() unless I manually add -fno-use-linker-plugin. > > Yep, that's consequence of the fact a compiler is not built with such linker. > Maybe we can add a documentation note, what do you think? Since we have a fixed set of supported linkers and we know their implementation status with respect to linker plugin support we can maybe auto-add -fno-use-linker-plugin (via specs?) when -fuse-ld=lld or -fuse-ld=mold is used? But yes, adding a note to the documentation that for lld and mold LTO support is severely restricted compared to GNU ld or gold on platforms that support the linker plugin and thus their use is discouraged there might be a good idea. Richard. > > Cheers, > Martin > > > > > Richard. > > > >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > >> > >> Ready to be installed? > >> Thanks, > >> Martin > >> > >> --- > >> gcc/collect2.c | 10 +++++++--- > >> gcc/common.opt | 4 ++++ > >> gcc/gcc.c | 4 ++++ > >> gcc/opts.c | 1 + > >> 4 files changed, 16 insertions(+), 3 deletions(-) > >> > >> diff --git a/gcc/collect2.c b/gcc/collect2.c > >> index d47fe3f9195..b322527847c 100644 > >> --- a/gcc/collect2.c > >> +++ b/gcc/collect2.c > >> @@ -776,6 +776,7 @@ main (int argc, char **argv) > >> USE_GOLD_LD, > >> USE_BFD_LD, > >> USE_LLD_LD, > >> + USE_MOLD_LD, > >> USE_LD_MAX > >> } selected_linker = USE_DEFAULT_LD; > >> static const char *const ld_suffixes[USE_LD_MAX] = > >> @@ -784,7 +785,8 @@ main (int argc, char **argv) > >> PLUGIN_LD_SUFFIX, > >> "ld.gold", > >> "ld.bfd", > >> - "ld.lld" > >> + "ld.lld", > >> + "ld.mold" > >> }; > >> static const char *const real_ld_suffix = "real-ld"; > >> static const char *const collect_ld_suffix = "collect-ld"; > >> @@ -957,6 +959,8 @@ main (int argc, char **argv) > >> selected_linker = USE_GOLD_LD; > >> else if (strcmp (argv[i], "-fuse-ld=lld") == 0) > >> selected_linker = USE_LLD_LD; > >> + else if (strcmp (argv[i], "-fuse-ld=mold") == 0) > >> + selected_linker = USE_MOLD_LD; > >> else if (startswith (argv[i], "-o")) > >> { > >> /* Parse the output filename if it's given so that we can make > >> @@ -1048,7 +1052,7 @@ main (int argc, char **argv) > >> ld_file_name = 0; > >> #ifdef DEFAULT_LINKER > >> if (selected_linker == USE_BFD_LD || selected_linker == USE_GOLD_LD || > >> - selected_linker == USE_LLD_LD) > >> + selected_linker == USE_LLD_LD || selected_linker == USE_MOLD_LD) > >> { > >> char *linker_name; > >> # ifdef HOST_EXECUTABLE_SUFFIX > >> @@ -1283,7 +1287,7 @@ main (int argc, char **argv) > >> else if (!use_collect_ld > >> && startswith (arg, "-fuse-ld=")) > >> { > >> - /* Do not pass -fuse-ld={bfd|gold|lld} to the linker. */ > >> + /* Do not pass -fuse-ld={bfd|gold|lld|mold} to the linker. */ > >> ld1--; > >> ld2--; > >> } > >> diff --git a/gcc/common.opt b/gcc/common.opt > >> index 2ed818d6057..dba3fa886f9 100644 > >> --- a/gcc/common.opt > >> +++ b/gcc/common.opt > >> @@ -3046,6 +3046,10 @@ fuse-ld=lld > >> Common Driver Negative(fuse-ld=lld) > >> Use the lld LLVM linker instead of the default linker. > >> > >> +fuse-ld=mold > >> +Common Driver Negative(fuse-ld=mold) > >> +Use the Modern linker (MOLD) linker instead of the default linker. > >> + > >> fuse-linker-plugin > >> Common Undocumented Var(flag_use_linker_plugin) > >> > >> diff --git a/gcc/gcc.c b/gcc/gcc.c > >> index b75b50b87b2..06e18a75b52 100644 > >> --- a/gcc/gcc.c > >> +++ b/gcc/gcc.c > >> @@ -4282,6 +4282,10 @@ driver_handle_option (struct gcc_options *opts, > >> use_ld = ".gold"; > >> break; > >> > >> + case OPT_fuse_ld_mold: > >> + use_ld = ".mold"; > >> + break; > >> + > >> case OPT_fcompare_debug_second: > >> compare_debug_second = 1; > >> break; > >> diff --git a/gcc/opts.c b/gcc/opts.c > >> index cdd6463e49b..60f1cf045c9 100644 > >> --- a/gcc/opts.c > >> +++ b/gcc/opts.c > >> @@ -3094,6 +3094,7 @@ common_handle_option (struct gcc_options *opts, > >> case OPT_fuse_ld_bfd: > >> case OPT_fuse_ld_gold: > >> case OPT_fuse_ld_lld: > >> + case OPT_fuse_ld_mold: > >> case OPT_fuse_linker_plugin: > >> /* No-op. Used by the driver and passed to us because it starts with f.*/ > >> break; > >> -- > >> 2.34.1 > >> >
On 1/4/22 08:23, Richard Biener wrote: > Since we have a fixed set of supported linkers and we know their implementation > status with respect to linker plugin support we can maybe auto-add > -fno-use-linker-plugin > (via specs?) when -fuse-ld=lld or -fuse-ld=mold is used? Well, if I'm correct, we do so when GCC is configured with --with-ld=... That can perform version detection and so on. I still hope that ld.mold will support LTO plug-in quite soon. It's even possible that it will be there once GCC 12.1 is released. > But yes, > adding a note to > the documentation that for lld and mold LTO support is severely > restricted compared to > GNU ld or gold on platforms that support the linker plugin and thus > their use is discouraged > there might be a good idea. I'm going to do that if ld.mold LTO support won't be available when 12.1 gets released. Martin
diff --git a/gcc/collect2.c b/gcc/collect2.c index d47fe3f9195..b322527847c 100644 --- a/gcc/collect2.c +++ b/gcc/collect2.c @@ -776,6 +776,7 @@ main (int argc, char **argv) USE_GOLD_LD, USE_BFD_LD, USE_LLD_LD, + USE_MOLD_LD, USE_LD_MAX } selected_linker = USE_DEFAULT_LD; static const char *const ld_suffixes[USE_LD_MAX] = @@ -784,7 +785,8 @@ main (int argc, char **argv) PLUGIN_LD_SUFFIX, "ld.gold", "ld.bfd", - "ld.lld" + "ld.lld", + "ld.mold" }; static const char *const real_ld_suffix = "real-ld"; static const char *const collect_ld_suffix = "collect-ld"; @@ -957,6 +959,8 @@ main (int argc, char **argv) selected_linker = USE_GOLD_LD; else if (strcmp (argv[i], "-fuse-ld=lld") == 0) selected_linker = USE_LLD_LD; + else if (strcmp (argv[i], "-fuse-ld=mold") == 0) + selected_linker = USE_MOLD_LD; else if (startswith (argv[i], "-o")) { /* Parse the output filename if it's given so that we can make @@ -1048,7 +1052,7 @@ main (int argc, char **argv) ld_file_name = 0; #ifdef DEFAULT_LINKER if (selected_linker == USE_BFD_LD || selected_linker == USE_GOLD_LD || - selected_linker == USE_LLD_LD) + selected_linker == USE_LLD_LD || selected_linker == USE_MOLD_LD) { char *linker_name; # ifdef HOST_EXECUTABLE_SUFFIX @@ -1283,7 +1287,7 @@ main (int argc, char **argv) else if (!use_collect_ld && startswith (arg, "-fuse-ld=")) { - /* Do not pass -fuse-ld={bfd|gold|lld} to the linker. */ + /* Do not pass -fuse-ld={bfd|gold|lld|mold} to the linker. */ ld1--; ld2--; } diff --git a/gcc/common.opt b/gcc/common.opt index 2ed818d6057..dba3fa886f9 100644 --- a/gcc/common.opt +++ b/gcc/common.opt @@ -3046,6 +3046,10 @@ fuse-ld=lld Common Driver Negative(fuse-ld=lld) Use the lld LLVM linker instead of the default linker. +fuse-ld=mold +Common Driver Negative(fuse-ld=mold) +Use the Modern linker (MOLD) linker instead of the default linker. + fuse-linker-plugin Common Undocumented Var(flag_use_linker_plugin) diff --git a/gcc/gcc.c b/gcc/gcc.c index b75b50b87b2..06e18a75b52 100644 --- a/gcc/gcc.c +++ b/gcc/gcc.c @@ -4282,6 +4282,10 @@ driver_handle_option (struct gcc_options *opts, use_ld = ".gold"; break; + case OPT_fuse_ld_mold: + use_ld = ".mold"; + break; + case OPT_fcompare_debug_second: compare_debug_second = 1; break; diff --git a/gcc/opts.c b/gcc/opts.c index cdd6463e49b..60f1cf045c9 100644 --- a/gcc/opts.c +++ b/gcc/opts.c @@ -3094,6 +3094,7 @@ common_handle_option (struct gcc_options *opts, case OPT_fuse_ld_bfd: case OPT_fuse_ld_gold: case OPT_fuse_ld_lld: + case OPT_fuse_ld_mold: case OPT_fuse_linker_plugin: /* No-op. Used by the driver and passed to us because it starts with f.*/ break;