Message ID | 20b4a99e-dc99-a00d-cea1-41bfa1ae7ceb@suse.cz |
---|---|
State | New |
Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BD51D385840B for <patchwork@sourceware.org>; Thu, 4 Nov 2021 12:36:24 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 978E9385841C for <gcc-patches@gcc.gnu.org>; Thu, 4 Nov 2021 12:36:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 978E9385841C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 86074218DF; Thu, 4 Nov 2021 12:36:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1636029367; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RupQCLKv+jykx8vIpM+1ub4jOXi4A3H+0dsqJqPQaV0=; b=S0Q39h2Td28o6+ej2bTrDoJyAKBtcAAUHRFX+NR5gSwlAgkdMRq6PydM8mVO7JPQRTxHgt YrvvN0MTa88zKt3dre/R/qnw9n1Mm0e+cMHckJRAdlVwMK8Vy7gY6azmo9SXBrBoD8f60Q dTM9bCYG1kvP+jm1890GaeBuvfljlR8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1636029367; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RupQCLKv+jykx8vIpM+1ub4jOXi4A3H+0dsqJqPQaV0=; b=68lYRgLKA7eJ/DQpf0nYOaHWb8ViYdUGxUFwZVH6tCqYSfiUacvaTX423P8u9ImynUpzSn Ps5uBqssh23fpCCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 744CC13BD4; Thu, 4 Nov 2021 12:36:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NNlhGrfTg2FrEAAAMHmgww (envelope-from <mliska@suse.cz>); Thu, 04 Nov 2021 12:36:07 +0000 Message-ID: <20b4a99e-dc99-a00d-cea1-41bfa1ae7ceb@suse.cz> Date: Thu, 4 Nov 2021 13:36:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 From: =?utf-8?q?Martin_Li=C5=A1ka?= <mliska@suse.cz> Subject: [PATCH][V2] rs6000: Remove unnecessary option manipulation. Content-Language: en-US To: GCC Patches <gcc-patches@gcc.gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Cc: segher@kernel.crashing.org Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> |
Series |
[V2] rs6000: Remove unnecessary option manipulation.
|
|
Commit Message
Martin Liška
Nov. 4, 2021, 12:36 p.m. UTC
Sending the patch in a separate thread. Ready for master? Cheers, Martin gcc/ChangeLog: * config/rs6000/rs6000.c (rs6000_override_options_after_change): Do not set flag_rename_registers, it's already enabled with EnabledBy(funroll-loops). Use EnabledBy for unroll_only_small_loops. * config/rs6000/rs6000.opt: Use EnabledBy for unroll_only_small_loops. --- gcc/config/rs6000/rs6000.c | 7 +------ gcc/config/rs6000/rs6000.opt | 2 +- 2 files changed, 2 insertions(+), 7 deletions(-)
Comments
PING^1 On 11/4/21 13:36, Martin Liška wrote: > Sending the patch in a separate thread. > > Ready for master? > > Cheers, > Martin > > gcc/ChangeLog: > > * config/rs6000/rs6000.c (rs6000_override_options_after_change): > Do not set flag_rename_registers, it's already enabled with > EnabledBy(funroll-loops). > Use EnabledBy for unroll_only_small_loops. > * config/rs6000/rs6000.opt: Use EnabledBy for > unroll_only_small_loops. > --- > gcc/config/rs6000/rs6000.c | 7 +------ > gcc/config/rs6000/rs6000.opt | 2 +- > 2 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c > index 01a95591a5d..b9dddcd0aa1 100644 > --- a/gcc/config/rs6000/rs6000.c > +++ b/gcc/config/rs6000/rs6000.c > @@ -3472,13 +3472,8 @@ rs6000_override_options_after_change (void) > /* Explicit -funroll-loops turns -munroll-only-small-loops off, and > turns -frename-registers on. */ > if ((OPTION_SET_P (flag_unroll_loops) && flag_unroll_loops) > - || (OPTION_SET_P (flag_unroll_all_loops) > - && flag_unroll_all_loops)) > + || (OPTION_SET_P (flag_unroll_all_loops) && flag_unroll_all_loops)) > { > - if (!OPTION_SET_P (unroll_only_small_loops)) > - unroll_only_small_loops = 0; > - if (!OPTION_SET_P (flag_rename_registers)) > - flag_rename_registers = 1; > if (!OPTION_SET_P (flag_cunroll_grow_size)) > flag_cunroll_grow_size = 1; > } > diff --git a/gcc/config/rs6000/rs6000.opt b/gcc/config/rs6000/rs6000.opt > index 9d7878f144a..faeb7423ca7 100644 > --- a/gcc/config/rs6000/rs6000.opt > +++ b/gcc/config/rs6000/rs6000.opt > @@ -546,7 +546,7 @@ Target Undocumented Var(rs6000_optimize_swaps) Init(1) Save > Analyze and remove doubleword swaps from VSX computations. > > munroll-only-small-loops > -Target Undocumented Var(unroll_only_small_loops) Init(0) Save > +Target Undocumented Var(unroll_only_small_loops) Init(0) Save EnabledBy(funroll-loops) > ; Use conservative small loop unrolling. > > mpower9-misc
Hi! On Thu, Nov 04, 2021 at 01:36:06PM +0100, Martin Liška wrote: > Sending the patch in a separate thread. You forgot to send the commit message though? > * config/rs6000/rs6000.c (rs6000_override_options_after_change): > Do not set flag_rename_registers, it's already enabled with > EnabledBy(funroll-loops). > Use EnabledBy for unroll_only_small_loops. > * config/rs6000/rs6000.opt: Use EnabledBy for > unroll_only_small_loops. Please don't put newlines in random places. It makes reading changelogs much harder than needed. > --- a/gcc/config/rs6000/rs6000.c > +++ b/gcc/config/rs6000/rs6000.c > @@ -3472,13 +3472,8 @@ rs6000_override_options_after_change (void) > /* Explicit -funroll-loops turns -munroll-only-small-loops off, and > turns -frename-registers on. */ > if ((OPTION_SET_P (flag_unroll_loops) && flag_unroll_loops) > - || (OPTION_SET_P (flag_unroll_all_loops) > - && flag_unroll_all_loops)) > + || (OPTION_SET_P (flag_unroll_all_loops) && flag_unroll_all_loops)) > { > - if (!OPTION_SET_P (unroll_only_small_loops)) > - unroll_only_small_loops = 0; > - if (!OPTION_SET_P (flag_rename_registers)) > - flag_rename_registers = 1; > if (!OPTION_SET_P (flag_cunroll_grow_size)) > flag_cunroll_grow_size = 1; > } So some explanation for these two changes would be good to have. > diff --git a/gcc/config/rs6000/rs6000.opt b/gcc/config/rs6000/rs6000.opt > index 9d7878f144a..faeb7423ca7 100644 > --- a/gcc/config/rs6000/rs6000.opt > +++ b/gcc/config/rs6000/rs6000.opt > @@ -546,7 +546,7 @@ Target Undocumented Var(rs6000_optimize_swaps) Init(1) > Save > Analyze and remove doubleword swaps from VSX computations. > > munroll-only-small-loops > -Target Undocumented Var(unroll_only_small_loops) Init(0) Save > +Target Undocumented Var(unroll_only_small_loops) Init(0) Save > EnabledBy(funroll-loops) You used format=flowed it seems? Don't. Patches are mangled with it :-( Segher
On 11/11/21 18:52, Segher Boessenkool wrote: > Hi! > > On Thu, Nov 04, 2021 at 01:36:06PM +0100, Martin Liška wrote: >> Sending the patch in a separate thread. > Hello. > You forgot to send the commit message though? No, the patch is simple so I didn't write any message (except commit title). > >> * config/rs6000/rs6000.c (rs6000_override_options_after_change): >> Do not set flag_rename_registers, it's already enabled with >> EnabledBy(funroll-loops). >> Use EnabledBy for unroll_only_small_loops. >> * config/rs6000/rs6000.opt: Use EnabledBy for >> unroll_only_small_loops. > > Please don't put newlines in random places. It makes reading changelogs > much harder than needed. All right, I'm going to update it in V3. > >> --- a/gcc/config/rs6000/rs6000.c >> +++ b/gcc/config/rs6000/rs6000.c >> @@ -3472,13 +3472,8 @@ rs6000_override_options_after_change (void) >> /* Explicit -funroll-loops turns -munroll-only-small-loops off, and >> turns -frename-registers on. */ >> if ((OPTION_SET_P (flag_unroll_loops) && flag_unroll_loops) >> - || (OPTION_SET_P (flag_unroll_all_loops) >> - && flag_unroll_all_loops)) >> + || (OPTION_SET_P (flag_unroll_all_loops) && flag_unroll_all_loops)) >> { >> - if (!OPTION_SET_P (unroll_only_small_loops)) >> - unroll_only_small_loops = 0; >> - if (!OPTION_SET_P (flag_rename_registers)) >> - flag_rename_registers = 1; >> if (!OPTION_SET_P (flag_cunroll_grow_size)) >> flag_cunroll_grow_size = 1; >> } > > So some explanation for these two changes would be good to have. It's explained in the ChangeLog entry. > >> diff --git a/gcc/config/rs6000/rs6000.opt b/gcc/config/rs6000/rs6000.opt >> index 9d7878f144a..faeb7423ca7 100644 >> --- a/gcc/config/rs6000/rs6000.opt >> +++ b/gcc/config/rs6000/rs6000.opt >> @@ -546,7 +546,7 @@ Target Undocumented Var(rs6000_optimize_swaps) Init(1) >> Save >> Analyze and remove doubleword swaps from VSX computations. >> >> munroll-only-small-loops >> -Target Undocumented Var(unroll_only_small_loops) Init(0) Save >> +Target Undocumented Var(unroll_only_small_loops) Init(0) Save >> EnabledBy(funroll-loops) > > You used format=flowed it seems? Don't. Patches are mangled with it :-( No, it's correct: https://gcc.gnu.org/pipermail/gcc-patches/2021-November/583310.html Martin > > > Segher >
On Fri, Nov 12, 2021 at 03:34:17PM +0100, Martin Liška wrote: > On 11/11/21 18:52, Segher Boessenkool wrote: > >You forgot to send the commit message though? > > No, the patch is simple so I didn't write any message (except commit title). How is a maintainer supposed to know what the patch is about, then? Not all of us are clairvoyant. > >>--- a/gcc/config/rs6000/rs6000.c > >>+++ b/gcc/config/rs6000/rs6000.c > >>@@ -3472,13 +3472,8 @@ rs6000_override_options_after_change (void) > >> /* Explicit -funroll-loops turns -munroll-only-small-loops off, and > >> turns -frename-registers on. */ > >> if ((OPTION_SET_P (flag_unroll_loops) && flag_unroll_loops) > >>- || (OPTION_SET_P (flag_unroll_all_loops) > >>- && flag_unroll_all_loops)) > >>+ || (OPTION_SET_P (flag_unroll_all_loops) && > >>flag_unroll_all_loops)) > >> { > >>- if (!OPTION_SET_P (unroll_only_small_loops)) > >>- unroll_only_small_loops = 0; > >>- if (!OPTION_SET_P (flag_rename_registers)) > >>- flag_rename_registers = 1; > >> if (!OPTION_SET_P (flag_cunroll_grow_size)) > >> flag_cunroll_grow_size = 1; > >> } > > > >So some explanation for these two changes would be good to have. > > It's explained in the ChangeLog entry. It is not. Besides, a changelog should describe *what* changed, not *why*, anyway. > >>diff --git a/gcc/config/rs6000/rs6000.opt b/gcc/config/rs6000/rs6000.opt > >>index 9d7878f144a..faeb7423ca7 100644 > >>--- a/gcc/config/rs6000/rs6000.opt > >>+++ b/gcc/config/rs6000/rs6000.opt > >>@@ -546,7 +546,7 @@ Target Undocumented Var(rs6000_optimize_swaps) Init(1) > >>Save > >> Analyze and remove doubleword swaps from VSX computations. > >> > >> munroll-only-small-loops > >>-Target Undocumented Var(unroll_only_small_loops) Init(0) Save > >>+Target Undocumented Var(unroll_only_small_loops) Init(0) Save > >>EnabledBy(funroll-loops) > > > >You used format=flowed it seems? Don't. Patches are mangled with it :-( > > No, it's correct: > https://gcc.gnu.org/pipermail/gcc-patches/2021-November/583310.html Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit It is not correct. Please fix. Segher
On 11/12/21 16:58, Segher Boessenkool wrote: > On Fri, Nov 12, 2021 at 03:34:17PM +0100, Martin Liška wrote: >> On 11/11/21 18:52, Segher Boessenkool wrote: >>> You forgot to send the commit message though? >> >> No, the patch is simple so I didn't write any message (except commit title). > > How is a maintainer supposed to know what the patch is about, then? Not > all of us are clairvoyant. Oh yeah, lemme explain it. > >>>> --- a/gcc/config/rs6000/rs6000.c >>>> +++ b/gcc/config/rs6000/rs6000.c >>>> @@ -3472,13 +3472,8 @@ rs6000_override_options_after_change (void) >>>> /* Explicit -funroll-loops turns -munroll-only-small-loops off, and >>>> turns -frename-registers on. */ >>>> if ((OPTION_SET_P (flag_unroll_loops) && flag_unroll_loops) >>>> - || (OPTION_SET_P (flag_unroll_all_loops) >>>> - && flag_unroll_all_loops)) >>>> + || (OPTION_SET_P (flag_unroll_all_loops) && >>>> flag_unroll_all_loops)) >>>> { >>>> - if (!OPTION_SET_P (unroll_only_small_loops)) >>>> - unroll_only_small_loops = 0; >>>> - if (!OPTION_SET_P (flag_rename_registers)) >>>> - flag_rename_registers = 1; >>>> if (!OPTION_SET_P (flag_cunroll_grow_size)) >>>> flag_cunroll_grow_size = 1; >>>> } >>> >>> So some explanation for these two changes would be good to have. >> >> It's explained in the ChangeLog entry. > > It is not. Besides, a changelog should describe *what* changed, not > *why*, anyway. All right. > >>>> diff --git a/gcc/config/rs6000/rs6000.opt b/gcc/config/rs6000/rs6000.opt >>>> index 9d7878f144a..faeb7423ca7 100644 >>>> --- a/gcc/config/rs6000/rs6000.opt >>>> +++ b/gcc/config/rs6000/rs6000.opt >>>> @@ -546,7 +546,7 @@ Target Undocumented Var(rs6000_optimize_swaps) Init(1) >>>> Save >>>> Analyze and remove doubleword swaps from VSX computations. >>>> >>>> munroll-only-small-loops >>>> -Target Undocumented Var(unroll_only_small_loops) Init(0) Save >>>> +Target Undocumented Var(unroll_only_small_loops) Init(0) Save >>>> EnabledBy(funroll-loops) >>> >>> You used format=flowed it seems? Don't. Patches are mangled with it :-( >> >> No, it's correct: >> https://gcc.gnu.org/pipermail/gcc-patches/2021-November/583310.html > > Content-Type: text/plain; charset=UTF-8; format=flowed > Content-Transfer-Encoding: 8bit > > It is not correct. Please fix. Ok, I've just used directly git send-email, please search for V4. Thanks, Martin > > > Segher >
diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c index 01a95591a5d..b9dddcd0aa1 100644 --- a/gcc/config/rs6000/rs6000.c +++ b/gcc/config/rs6000/rs6000.c @@ -3472,13 +3472,8 @@ rs6000_override_options_after_change (void) /* Explicit -funroll-loops turns -munroll-only-small-loops off, and turns -frename-registers on. */ if ((OPTION_SET_P (flag_unroll_loops) && flag_unroll_loops) - || (OPTION_SET_P (flag_unroll_all_loops) - && flag_unroll_all_loops)) + || (OPTION_SET_P (flag_unroll_all_loops) && flag_unroll_all_loops)) { - if (!OPTION_SET_P (unroll_only_small_loops)) - unroll_only_small_loops = 0; - if (!OPTION_SET_P (flag_rename_registers)) - flag_rename_registers = 1; if (!OPTION_SET_P (flag_cunroll_grow_size)) flag_cunroll_grow_size = 1; } diff --git a/gcc/config/rs6000/rs6000.opt b/gcc/config/rs6000/rs6000.opt index 9d7878f144a..faeb7423ca7 100644 --- a/gcc/config/rs6000/rs6000.opt +++ b/gcc/config/rs6000/rs6000.opt @@ -546,7 +546,7 @@ Target Undocumented Var(rs6000_optimize_swaps) Init(1) Save Analyze and remove doubleword swaps from VSX computations. munroll-only-small-loops -Target Undocumented Var(unroll_only_small_loops) Init(0) Save +Target Undocumented Var(unroll_only_small_loops) Init(0) Save EnabledBy(funroll-loops) ; Use conservative small loop unrolling. mpower9-misc