Message ID | 6189797e-b646-fb2b-0d23-befa8ed1aa55@gmx.ch |
---|---|
State | New |
Headers |
Return-Path: <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E8001385841E for <patchwork@sourceware.org>; Fri, 29 Oct 2021 14:13:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E8001385841E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1635516805; bh=QrBZXrtwpAji1PU6qdffMCyEe9gqFyOalVEnEVrRed4=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=mlIwNrk0MntCCDw+pXV82b0dwrQbZxy+GeZGy6AZyudVtuKARiwMNHl3tWlGfWAa3 ezpxISIGV8RL4qAUUaGLKALcZ0ovkN6x2m6hmf13JEAdIcwnppVT1aaBlPgVmZAVcq celD1fb2q7gElAo/4wRrpWixZz1mt262dbjN8Kow= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by sourceware.org (Postfix) with ESMTPS id B06B73858408; Fri, 29 Oct 2021 14:12:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B06B73858408 X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.99.12] ([212.126.164.126]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mw9QC-1mxAci4AFQ-00s6ik; Fri, 29 Oct 2021 16:12:37 +0200 To: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: [PATCH] Fortran: adjust error message for SHORT and LONG intrinsics Message-ID: <6189797e-b646-fb2b-0d23-befa8ed1aa55@gmx.ch> Date: Fri, 29 Oct 2021 16:12:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------472BB9F05079493190B72E68" Content-Language: en-US X-Provags-ID: V03:K1:MEvF9iZ7ptvN9T+fPdXzrw/FLFq8EQu3VTWJ3cdwCpvPFRBA8M3 NZCWqEyn5diKDzqNLtbQ9JbconL/0subdp4VU6lRZkkNeokiui4HQpe21brVoik+T6Y03nW YenGdqVCPSN/YsVrV5uFMS8eqt6v8rq+tk+ehuYIttLWQRhlpv8VmwoiseSlsQ/GyNaRvyt cGU9Lmg7MU2H+2utLyZ3w== X-UI-Out-Filterresults: notjunk:1;V03:K0:tmnij/Fq2Vg=:exeMxYjdcfW93aiwCRUVd8 JtbFz49pcG5K2qNHOMLktquxMcAvOvj99lmcNLQ6b/apy9WB7OFRfcABOE+9UjR/glBI0YG4s /D91EKU7jlO3LfSf3PvrMNnF4acNg6aFzEqYY91Cz34mVOMlmMoKBPtlc+x2pQlws2fFMBvBl r6CcCVNf64YR5QnD5uCEn/hWu40rkib3yJ/70tQ6agO9dqOMjWvMp67VchFdAwIj07FkRRGcq lHMsEETgaSqzGKJvDIe4Rit/mgfDAUjwAIPSk1r7Lza3BHcMCrdrZIx+tmsq829zMNX6EcuC+ bqXTLxhWStShGjNts/yvWdavzwrPNQBjguQWnZx5KBVJxqZFy/XcUMSe5kbLJnHrl1EqeOaK2 HOV2C6ger37FkyA3zjojodr47Wxllr+xSHHiZrBXnQbF+0HNncpjycdaxGqE6u3eWSmGY0r2z yqP0T9q1qI7UwbzPM0D81xvxmYCgxypY6bNjF7GwukfdoaouJVwHuy5iAvwRvsZg7QFOkHO0/ Vg4T1KUiFQwxajZNstI1IpDDodiu24R8rTBI7F26IUHaFthAWHDMyZVFyJGrSWAUbZsAVHmI6 TxHYAXCoKspp2nw+8p3jRSPDzfsd5odCf0kSiq/eRR9gCwLXu33EVo5KTnc1PuOKTvlCV4N3i 3b0MbHyIBtVTiNtMJaqYJl2Qyv5msLdGK1LRYJJi/f2JvxZCupBwSnd/Tiyu5kDei2F8Ny//3 JUz8zx6osjBLvm4wmLvHr9VDzKqigW7FmOsPRwXOotIULndHudPFu0TEZR9AEVdmASG7+yXqL xThhbdyjQ/Moer7+G6NDJcmhnmpyOKd6Sm2p/RmEga3ZwqHljY4t1B9TJVdQ/tYFH0+JpK6Kr z0RrlmGxnsM6uCtmbCuI/StRlJhUk4/L385WRTzsSV10ABM9xJJwMwfZwHWenDnAl5JzYzj7C mUHA9OvVSryQST5hjR++uaXvF6VzRqCjptyQlaNf2zvrpYuFAOXDbrJGavjs2xorrgm6IeGW1 OOdx2XE0fuoV21WkkOoZ7apjAklR2m0p+aELDrLDN8gkaTrvSDEQ+a7+ai7dYziLaCrcybnOQ PagZG8DOsIYpno= X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: Manfred Schwarb via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: Manfred Schwarb <manfred99@gmx.ch> Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org> |
Series |
Fortran: adjust error message for SHORT and LONG intrinsics
|
|
Commit Message
Manfred Schwarb
Oct. 29, 2021, 2:12 p.m. UTC
Hi, on 2019-07-23, support for SHORT and LONG intrinsics were removed be Steve Kargl by adding an error message in check.c. However, the error message Error: 'long' intrinsic subprogram at (1) has been deprecated is misleading, as support has been disabled by this patch. Adjust the error message. This error message does not appear in the testsuite AFAIK. Signed-off-by Manfred Schwarb <manfred99@gmx.ch> [Note: I do not have commit access]
Comments
Hi Manfred, Am 29.10.21 um 16:12 schrieb Manfred Schwarb via Fortran: > Hi, > > on 2019-07-23, support for SHORT and LONG intrinsics were removed be Steve Kargl by > adding an error message in check.c. However, the error message > Error: 'long' intrinsic subprogram at (1) has been deprecated > is misleading, as support has been disabled by this patch. > > Adjust the error message. This error message does not appear in the testsuite AFAIK. the patch looks fine. A testcase checking the error message is missing, as well as a ChangeLog entry. Thanks, Harald > Signed-off-by Manfred Schwarb <manfred99@gmx.ch> > > > [Note: I do not have commit access] >
Am 29.10.21 um 21:51 schrieb Harald Anlauf via Fortran: > Hi Manfred, > > Am 29.10.21 um 16:12 schrieb Manfred Schwarb via Fortran: >> Hi, >> >> on 2019-07-23, support for SHORT and LONG intrinsics were removed be Steve Kargl by >> adding an error message in check.c. However, the error message >> Error: 'long' intrinsic subprogram at (1) has been deprecated >> is misleading, as support has been disabled by this patch. >> >> Adjust the error message. This error message does not appear in the testsuite AFAIK. > > the patch looks fine. A testcase checking the error message is missing, > as well as a ChangeLog entry. Sorry, forgot the changelog entry, I added it to the patch now. Testcase was missing already before, but I added a trivial test to the patch for completeness. > > Thanks, > Harald > >> Signed-off-by Manfred Schwarb <manfred99@gmx.ch> >> >> >> [Note: I do not have commit access] >> > >
Committed as r12-4807. Thanks for the patch! Harald Am 30.10.21 um 01:15 schrieb Manfred Schwarb via Gcc-patches: > Am 29.10.21 um 21:51 schrieb Harald Anlauf via Fortran: >> Hi Manfred, >> >> Am 29.10.21 um 16:12 schrieb Manfred Schwarb via Fortran: >>> Hi, >>> >>> on 2019-07-23, support for SHORT and LONG intrinsics were removed be Steve Kargl by >>> adding an error message in check.c. However, the error message >>> Error: 'long' intrinsic subprogram at (1) has been deprecated >>> is misleading, as support has been disabled by this patch. >>> >>> Adjust the error message. This error message does not appear in the testsuite AFAIK. >> >> the patch looks fine. A testcase checking the error message is missing, >> as well as a ChangeLog entry. > > Sorry, forgot the changelog entry, I added it to the patch now. > Testcase was missing already before, but I added a trivial test to the patch for completeness. > >> >> Thanks, >> Harald >> >>> Signed-off-by Manfred Schwarb <manfred99@gmx.ch> >>> >>> >>> [Note: I do not have commit access] >>> >> >> >
--- gcc/gcc/fortran/check.c.orig 2021-10-15 02:20:28.825876592 +0200 +++ gcc/gcc/fortran/check.c 2021-10-29 14:44:51.771512312 +0200 @@ -3240,7 +3240,7 @@ gfc_check_intconv (gfc_expr *x) if (strcmp (gfc_current_intrinsic, "short") == 0 || strcmp (gfc_current_intrinsic, "long") == 0) { - gfc_error ("%qs intrinsic subprogram at %L has been deprecated. " + gfc_error ("%qs intrinsic subprogram at %L has been removed. " "Use INT intrinsic subprogram.", gfc_current_intrinsic, &x->where); return false;