diff mbox series

Hurd: Add rtld-strncpy-c.c

Message ID CAMe9rOrrM9jrrTcKoT3y_8nAn1YdYiMPfwHX08g2_Zs9iQ7rvw@mail.gmail.com
State Committed
Headers show
Series Hurd: Add rtld-strncpy-c.c | expand

Commit Message

H.J. Lu Jan. 19, 2021, 2:24 a.m. UTC
On Mon, Jan 18, 2021 at 4:40 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Mon, Jan 18, 2021 at 4:24 PM Samuel Thibault <samuel.thibault@gnu.org> wrote:
> >
> > Samuel Thibault, le mar. 19 janv. 2021 01:21:05 +0100, a ecrit:
> > > H.J. Lu, le lun. 18 janv. 2021 16:17:16 -0800, a ecrit:
> > > > Why doesn't hurd ld.so build script mark strncpy as needed?
> > >
> > > I don't even know what "hurd ld.so build script" is.
> >
> > More precisely, I don't see why hurd should be doing anything special
> > while everything is already taken care of by elf/Makefile's librtld.map
> > file scripts.
> >
>
> I am taking a look.
>

Try this.   I have no idea if it really works on hurd.

Comments

Samuel Thibault Jan. 19, 2021, 9:02 a.m. UTC | #1
H.J. Lu via Libc-alpha, le lun. 18 janv. 2021 18:24:48 -0800, a ecrit:
> On Mon, Jan 18, 2021 at 4:40 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> >
> > On Mon, Jan 18, 2021 at 4:24 PM Samuel Thibault <samuel.thibault@gnu.org> wrote:
> > >
> > > Samuel Thibault, le mar. 19 janv. 2021 01:21:05 +0100, a ecrit:
> > > > H.J. Lu, le lun. 18 janv. 2021 16:17:16 -0800, a ecrit:
> > > > > Why doesn't hurd ld.so build script mark strncpy as needed?
> > > >
> > > > I don't even know what "hurd ld.so build script" is.
> > >
> > > More precisely, I don't see why hurd should be doing anything special
> > > while everything is already taken care of by elf/Makefile's librtld.map
> > > file scripts.
> >
> > I am taking a look.
> 
> Try this.   I have no idea if it really works on hurd.

It is working indeed.

Samuel
H.J. Lu Jan. 19, 2021, 12:21 p.m. UTC | #2
On Tue, Jan 19, 2021 at 1:02 AM Samuel Thibault <samuel.thibault@gnu.org> wrote:
>
> H.J. Lu via Libc-alpha, le lun. 18 janv. 2021 18:24:48 -0800, a ecrit:
> > On Mon, Jan 18, 2021 at 4:40 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > >
> > > On Mon, Jan 18, 2021 at 4:24 PM Samuel Thibault <samuel.thibault@gnu.org> wrote:
> > > >
> > > > Samuel Thibault, le mar. 19 janv. 2021 01:21:05 +0100, a ecrit:
> > > > > H.J. Lu, le lun. 18 janv. 2021 16:17:16 -0800, a ecrit:
> > > > > > Why doesn't hurd ld.so build script mark strncpy as needed?
> > > > >
> > > > > I don't even know what "hurd ld.so build script" is.
> > > >
> > > > More precisely, I don't see why hurd should be doing anything special
> > > > while everything is already taken care of by elf/Makefile's librtld.map
> > > > file scripts.
> > >
> > > I am taking a look.
> >
> > Try this.   I have no idea if it really works on hurd.
>
> It is working indeed.
>
> Samuel

Should I check it in?
Adhemerval Zanella Jan. 19, 2021, 12:25 p.m. UTC | #3
On 19/01/2021 09:21, H.J. Lu via Libc-alpha wrote:
> On Tue, Jan 19, 2021 at 1:02 AM Samuel Thibault <samuel.thibault@gnu.org> wrote:
>>
>> H.J. Lu via Libc-alpha, le lun. 18 janv. 2021 18:24:48 -0800, a ecrit:
>>> On Mon, Jan 18, 2021 at 4:40 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>>>>
>>>> On Mon, Jan 18, 2021 at 4:24 PM Samuel Thibault <samuel.thibault@gnu.org> wrote:
>>>>>
>>>>> Samuel Thibault, le mar. 19 janv. 2021 01:21:05 +0100, a ecrit:
>>>>>> H.J. Lu, le lun. 18 janv. 2021 16:17:16 -0800, a ecrit:
>>>>>>> Why doesn't hurd ld.so build script mark strncpy as needed?
>>>>>>
>>>>>> I don't even know what "hurd ld.so build script" is.
>>>>>
>>>>> More precisely, I don't see why hurd should be doing anything special
>>>>> while everything is already taken care of by elf/Makefile's librtld.map
>>>>> file scripts.
>>>>
>>>> I am taking a look.
>>>
>>> Try this.   I have no idea if it really works on hurd.
>>
>> It is working indeed.
>>
>> Samuel
> 
> Should I check it in?
> 
> 
Yes please, the loader should not use ifunc on its own string usage and
it is a build issue.
H.J. Lu Jan. 19, 2021, 12:35 p.m. UTC | #4
On Tue, Jan 19, 2021 at 4:26 AM Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
>
>
>
> On 19/01/2021 09:21, H.J. Lu via Libc-alpha wrote:
> > On Tue, Jan 19, 2021 at 1:02 AM Samuel Thibault <samuel.thibault@gnu.org> wrote:
> >>
> >> H.J. Lu via Libc-alpha, le lun. 18 janv. 2021 18:24:48 -0800, a ecrit:
> >>> On Mon, Jan 18, 2021 at 4:40 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> >>>>
> >>>> On Mon, Jan 18, 2021 at 4:24 PM Samuel Thibault <samuel.thibault@gnu.org> wrote:
> >>>>>
> >>>>> Samuel Thibault, le mar. 19 janv. 2021 01:21:05 +0100, a ecrit:
> >>>>>> H.J. Lu, le lun. 18 janv. 2021 16:17:16 -0800, a ecrit:
> >>>>>>> Why doesn't hurd ld.so build script mark strncpy as needed?
> >>>>>>
> >>>>>> I don't even know what "hurd ld.so build script" is.
> >>>>>
> >>>>> More precisely, I don't see why hurd should be doing anything special
> >>>>> while everything is already taken care of by elf/Makefile's librtld.map
> >>>>> file scripts.
> >>>>
> >>>> I am taking a look.
> >>>
> >>> Try this.   I have no idea if it really works on hurd.
> >>
> >> It is working indeed.
> >>
> >> Samuel
> >
> > Should I check it in?
> >
> >
> Yes please, the loader should not use ifunc on its own string usage and
> it is a build issue.

Done.
Samuel Thibault Jan. 19, 2021, 12:44 p.m. UTC | #5
H.J. Lu via Libc-alpha, le mar. 19 janv. 2021 04:35:09 -0800, a ecrit:
> On Tue, Jan 19, 2021 at 4:26 AM Adhemerval Zanella
> <adhemerval.zanella@linaro.org> wrote:
> > On 19/01/2021 09:21, H.J. Lu via Libc-alpha wrote:
> > > On Tue, Jan 19, 2021 at 1:02 AM Samuel Thibault <samuel.thibault@gnu.org> wrote:
> > >> H.J. Lu via Libc-alpha, le lun. 18 janv. 2021 18:24:48 -0800, a ecrit:
> > >>> On Mon, Jan 18, 2021 at 4:40 PM H.J. Lu <hjl.tools@gmail.com> wrote:
> > >>>> On Mon, Jan 18, 2021 at 4:24 PM Samuel Thibault <samuel.thibault@gnu.org> wrote:
> > >>>>> More precisely, I don't see why hurd should be doing anything special
> > >>>>> while everything is already taken care of by elf/Makefile's librtld.map
> > >>>>> file scripts.
> > >>>>
> > >>>> I am taking a look.
> > >>>
> > >>> Try this.   I have no idea if it really works on hurd.
> > >>
> > >> It is working indeed.
> > >
> > > Should I check it in?
> > >
> >
> > Yes please, the loader should not use ifunc on its own string usage and
> > it is a build issue.
> 
> Done.

Thanks!
diff mbox series

Patch

From a73010aaab13c5cd67ded77091601b8cd01e3fcf Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Mon, 18 Jan 2021 18:19:16 -0800
Subject: [PATCH] Hurd: Add rtld-strncpy-c.c

All IFUNC functions which are used in ld.so must have a rtld version if
the IFUNC version isn't safe to use in ld.so.
---
 sysdeps/mach/hurd/i386/i686/multiarch/rtld-strncpy-c.c | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 sysdeps/mach/hurd/i386/i686/multiarch/rtld-strncpy-c.c

diff --git a/sysdeps/mach/hurd/i386/i686/multiarch/rtld-strncpy-c.c b/sysdeps/mach/hurd/i386/i686/multiarch/rtld-strncpy-c.c
new file mode 100644
index 0000000000..b759c999eb
--- /dev/null
+++ b/sysdeps/mach/hurd/i386/i686/multiarch/rtld-strncpy-c.c
@@ -0,0 +1 @@ 
+#include <string/strncpy.c>
-- 
2.29.2