| Message ID | CAMe9rOrrM9jrrTcKoT3y_8nAn1YdYiMPfwHX08g2_Zs9iQ7rvw@mail.gmail.com |
|---|---|
| State | Committed |
| Headers |
Return-Path: <libc-alpha-bounces@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D6FFA3857C6D; Tue, 19 Jan 2021 02:25:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D6FFA3857C6D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1611023126; bh=azHs0YvucwN5tW0mnfrKaQ51xLMxxaJfnoAzlU/gFaQ=; h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=qr2vcg1nf+tpyAeD1CnQI0uuRknHa5BrhpJtG3Z9puVXlPsJQzcfz6IOJuFWJuKCa Cb16SuWVFOyuDTEFU0+h3mUfSPdyyENG2x/JaTsOj/BMlGNiY7Unl53c73kdvm9MnR UxFQV996dC3o1bBVmnALPsOs0cL9b24dAk45/oxk= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by sourceware.org (Postfix) with ESMTPS id 2551E3870889 for <libc-alpha@sourceware.org>; Tue, 19 Jan 2021 02:25:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2551E3870889 Received: by mail-ot1-x32f.google.com with SMTP id n42so18336158ota.12 for <libc-alpha@sourceware.org>; Mon, 18 Jan 2021 18:25:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=azHs0YvucwN5tW0mnfrKaQ51xLMxxaJfnoAzlU/gFaQ=; b=BGq/bkBf7Evgy3860YHY3wqLpU4+eLjmRawTnVMqeRtJ6mYFCHTwjCIuSfE8+m+UoA WnKFNIVXIfniU3m+2XuNR7wczdjV9qH3ExIc4LAUal6C0NuY7CM8V/rd41TSTzHeeuRT YJwkl4UbeIaiXGjKvBpbFd0gETRJAJCypGLvfILEMS9ghqBhV7IEkHmq8DtIVzabWt0m xPnxuBfKhUtrQQZyrehR3KrZDnUI1jBfpyia9g98zq1hpInc67q+qcbf1yZla8iJcKqe k+iMlg+vTv7rIrnfHqAFf8nc7kEIodpyMxiYgiwZuBjQ3Xbpz6SNonBKrI/IZIvUik2w eXcw== X-Gm-Message-State: AOAM530eO2T5evudiFpZoYU0DEgGJTObrBZ+f4UHK7kAKrwijJyn8hxt r0XDEyereMvcAD49GZ0VVfLrg6+0vld2GdsMEGhMw4UUGig= X-Google-Smtp-Source: ABdhPJz4nTpjq2Q/P+i86RGrVjaeKloSTPRJ3uKtPKaNK/rH8QZSZB872JM8zxqs8Ta0HuAyVOYRZxo4nuExJVpuyyY= X-Received: by 2002:a9d:6285:: with SMTP id x5mr1828751otk.179.1611023124579; Mon, 18 Jan 2021 18:25:24 -0800 (PST) MIME-Version: 1.0 References: <20201108225251.3195591-1-samuel.thibault@ens-lyon.org> <87h7nl1425.fsf@dem-tschwing-1.ger.mentorg.com> <alpine.DEB.2.22.394.2101182003160.272665@digraph.polyomino.org.uk> <20210119000402.koywpx2l2hhhhem4@begin> <CAMe9rOpCQ=RwOVCVrwQStQ=3DXrWaRqw3ZxRv+4gQ-eP8EYd6A@mail.gmail.com> <20210119002105.g3o6hbu4c3gg37yn@begin> <20210119002455.z5xhus2v4vjj44jx@begin> <CAMe9rOonT9ky7nR7Xe7SYz188Xd_Oo8FEY0YuVs9jjVc9ARKzg@mail.gmail.com> In-Reply-To: <CAMe9rOonT9ky7nR7Xe7SYz188Xd_Oo8FEY0YuVs9jjVc9ARKzg@mail.gmail.com> Date: Mon, 18 Jan 2021 18:24:48 -0800 Message-ID: <CAMe9rOrrM9jrrTcKoT3y_8nAn1YdYiMPfwHX08g2_Zs9iQ7rvw@mail.gmail.com> Subject: [PATCH] Hurd: Add rtld-strncpy-c.c To: Joseph Myers <joseph@codesourcery.com>, Thomas Schwinge <thomas@codesourcery.com>, bug-hurd@gnu.org, GNU C Library <libc-alpha@sourceware.org> Content-Type: multipart/mixed; boundary="000000000000110eb005b9378ddb" X-Spam-Status: No, score=-3038.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org> Reply-To: "H.J. Lu" <hjl.tools@gmail.com> Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org> |
| Series |
Hurd: Add rtld-strncpy-c.c
|
|
Commit Message
H.J. Lu
Jan. 19, 2021, 2:24 a.m. UTC
On Mon, Jan 18, 2021 at 4:40 PM H.J. Lu <hjl.tools@gmail.com> wrote: > > On Mon, Jan 18, 2021 at 4:24 PM Samuel Thibault <samuel.thibault@gnu.org> wrote: > > > > Samuel Thibault, le mar. 19 janv. 2021 01:21:05 +0100, a ecrit: > > > H.J. Lu, le lun. 18 janv. 2021 16:17:16 -0800, a ecrit: > > > > Why doesn't hurd ld.so build script mark strncpy as needed? > > > > > > I don't even know what "hurd ld.so build script" is. > > > > More precisely, I don't see why hurd should be doing anything special > > while everything is already taken care of by elf/Makefile's librtld.map > > file scripts. > > > > I am taking a look. > Try this. I have no idea if it really works on hurd.
Comments
H.J. Lu via Libc-alpha, le lun. 18 janv. 2021 18:24:48 -0800, a ecrit: > On Mon, Jan 18, 2021 at 4:40 PM H.J. Lu <hjl.tools@gmail.com> wrote: > > > > On Mon, Jan 18, 2021 at 4:24 PM Samuel Thibault <samuel.thibault@gnu.org> wrote: > > > > > > Samuel Thibault, le mar. 19 janv. 2021 01:21:05 +0100, a ecrit: > > > > H.J. Lu, le lun. 18 janv. 2021 16:17:16 -0800, a ecrit: > > > > > Why doesn't hurd ld.so build script mark strncpy as needed? > > > > > > > > I don't even know what "hurd ld.so build script" is. > > > > > > More precisely, I don't see why hurd should be doing anything special > > > while everything is already taken care of by elf/Makefile's librtld.map > > > file scripts. > > > > I am taking a look. > > Try this. I have no idea if it really works on hurd. It is working indeed. Samuel
On Tue, Jan 19, 2021 at 1:02 AM Samuel Thibault <samuel.thibault@gnu.org> wrote: > > H.J. Lu via Libc-alpha, le lun. 18 janv. 2021 18:24:48 -0800, a ecrit: > > On Mon, Jan 18, 2021 at 4:40 PM H.J. Lu <hjl.tools@gmail.com> wrote: > > > > > > On Mon, Jan 18, 2021 at 4:24 PM Samuel Thibault <samuel.thibault@gnu.org> wrote: > > > > > > > > Samuel Thibault, le mar. 19 janv. 2021 01:21:05 +0100, a ecrit: > > > > > H.J. Lu, le lun. 18 janv. 2021 16:17:16 -0800, a ecrit: > > > > > > Why doesn't hurd ld.so build script mark strncpy as needed? > > > > > > > > > > I don't even know what "hurd ld.so build script" is. > > > > > > > > More precisely, I don't see why hurd should be doing anything special > > > > while everything is already taken care of by elf/Makefile's librtld.map > > > > file scripts. > > > > > > I am taking a look. > > > > Try this. I have no idea if it really works on hurd. > > It is working indeed. > > Samuel Should I check it in?
On 19/01/2021 09:21, H.J. Lu via Libc-alpha wrote: > On Tue, Jan 19, 2021 at 1:02 AM Samuel Thibault <samuel.thibault@gnu.org> wrote: >> >> H.J. Lu via Libc-alpha, le lun. 18 janv. 2021 18:24:48 -0800, a ecrit: >>> On Mon, Jan 18, 2021 at 4:40 PM H.J. Lu <hjl.tools@gmail.com> wrote: >>>> >>>> On Mon, Jan 18, 2021 at 4:24 PM Samuel Thibault <samuel.thibault@gnu.org> wrote: >>>>> >>>>> Samuel Thibault, le mar. 19 janv. 2021 01:21:05 +0100, a ecrit: >>>>>> H.J. Lu, le lun. 18 janv. 2021 16:17:16 -0800, a ecrit: >>>>>>> Why doesn't hurd ld.so build script mark strncpy as needed? >>>>>> >>>>>> I don't even know what "hurd ld.so build script" is. >>>>> >>>>> More precisely, I don't see why hurd should be doing anything special >>>>> while everything is already taken care of by elf/Makefile's librtld.map >>>>> file scripts. >>>> >>>> I am taking a look. >>> >>> Try this. I have no idea if it really works on hurd. >> >> It is working indeed. >> >> Samuel > > Should I check it in? > > Yes please, the loader should not use ifunc on its own string usage and it is a build issue.
On Tue, Jan 19, 2021 at 4:26 AM Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote: > > > > On 19/01/2021 09:21, H.J. Lu via Libc-alpha wrote: > > On Tue, Jan 19, 2021 at 1:02 AM Samuel Thibault <samuel.thibault@gnu.org> wrote: > >> > >> H.J. Lu via Libc-alpha, le lun. 18 janv. 2021 18:24:48 -0800, a ecrit: > >>> On Mon, Jan 18, 2021 at 4:40 PM H.J. Lu <hjl.tools@gmail.com> wrote: > >>>> > >>>> On Mon, Jan 18, 2021 at 4:24 PM Samuel Thibault <samuel.thibault@gnu.org> wrote: > >>>>> > >>>>> Samuel Thibault, le mar. 19 janv. 2021 01:21:05 +0100, a ecrit: > >>>>>> H.J. Lu, le lun. 18 janv. 2021 16:17:16 -0800, a ecrit: > >>>>>>> Why doesn't hurd ld.so build script mark strncpy as needed? > >>>>>> > >>>>>> I don't even know what "hurd ld.so build script" is. > >>>>> > >>>>> More precisely, I don't see why hurd should be doing anything special > >>>>> while everything is already taken care of by elf/Makefile's librtld.map > >>>>> file scripts. > >>>> > >>>> I am taking a look. > >>> > >>> Try this. I have no idea if it really works on hurd. > >> > >> It is working indeed. > >> > >> Samuel > > > > Should I check it in? > > > > > Yes please, the loader should not use ifunc on its own string usage and > it is a build issue. Done.
H.J. Lu via Libc-alpha, le mar. 19 janv. 2021 04:35:09 -0800, a ecrit: > On Tue, Jan 19, 2021 at 4:26 AM Adhemerval Zanella > <adhemerval.zanella@linaro.org> wrote: > > On 19/01/2021 09:21, H.J. Lu via Libc-alpha wrote: > > > On Tue, Jan 19, 2021 at 1:02 AM Samuel Thibault <samuel.thibault@gnu.org> wrote: > > >> H.J. Lu via Libc-alpha, le lun. 18 janv. 2021 18:24:48 -0800, a ecrit: > > >>> On Mon, Jan 18, 2021 at 4:40 PM H.J. Lu <hjl.tools@gmail.com> wrote: > > >>>> On Mon, Jan 18, 2021 at 4:24 PM Samuel Thibault <samuel.thibault@gnu.org> wrote: > > >>>>> More precisely, I don't see why hurd should be doing anything special > > >>>>> while everything is already taken care of by elf/Makefile's librtld.map > > >>>>> file scripts. > > >>>> > > >>>> I am taking a look. > > >>> > > >>> Try this. I have no idea if it really works on hurd. > > >> > > >> It is working indeed. > > > > > > Should I check it in? > > > > > > > Yes please, the loader should not use ifunc on its own string usage and > > it is a build issue. > > Done. Thanks!
From a73010aaab13c5cd67ded77091601b8cd01e3fcf Mon Sep 17 00:00:00 2001 From: "H.J. Lu" <hjl.tools@gmail.com> Date: Mon, 18 Jan 2021 18:19:16 -0800 Subject: [PATCH] Hurd: Add rtld-strncpy-c.c All IFUNC functions which are used in ld.so must have a rtld version if the IFUNC version isn't safe to use in ld.so. --- sysdeps/mach/hurd/i386/i686/multiarch/rtld-strncpy-c.c | 1 + 1 file changed, 1 insertion(+) create mode 100644 sysdeps/mach/hurd/i386/i686/multiarch/rtld-strncpy-c.c diff --git a/sysdeps/mach/hurd/i386/i686/multiarch/rtld-strncpy-c.c b/sysdeps/mach/hurd/i386/i686/multiarch/rtld-strncpy-c.c new file mode 100644 index 0000000000..b759c999eb --- /dev/null +++ b/sysdeps/mach/hurd/i386/i686/multiarch/rtld-strncpy-c.c @@ -0,0 +1 @@ +#include <string/strncpy.c> -- 2.29.2