[COMMITTED,1/3] ARM: extract_arm_insn function need to read instrs correctly in be8 case

  Victor Kamensky <victor.kamensky@linaro.org> writes:

> 2014-11-02  Victor Kamensky  <victor.kamensky@linaro.org>
>
> 	* arm-tdep.c (extract_arm_insn): Use
> 	gdbarch_byte_order_for_code to read arm instruction.

Victor,
The changelog entry should be added to the corresponding ChangeLog files
on commit.  They are missing from your commits.  I add them back.
  

On 3 November 2014 04:17, Yao Qi <yao@codesourcery.com> wrote:
> Victor Kamensky <victor.kamensky@linaro.org> writes:
>
>> 2014-11-02  Victor Kamensky  <victor.kamensky@linaro.org>
>>
>>       * arm-tdep.c (extract_arm_insn): Use
>>       gdbarch_byte_order_for_code to read arm instruction.
>
> Victor,
> The changelog entry should be added to the corresponding ChangeLog files
> on commit.  They are missing from your commits.  I add them back.

Sorry, I did not realize that. Will do in the future.
I assume those ChangeLog pieces should not be
removed from commit messages. I.e they will present
in both places corresponding ChangeLog file and
commit messages. Is it correct?

Thanks,
Victor

> --
> Yao (齐尧)
>
> Subject: [PATCH] Add missing changelog entries
>
> Some changelog entries are missing in previous commits.  Add them.
>
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index f09715c..928efef 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,20 @@
> +2014-11-02  Victor Kamensky  <victor.kamensky@linaro.org>
> +
> +       * dwarf2loc.c (read_pieced_value): Do big endian
> +       processing only if gdb_regnum is not -1.
> +       (write_pieced_value): Ditto.
> +
> +2014-11-02  Victor Kamensky  <victor.kamensky@linaro.org>
> +
> +       * arm-linux-tdep.c (arm_linux_init_abi): Use
> +       info.byte_order_for_code to choose endianity of breakpoint
> +       instructions snippets.
> +
> +2014-11-02  Victor Kamensky  <victor.kamensky@linaro.org>
> +
> +       * arm-tdep.c (extract_arm_insn): Use
> +       gdbarch_byte_order_for_code to read arm instruction.
> +
>  2014-11-02  Doug Evans  <xdje42@gmail.com>
>
>         * mdebugread.c (parse_procedure): Delete unnecessary forward decl.
  

Victor Kamensky <victor.kamensky@linaro.org> writes:

> I assume those ChangeLog pieces should not be
> removed from commit messages. I.e they will present
> in both places corresponding ChangeLog file and
> commit messages. Is it correct?

That is correct.