From patchwork Mon Nov  3 12:17:32 2014
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Yao Qi <yao@codesourcery.com>
X-Patchwork-Id: 3565
Received: (qmail 20334 invoked by alias); 3 Nov 2014 12:22:13 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>,
	<http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Delivered-To: mailing list gdb-patches@sourceware.org
Received: (qmail 20320 invoked by uid 89); 3 Nov 2014 12:22:12 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00,
	RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2
X-HELO: relay1.mentorg.com
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131)
	by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with
	ESMTP; Mon, 03 Nov 2014 12:22:10 +0000
Received: from svr-orw-fem-05.mgc.mentorg.com ([147.34.97.43])	by
	relay1.mentorg.com with esmtp id 1XlGe5-0005JZ-93 from
	Yao_Qi@mentor.com ; Mon, 03 Nov 2014 04:22:05 -0800
Received: from GreenOnly (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com
	(147.34.97.43) with Microsoft SMTP Server id 14.3.181.6;
	Mon, 3 Nov 2014 04:22:04 -0800
From: Yao Qi <yao@codesourcery.com>
To: Victor Kamensky <victor.kamensky@linaro.org>
CC: <gdb-patches@sourceware.org>
Subject: Re: [COMMITTED PATCH 1/3] ARM: extract_arm_insn function need to
	read instrs correctly in be8 case
References: <1414964484-6270-1-git-send-email-victor.kamensky@linaro.org>
Date: Mon, 3 Nov 2014 20:17:32 +0800
In-Reply-To: <1414964484-6270-1-git-send-email-victor.kamensky@linaro.org>
	(Victor
	Kamensky's message of "Sun, 2 Nov 2014 13:41:22 -0800")
Message-ID: <87bnoosckj.fsf@codesourcery.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
X-IsSubscribed: yes

Victor Kamensky <victor.kamensky@linaro.org> writes:

> 2014-11-02  Victor Kamensky  <victor.kamensky@linaro.org>
>
> 	* arm-tdep.c (extract_arm_insn): Use
> 	gdbarch_byte_order_for_code to read arm instruction.

Victor,
The changelog entry should be added to the corresponding ChangeLog files
on commit.  They are missing from your commits.  I add them back.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index f09715c..928efef 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,20 @@
+2014-11-02  Victor Kamensky  <victor.kamensky@linaro.org>
+
+	* dwarf2loc.c (read_pieced_value): Do big endian
+	processing only if gdb_regnum is not -1.
+	(write_pieced_value): Ditto.
+
+2014-11-02  Victor Kamensky  <victor.kamensky@linaro.org>
+
+	* arm-linux-tdep.c (arm_linux_init_abi): Use
+	info.byte_order_for_code to choose endianity of breakpoint
+	instructions snippets.
+
+2014-11-02  Victor Kamensky  <victor.kamensky@linaro.org>
+
+	* arm-tdep.c (extract_arm_insn): Use
+	gdbarch_byte_order_for_code to read arm instruction.
+
 2014-11-02  Doug Evans  <xdje42@gmail.com>
 
 	* mdebugread.c (parse_procedure): Delete unnecessary forward decl.