diff mbox

building on musl: #include sys/types.h for mode_t

Message ID 86ziz27urp.fsf@sspiff.org
State New
Headers show

Commit Message

Doug Evans Oct. 28, 2015, 5:44 p.m. UTC
Hi.

Turns out there was a fourth patch. :-)

2015-10-28  Doug Evans  <xdje42@gmail.com>

	* target.h: #include <sys/types.h>

Comments

Pedro Alves Oct. 28, 2015, 5:57 p.m. UTC | #1
On 10/28/2015 05:44 PM, Doug Evans wrote:
> Hi.

Hi there,

> 
> Turns out there was a fourth patch. :-)

:-)

> 
> 2015-10-28  Doug Evans  <xdje42@gmail.com>
> 
> 	* target.h: #include <sys/types.h>
> 
> diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h
> index a14c6ff..f3fcd6c 100644
> --- a/gdb/gdbserver/target.h
> +++ b/gdb/gdbserver/target.h
> @@ -21,6 +21,7 @@
>  #ifndef TARGET_H
>  #define TARGET_H
>  
> +#include <sys/types.h> /* for mode_t */

Where is mode_t referenced? (what's the error?)

>  #include "target/target.h"
>  #include "target/resume.h"
>  #include "target/wait.h"

Thanks,
Pedro Alves
Pedro Alves Oct. 28, 2015, 6:23 p.m. UTC | #2
On 10/28/2015 05:57 PM, Pedro Alves wrote:
> On 10/28/2015 05:44 PM, Doug Evans wrote:
>> Hi.
> 
> Hi there,
> 
>>
>> Turns out there was a fourth patch. :-)
> 
> :-)
> 
>>
>> 2015-10-28  Doug Evans  <xdje42@gmail.com>
>>
>> 	* target.h: #include <sys/types.h>
>>
>> diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h
>> index a14c6ff..f3fcd6c 100644
>> --- a/gdb/gdbserver/target.h
>> +++ b/gdb/gdbserver/target.h
>> @@ -21,6 +21,7 @@
>>  #ifndef TARGET_H
>>  #define TARGET_H
>>  
>> +#include <sys/types.h> /* for mode_t */
> 
> Where is mode_t referenced? (what's the error?)

Nevermind, I didn't notice I was was grepping an old tree,
which predates target->multifs_open.

Patch LGTM.

Thanks,
Pedro Alves
Doug Evans Nov. 23, 2015, 1:28 a.m. UTC | #3
Pedro Alves <palves@redhat.com> writes:
> On 10/28/2015 05:57 PM, Pedro Alves wrote:
>> On 10/28/2015 05:44 PM, Doug Evans wrote:
>>> Hi.
>> 
>> Hi there,
>> 
>>>
>>> Turns out there was a fourth patch. :-)
>> 
>> :-)
>> 
>>>
>>> 2015-10-28  Doug Evans  <xdje42@gmail.com>
>>>
>>> 	* target.h: #include <sys/types.h>
>>>
>>> diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h
>>> index a14c6ff..f3fcd6c 100644
>>> --- a/gdb/gdbserver/target.h
>>> +++ b/gdb/gdbserver/target.h
>>> @@ -21,6 +21,7 @@
>>>  #ifndef TARGET_H
>>>  #define TARGET_H
>>>  
>>> +#include <sys/types.h> /* for mode_t */
>> 
>> Where is mode_t referenced? (what's the error?)
>
> Nevermind, I didn't notice I was was grepping an old tree,
> which predates target->multifs_open.
>
> Patch LGTM.
>
> Thanks,
> Pedro Alves

Committed, thanks.
diff mbox

Patch

diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h
index a14c6ff..f3fcd6c 100644
--- a/gdb/gdbserver/target.h
+++ b/gdb/gdbserver/target.h
@@ -21,6 +21,7 @@ 
 #ifndef TARGET_H
 #define TARGET_H
 
+#include <sys/types.h> /* for mode_t */
 #include "target/target.h"
 #include "target/resume.h"
 #include "target/wait.h"