| Message ID | 86ziz27urp.fsf@sspiff.org |
|---|---|
| State | New, archived |
| Headers |
Received: (qmail 38028 invoked by alias); 28 Oct 2015 17:44:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 38013 invoked by uid 89); 28 Oct 2015 17:44:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f47.google.com Received: from mail-pa0-f47.google.com (HELO mail-pa0-f47.google.com) (209.85.220.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 28 Oct 2015 17:44:12 +0000 Received: by pasz6 with SMTP id z6so13209719pas.2 for <gdb-patches@sourceware.org>; Wed, 28 Oct 2015 10:44:09 -0700 (PDT) X-Received: by 10.68.134.167 with SMTP id pl7mr35495606pbb.45.1446054249801; Wed, 28 Oct 2015 10:44:09 -0700 (PDT) Received: from sspiff.org ([104.135.7.182]) by smtp.gmail.com with ESMTPSA id fx3sm34635267pbb.60.2015.10.28.10.44.08 for <gdb-patches@sourceware.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Oct 2015 10:44:09 -0700 (PDT) Received: by sspiff.org (sSMTP sendmail emulation); Wed, 28 Oct 2015 17:44:26 +0000 From: Doug Evans <xdje42@gmail.com> To: gdb-patches@sourceware.org Subject: [PATCH] building on musl: #include sys/types.h for mode_t Date: Wed, 28 Oct 2015 17:44:26 +0000 Message-ID: <86ziz27urp.fsf@sspiff.org> MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes |
Commit Message
Doug Evans
Oct. 28, 2015, 5:44 p.m. UTC
Hi. Turns out there was a fourth patch. :-) 2015-10-28 Doug Evans <xdje42@gmail.com> * target.h: #include <sys/types.h>
Comments
On 10/28/2015 05:44 PM, Doug Evans wrote: > Hi. Hi there, > > Turns out there was a fourth patch. :-) :-) > > 2015-10-28 Doug Evans <xdje42@gmail.com> > > * target.h: #include <sys/types.h> > > diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h > index a14c6ff..f3fcd6c 100644 > --- a/gdb/gdbserver/target.h > +++ b/gdb/gdbserver/target.h > @@ -21,6 +21,7 @@ > #ifndef TARGET_H > #define TARGET_H > > +#include <sys/types.h> /* for mode_t */ Where is mode_t referenced? (what's the error?) > #include "target/target.h" > #include "target/resume.h" > #include "target/wait.h" Thanks, Pedro Alves
On 10/28/2015 05:57 PM, Pedro Alves wrote: > On 10/28/2015 05:44 PM, Doug Evans wrote: >> Hi. > > Hi there, > >> >> Turns out there was a fourth patch. :-) > > :-) > >> >> 2015-10-28 Doug Evans <xdje42@gmail.com> >> >> * target.h: #include <sys/types.h> >> >> diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h >> index a14c6ff..f3fcd6c 100644 >> --- a/gdb/gdbserver/target.h >> +++ b/gdb/gdbserver/target.h >> @@ -21,6 +21,7 @@ >> #ifndef TARGET_H >> #define TARGET_H >> >> +#include <sys/types.h> /* for mode_t */ > > Where is mode_t referenced? (what's the error?) Nevermind, I didn't notice I was was grepping an old tree, which predates target->multifs_open. Patch LGTM. Thanks, Pedro Alves
Pedro Alves <palves@redhat.com> writes: > On 10/28/2015 05:57 PM, Pedro Alves wrote: >> On 10/28/2015 05:44 PM, Doug Evans wrote: >>> Hi. >> >> Hi there, >> >>> >>> Turns out there was a fourth patch. :-) >> >> :-) >> >>> >>> 2015-10-28 Doug Evans <xdje42@gmail.com> >>> >>> * target.h: #include <sys/types.h> >>> >>> diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h >>> index a14c6ff..f3fcd6c 100644 >>> --- a/gdb/gdbserver/target.h >>> +++ b/gdb/gdbserver/target.h >>> @@ -21,6 +21,7 @@ >>> #ifndef TARGET_H >>> #define TARGET_H >>> >>> +#include <sys/types.h> /* for mode_t */ >> >> Where is mode_t referenced? (what's the error?) > > Nevermind, I didn't notice I was was grepping an old tree, > which predates target->multifs_open. > > Patch LGTM. > > Thanks, > Pedro Alves Committed, thanks.
diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h index a14c6ff..f3fcd6c 100644 --- a/gdb/gdbserver/target.h +++ b/gdb/gdbserver/target.h @@ -21,6 +21,7 @@ #ifndef TARGET_H #define TARGET_H +#include <sys/types.h> /* for mode_t */ #include "target/target.h" #include "target/resume.h" #include "target/wait.h"