diff mbox

[RFAv3,2/6] Improve process exit status macros on MinGW

Message ID 834kx8e5v5.fsf@gnu.org
State New
Headers show

Commit Message

Eli Zaretskii Jan. 6, 2020, 7:34 p.m. UTC
> Date: Mon, 6 Jan 2020 18:59:36 +0000 (UTC)
> From: "Hannes Domani via gdb-patches" <gdb-patches@sourceware.org>
> 
> C:/src/repos/binutils-gdb.git/gdb/gdbsupport/gdb_wait.c: In function 'int windows_status_to_termsig(long unsigned int)':
> C:/src/repos/binutils-gdb.git/gdb/gdbsupport/gdb_wait.c:56:37: error: 'SIGSEGV' was not declared in this scope
>    56 |      {EXCEPTION_ACCESS_VIOLATION,   SIGSEGV},
>       |                                     ^~~~~~~

Does the below help?

Comments

Doug Evans via gdb-patches Jan. 6, 2020, 7:38 p.m. UTC | #1
Am Montag, 6. Januar 2020, 20:34:40 MEZ hat Eli Zaretskii <eliz@gnu.org> Folgendes geschrieben:

> > Date: Mon, 6 Jan 2020 18:59:36 +0000 (UTC)
> > From: "Hannes Domani via gdb-patches" <gdb-patches@sourceware.org>
> >
> > C:/src/repos/binutils-gdb.git/gdb/gdbsupport/gdb_wait.c: In function 'int windows_status_to_termsig(long unsigned int)':
> > C:/src/repos/binutils-gdb.git/gdb/gdbsupport/gdb_wait.c:56:37: error: 'SIGSEGV' was not declared in this scope
> >    56 |      {EXCEPTION_ACCESS_VIOLATION,   SIGSEGV},
> >       |                                     ^~~~~~~
>
> Does the below help?
>
> diff --git a/gdb/gdbsupport/gdb_wait.c b/gdb/gdbsupport/gdb_wait.c
> index 037ba64..6facc48 100644
> --- a/gdb/gdbsupport/gdb_wait.c
> +++ b/gdb/gdbsupport/gdb_wait.c
> @@ -34,7 +34,7 @@
>     false positives is justified by the utility of reporting the
>     terminating signal in the "normal" cases.  */
>
> -# include "gdb/signals.h"    /* for enum gdb_signal */
> +# include <signal.h>
>
>
> # define WIN32_LEAN_AND_MEAN
> # include <windows.h>        /* for EXCEPTION_* constants */

Yes, this works.
Eli Zaretskii Jan. 6, 2020, 7:55 p.m. UTC | #2
> Date: Mon, 6 Jan 2020 19:38:50 +0000 (UTC)
> From: "Hannes Domani via gdb-patches" <gdb-patches@sourceware.org>
> 
> > Does the below help?
> >
> > diff --git a/gdb/gdbsupport/gdb_wait.c b/gdb/gdbsupport/gdb_wait.c
> > index 037ba64..6facc48 100644
> > --- a/gdb/gdbsupport/gdb_wait.c
> > +++ b/gdb/gdbsupport/gdb_wait.c
> > @@ -34,7 +34,7 @@
> >     false positives is justified by the utility of reporting the
> >     terminating signal in the "normal" cases.  */
> >
> > -# include "gdb/signals.h"    /* for enum gdb_signal */
> > +# include <signal.h>
> >
> >
> > # define WIN32_LEAN_AND_MEAN
> > # include <windows.h>        /* for EXCEPTION_* constants */
> 
> Yes, this works.

Thanks, pushed.
diff mbox

Patch

diff --git a/gdb/gdbsupport/gdb_wait.c b/gdb/gdbsupport/gdb_wait.c
index 037ba64..6facc48 100644
--- a/gdb/gdbsupport/gdb_wait.c
+++ b/gdb/gdbsupport/gdb_wait.c
@@ -34,7 +34,7 @@ 
    false positives is justified by the utility of reporting the
    terminating signal in the "normal" cases.  */
 
-# include "gdb/signals.h"	/* for enum gdb_signal */
+# include <signal.h>
 
 # define WIN32_LEAN_AND_MEAN
 # include <windows.h>		/* for EXCEPTION_* constants */