Message ID | 834kx8e5v5.fsf@gnu.org |
---|---|
State | New, archived |
Headers |
Received: (qmail 25297 invoked by alias); 6 Jan 2020 19:34:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 25287 invoked by uid 89); 6 Jan 2020 19:34:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.0 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.1 spammy=HContent-type:text, HContent-type:charset, HContent-type:plain, HContent-type:utf-8 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Jan 2020 19:34:32 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33159) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>) id 1ioY90-0008O4-Ff; Mon, 06 Jan 2020 14:34:30 -0500 Received: from [176.228.60.248] (port=2520 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@gnu.org>) id 1ioY8z-0003bB-UQ; Mon, 06 Jan 2020 14:34:30 -0500 Date: Mon, 06 Jan 2020 21:34:38 +0200 Message-Id: <834kx8e5v5.fsf@gnu.org> From: Eli Zaretskii <eliz@gnu.org> To: Hannes Domani <ssbssa@yahoo.de> CC: gdb-patches@sourceware.org In-reply-to: <1720750964.12023035.1578337176662@mail.yahoo.com> (gdb-patches@sourceware.org) Subject: Re: [RFAv3 2/6] Improve process exit status macros on MinGW References: <20190504161753.15530-1-philippe.waroquiers@skynet.be> <20190504161753.15530-3-philippe.waroquiers@skynet.be> <a8d1a153-4d17-9a3c-82bb-389d44d073d4@redhat.com> <835zie51mf.fsf@gnu.org> <52c4ca33-ffc4-8e1e-fe08-a92123ef02aa@redhat.com> <83o8w536l6.fsf@gnu.org> <3aacf88f-212e-f11f-0688-4f8219dab4c3@redhat.com> <83k16t32no.fsf@gnu.org> <83fth8v1nu.fsf@gnu.org> <52408aa9-5a86-2ade-ec23-c8293eff130d@redhat.com> <1720750964.12023035.1578337176662@mail.yahoo.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes |
Commit Message
Eli Zaretskii
Jan. 6, 2020, 7:34 p.m. UTC
> Date: Mon, 6 Jan 2020 18:59:36 +0000 (UTC) > From: "Hannes Domani via gdb-patches" <gdb-patches@sourceware.org> > > C:/src/repos/binutils-gdb.git/gdb/gdbsupport/gdb_wait.c: In function 'int windows_status_to_termsig(long unsigned int)': > C:/src/repos/binutils-gdb.git/gdb/gdbsupport/gdb_wait.c:56:37: error: 'SIGSEGV' was not declared in this scope > 56 | {EXCEPTION_ACCESS_VIOLATION, SIGSEGV}, > | ^~~~~~~ Does the below help?
Comments
Am Montag, 6. Januar 2020, 20:34:40 MEZ hat Eli Zaretskii <eliz@gnu.org> Folgendes geschrieben: > > Date: Mon, 6 Jan 2020 18:59:36 +0000 (UTC) > > From: "Hannes Domani via gdb-patches" <gdb-patches@sourceware.org> > > > > C:/src/repos/binutils-gdb.git/gdb/gdbsupport/gdb_wait.c: In function 'int windows_status_to_termsig(long unsigned int)': > > C:/src/repos/binutils-gdb.git/gdb/gdbsupport/gdb_wait.c:56:37: error: 'SIGSEGV' was not declared in this scope > > 56 | {EXCEPTION_ACCESS_VIOLATION, SIGSEGV}, > > | ^~~~~~~ > > Does the below help? > > diff --git a/gdb/gdbsupport/gdb_wait.c b/gdb/gdbsupport/gdb_wait.c > index 037ba64..6facc48 100644 > --- a/gdb/gdbsupport/gdb_wait.c > +++ b/gdb/gdbsupport/gdb_wait.c > @@ -34,7 +34,7 @@ > false positives is justified by the utility of reporting the > terminating signal in the "normal" cases. */ > > -# include "gdb/signals.h" /* for enum gdb_signal */ > +# include <signal.h> > > > # define WIN32_LEAN_AND_MEAN > # include <windows.h> /* for EXCEPTION_* constants */ Yes, this works.
> Date: Mon, 6 Jan 2020 19:38:50 +0000 (UTC) > From: "Hannes Domani via gdb-patches" <gdb-patches@sourceware.org> > > > Does the below help? > > > > diff --git a/gdb/gdbsupport/gdb_wait.c b/gdb/gdbsupport/gdb_wait.c > > index 037ba64..6facc48 100644 > > --- a/gdb/gdbsupport/gdb_wait.c > > +++ b/gdb/gdbsupport/gdb_wait.c > > @@ -34,7 +34,7 @@ > > false positives is justified by the utility of reporting the > > terminating signal in the "normal" cases. */ > > > > -# include "gdb/signals.h" /* for enum gdb_signal */ > > +# include <signal.h> > > > > > > # define WIN32_LEAN_AND_MEAN > > # include <windows.h> /* for EXCEPTION_* constants */ > > Yes, this works. Thanks, pushed.
diff --git a/gdb/gdbsupport/gdb_wait.c b/gdb/gdbsupport/gdb_wait.c index 037ba64..6facc48 100644 --- a/gdb/gdbsupport/gdb_wait.c +++ b/gdb/gdbsupport/gdb_wait.c @@ -34,7 +34,7 @@ false positives is justified by the utility of reporting the terminating signal in the "normal" cases. */ -# include "gdb/signals.h" /* for enum gdb_signal */ +# include <signal.h> # define WIN32_LEAN_AND_MEAN # include <windows.h> /* for EXCEPTION_* constants */