diff mbox series

[1/3] gdb/record: remove unnecessary use of filename_completer

Message ID 754ab2b77ccc626c0d9684fced83bfd514a5b836.1713190701.git.aburgess@redhat.com
State New
Headers
Series Small cleanups in gdb/record*.c code |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Testing passed

Commit Message

Andrew Burgess April 15, 2024, 2:19 p.m. UTC 
  Spotted that the 'record' command has its completer set to
filename_completer.  The problem is that 'record' is a prefix command,
as such, its completer is hard-coded to complete on sub-commands.  The
attempt to use filename_completer is irrelevant.

The 'record' command is itself a command though, that is, a user can
do this:

  (gdb) record

which is really just an alias for:

  (gdb) target record-full

Nowhere does cmd_record_start (which is called when 'record' is used)
expect a filename, and 'target record-full' doesn't expect a filename
either.

So lets just drop the line which sets filename_completer as the
completer for 'record'.
---
 gdb/record.c | 2 --
 1 file changed, 2 deletions(-)
diff mbox series

Patch

diff --git a/gdb/record.c b/gdb/record.c
index 1843969c2c9..25a4c1e71b6 100644
--- a/gdb/record.c
+++ b/gdb/record.c
@@ -791,8 +791,6 @@  A size of \"unlimited\" means unlimited lines.  The default is 10."),
     = add_prefix_cmd ("record", class_obscure, cmd_record_start,
 		      _("Start recording."),
 		      &record_cmdlist, 0, &cmdlist);
-  set_cmd_completer (record_cmd, filename_completer);
-
   add_com_alias ("rec", record_cmd, class_obscure, 1);
 
   set_show_commands setshow_record_cmds