mbox series

[0/3] Small cleanups in gdb/record*.c code

Message ID cover.1713190701.git.aburgess@redhat.com
Headers
Series Small cleanups in gdb/record*.c code |

Message

Andrew Burgess April 15, 2024, 2:19 p.m. UTC 
  Series of trivial cleanups in the gdb/record*.c code.  The first two
should have no user visible effects.

The third does add a new error case, so I guess a user might hit that,
this is all explained in the commit message.

---

Andrew Burgess (3):
  gdb/record: remove unnecessary use of filename_completer
  gdb/record: add an assert in cmd_record_start
  gdb/record: minor clean, remove some unneeded arguments

 gdb/NEWS                                     |  4 ++++
 gdb/record-full.c                            | 15 +++++++-----
 gdb/record.c                                 |  9 +++++---
 gdb/testsuite/gdb.base/record-full-error.exp | 24 ++++++++++++++++++++
 4 files changed, 43 insertions(+), 9 deletions(-)
 create mode 100644 gdb/testsuite/gdb.base/record-full-error.exp


base-commit: 032e5e0c0c08977e8109e8482cd944bac8572d92

Comments

Tom Tromey April 16, 2024, 5:18 p.m. UTC | #1 
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:

Andrew> Series of trivial cleanups in the gdb/record*.c code.  The first two
Andrew> should have no user visible effects.

Andrew> The third does add a new error case, so I guess a user might hit that,
Andrew> this is all explained in the commit message.

I read through these and they seem fine to me.
It would be good to address Keith's comments about the error message,
but aside from that --
Approved-By: Tom Tromey <tom@tromey.com>

Tom
Andrew Burgess April 17, 2024, 1:48 p.m. UTC | #2 
Tom Tromey <tom@tromey.com> writes:

>>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
>
> Andrew> Series of trivial cleanups in the gdb/record*.c code.  The first two
> Andrew> should have no user visible effects.
>
> Andrew> The third does add a new error case, so I guess a user might hit that,
> Andrew> this is all explained in the commit message.
>
> I read through these and they seem fine to me.
> It would be good to address Keith's comments about the error message,
> but aside from that --
> Approved-By: Tom Tromey <tom@tromey.com>

I addresses Keith's comment, and pushed this series.

Thanks,
Andrew