diff mbox series

gdb/data-directory: silence output from mkinstalldirs script

Message ID 644b3363a3ac88ea06ddab33a8e824d8d445f19d.1712579194.git.aburgess@redhat.com
State New
Headers
Series gdb/data-directory: silence output from mkinstalldirs script |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Testing passed

Commit Message

Andrew Burgess April 8, 2024, 12:26 p.m. UTC 
  After my recent changes the data-directory build now uses
silent-rules.mk to reduce the output.

One problem that remains was the use of mkinstalldirs by stamp-python
and stamp-guile for creating some directories, the mkinstalldirs
prints some messages, so we're left with output like this:

    GEN    stamp-python
  mkdir -p -- ./python/gdb
  mkdir -p -- ./python/gdb/command
  mkdir -p -- ./python/gdb/dap
  mkdir -p -- ./python/gdb/function
  mkdir -p -- ./python/gdb/printer

I was looking at adding a --silent option to the mkinstalldirs script,
however, when I took a look at the automake package (which is where
mkinstalldirs comes from) it turns out that mkinstalldirs is
deprecated, at the advice is to use 'install-sh -d' instead.

Just like we carry mkinstalldirs in the top-level directory, we also
carry install-sh, and a version of install-sh which supports the -d
flag.

And best of all, 'install-sh -d' doesn't appear to print any of the
information messages to stdout that mkinstalldirs does, so if we
switch to use that, we get a quieter build.

There should be no changes in what is built after this commit
---
 gdb/data-directory/Makefile.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 36192c2be137d2af13fbc2d528de05b41d546805

Comments

Tom Tromey April 8, 2024, 6:03 p.m. UTC | #1 
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:

Andrew> Just like we carry mkinstalldirs in the top-level directory, we also
Andrew> carry install-sh, and a version of install-sh which supports the -d
Andrew> flag.

Andrew> And best of all, 'install-sh -d' doesn't appear to print any of the
Andrew> information messages to stdout that mkinstalldirs does, so if we
Andrew> switch to use that, we get a quieter build.

Andrew> There should be no changes in what is built after this commit

Looks good to me.
Approved-By: Tom Tromey <tom@tromey.com>

Tom
Andrew Burgess April 12, 2024, 5:01 p.m. UTC | #2 
Tom Tromey <tom@tromey.com> writes:

>>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
>
> Andrew> Just like we carry mkinstalldirs in the top-level directory, we also
> Andrew> carry install-sh, and a version of install-sh which supports the -d
> Andrew> flag.
>
> Andrew> And best of all, 'install-sh -d' doesn't appear to print any of the
> Andrew> information messages to stdout that mkinstalldirs does, so if we
> Andrew> switch to use that, we get a quieter build.
>
> Andrew> There should be no changes in what is built after this commit
>
> Looks good to me.
> Approved-By: Tom Tromey <tom@tromey.com>

Pushed.

Thanks,
Andrew
diff mbox series

Patch

diff --git a/gdb/data-directory/Makefile.in b/gdb/data-directory/Makefile.in
index 720b983ef6c..ae15c25cb0f 100644
--- a/gdb/data-directory/Makefile.in
+++ b/gdb/data-directory/Makefile.in
@@ -44,7 +44,7 @@  LN_S = @LN_S@
 
 INSTALL = @INSTALL@
 INSTALL_DATA = @INSTALL_DATA@
-INSTALL_DIR = $(SHELL) $(srcdir)/../../mkinstalldirs
+INSTALL_DIR = $(SHELL) $(srcdir)/../../install-sh -d
 
 GDB_DATADIR = @GDB_DATADIR@