From patchwork Mon Apr 8 12:26:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 88172 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C4A733858D32 for ; Mon, 8 Apr 2024 12:27:28 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id AA6423858D20 for ; Mon, 8 Apr 2024 12:27:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AA6423858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AA6423858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712579225; cv=none; b=rMs9OcMmaxCyVS/wqZnuDaLQaiKrd0G/ukeF0r4ydc/ZBPGo6z8j/Et5hKkXUSDnS0HuUnInDQ0EGb4hRhb0ZvbY3h+9aWTvlOR6cjjjOdFndlmufWnWka+dAQmpUi1k0A/FWkg2NyqBALbp4xVaAUN5sHAXQPXlKJdyHP+c2jM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712579225; c=relaxed/simple; bh=4F7bL2V+wbm0wCnFFm63YdQTSGw7BFzWbhrpY/UXGxk=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=xejAdHRwH2dlTxJdU7xy9KB6a2Q033VeGxSQpHo7epBAmoV0TAGBAdRSCY6AO5PWLGDpH4MM8UJvGKQkaX9nAiQwTeEavVMgjlrnJLESCjvldO9PUCEgQA9QiMkPafTBP3bOi1fp88qdo2kStjREbKR9inTuvCm3heYhoQzp8Sc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712579222; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aGbmzo+sPCUa1USoak9Cmf85NUGhjYsg1U1Ks679Rbs=; b=VFUHutMniIOgjfqg3g8tLG80T+meN30+51Brg4YTKQsnfFpedxuGVUZJf175845jkA6arI 2pYOFHgGCA9BJPmXwrGxNPrU9M7wBGahGUx2HkxMV6/TUGVJXTYOzEhsoLr77xlZN45zTp Orof5E4VgBem5i5DnDFmQomyWEf9gtc= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-154-FfaFCvl1Pgaln-TKMAmCvA-1; Mon, 08 Apr 2024 08:27:00 -0400 X-MC-Unique: FfaFCvl1Pgaln-TKMAmCvA-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-515d5dcd75cso3785020e87.1 for ; Mon, 08 Apr 2024 05:27:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712579218; x=1713184018; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aGbmzo+sPCUa1USoak9Cmf85NUGhjYsg1U1Ks679Rbs=; b=EYN1GYCyYiI1MPUOawRdx2vD54eQyCRH50smlVA1ki1PxIABnuIKmBS8SidjK/LJiR D5LDu+v6mG29Dxf0ELC3ZO9UOvqeOVVjNx4DbM92SiJD9gktnZNo/pO675bos1XWcSvs Uu62+wsSszrI3UVtfnhOZVjvHcoaXMEhjWvx+PLEBq3AYEPKJcGmArHEIQIgOievfGyT O15v2+EI4AlZmICE5HiI6QgQ1T/rgmhFJiIBEmPdmb3Tb7NZZseVPnYz91J/y7dy8c2Q CygqoY+IQvTCnvL4OjSdpHGuxUn94mIHPQ598NCrqChp/8V+eN901okMpxOZLHN7rasO gu8A== X-Gm-Message-State: AOJu0YzJ7+R8RsPw/0YQ4ofjQ8bsz2UYMyqDzNKPRSj3da7cyWkIWqvG xub8vBsQpd4/MgfpI2tpTkTWsAZu02tOy1oTV6Ow4olOAm3VFpwIg1E/J8Yuk3Z1LFJ7S1OZwg1 rO6iVoKWX76c+uf/Wds9lMh9wkP7f6OVE8RuKK1DyBrz013pFGIYt5ZTzEYr9Ole8Y2qezhxOqf opybMmJ0dTI80RbyGP/hJipQfCOlfoVj411OZP23EI2rE= X-Received: by 2002:a05:6512:6c9:b0:513:ec32:aa81 with SMTP id u9-20020a05651206c900b00513ec32aa81mr7880609lff.13.1712579218126; Mon, 08 Apr 2024 05:26:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGEQGw0Rr52mm2uTIUQvhOTWttycLqj9+wLuyrMe0pSbNbHz+3xYvKCFnJ51VC3YTY0bJRAEw== X-Received: by 2002:a05:6512:6c9:b0:513:ec32:aa81 with SMTP id u9-20020a05651206c900b00513ec32aa81mr7880590lff.13.1712579217548; Mon, 08 Apr 2024 05:26:57 -0700 (PDT) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id va12-20020a17090711cc00b00a4eeb5ff4ddsm4379736ejb.152.2024.04.08.05.26.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 05:26:57 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH] gdb/data-directory: silence output from mkinstalldirs script Date: Mon, 8 Apr 2024 13:26:55 +0100 Message-Id: <644b3363a3ac88ea06ddab33a8e824d8d445f19d.1712579194.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org After my recent changes the data-directory build now uses silent-rules.mk to reduce the output. One problem that remains was the use of mkinstalldirs by stamp-python and stamp-guile for creating some directories, the mkinstalldirs prints some messages, so we're left with output like this: GEN stamp-python mkdir -p -- ./python/gdb mkdir -p -- ./python/gdb/command mkdir -p -- ./python/gdb/dap mkdir -p -- ./python/gdb/function mkdir -p -- ./python/gdb/printer I was looking at adding a --silent option to the mkinstalldirs script, however, when I took a look at the automake package (which is where mkinstalldirs comes from) it turns out that mkinstalldirs is deprecated, at the advice is to use 'install-sh -d' instead. Just like we carry mkinstalldirs in the top-level directory, we also carry install-sh, and a version of install-sh which supports the -d flag. And best of all, 'install-sh -d' doesn't appear to print any of the information messages to stdout that mkinstalldirs does, so if we switch to use that, we get a quieter build. There should be no changes in what is built after this commit --- gdb/data-directory/Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 36192c2be137d2af13fbc2d528de05b41d546805 diff --git a/gdb/data-directory/Makefile.in b/gdb/data-directory/Makefile.in index 720b983ef6c..ae15c25cb0f 100644 --- a/gdb/data-directory/Makefile.in +++ b/gdb/data-directory/Makefile.in @@ -44,7 +44,7 @@ LN_S = @LN_S@ INSTALL = @INSTALL@ INSTALL_DATA = @INSTALL_DATA@ -INSTALL_DIR = $(SHELL) $(srcdir)/../../mkinstalldirs +INSTALL_DIR = $(SHELL) $(srcdir)/../../install-sh -d GDB_DATADIR = @GDB_DATADIR@