diff mbox series

[PATCHv5,01/11] gdbserver/ipa/x86: remove unneeded declarations

Message ID 451f76b4ea105af2def7e62d78662a647e809e73.1714143669.git.aburgess@redhat.com
State New
Headers
Series x86/Linux Target Description Changes |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Testing passed

Commit Message

Andrew Burgess April 26, 2024, 3:01 p.m. UTC 
  Spotted some declarations in gdbserver/linux-amd64-ipa.cc that are no
longer needed.  These are:

  1. 'init_registers_amd64_linux' - the comment claims this function
  is auto generated, but I don't believe that this is still the case.
  Also the function is not used in this file,

  2. 'tdesc_amd64_linux' - this variable doesn't seem to exist any
  more, I suspect this was renamed to 'tdesc_amd64_linux_no_xml', but
  neither are used in this file, so lets remove the declaration.

The amd64 in-process-agent still builds fine after this commit.

There should be no user visible changes after this commit.
---
 gdbserver/linux-amd64-ipa.cc | 4 ----
 1 file changed, 4 deletions(-)

Comments

Willgerodt, Felix April 29, 2024, 2:34 p.m. UTC | #1 
> -----Original Message-----
> From: Andrew Burgess <aburgess@redhat.com>
> Sent: Freitag, 26. April 2024 17:02
> To: gdb-patches@sourceware.org
> Cc: Andrew Burgess <aburgess@redhat.com>; Willgerodt, Felix
> <felix.willgerodt@intel.com>; John Baldwin <jhb@FreeBSD.org>
> Subject: [PATCHv5 01/11] gdbserver/ipa/x86: remove unneeded declarations
> 
> Spotted some declarations in gdbserver/linux-amd64-ipa.cc that are no
> longer needed.  These are:
> 
>   1. 'init_registers_amd64_linux' - the comment claims this function
>   is auto generated, but I don't believe that this is still the case.
>   Also the function is not used in this file,
> 
>   2. 'tdesc_amd64_linux' - this variable doesn't seem to exist any
>   more, I suspect this was renamed to 'tdesc_amd64_linux_no_xml', but
>   neither are used in this file, so lets remove the declaration.
> 
> The amd64 in-process-agent still builds fine after this commit.
> 
> There should be no user visible changes after this commit.
> ---
>  gdbserver/linux-amd64-ipa.cc | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/gdbserver/linux-amd64-ipa.cc b/gdbserver/linux-amd64-ipa.cc
> index 13c8a5bb360..a6346750f49 100644
> --- a/gdbserver/linux-amd64-ipa.cc
> +++ b/gdbserver/linux-amd64-ipa.cc
> @@ -23,10 +23,6 @@
>  #include "linux-x86-tdesc.h"
>  #include "gdbsupport/x86-xstate.h"
> 
> -/* Defined in auto-generated file amd64-linux.c.  */
> -void init_registers_amd64_linux (void);
> -extern const struct target_desc *tdesc_amd64_linux;
> -
>  /* fast tracepoints collect registers.  */
> 
>  #define FT_CR_RIP 0
> --
> 2.25.4

Approved-By: Felix Willgerodt <felix.willgerodt@intel.com>

Thanks,
Felix
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
Andrew Burgess May 7, 2024, 3:05 p.m. UTC | #2 
"Willgerodt, Felix" <felix.willgerodt@intel.com> writes:

>> -----Original Message-----
>> From: Andrew Burgess <aburgess@redhat.com>
>> Sent: Freitag, 26. April 2024 17:02
>> To: gdb-patches@sourceware.org
>> Cc: Andrew Burgess <aburgess@redhat.com>; Willgerodt, Felix
>> <felix.willgerodt@intel.com>; John Baldwin <jhb@FreeBSD.org>
>> Subject: [PATCHv5 01/11] gdbserver/ipa/x86: remove unneeded declarations
>> 
>> Spotted some declarations in gdbserver/linux-amd64-ipa.cc that are no
>> longer needed.  These are:
>> 
>>   1. 'init_registers_amd64_linux' - the comment claims this function
>>   is auto generated, but I don't believe that this is still the case.
>>   Also the function is not used in this file,
>> 
>>   2. 'tdesc_amd64_linux' - this variable doesn't seem to exist any
>>   more, I suspect this was renamed to 'tdesc_amd64_linux_no_xml', but
>>   neither are used in this file, so lets remove the declaration.
>> 
>> The amd64 in-process-agent still builds fine after this commit.
>> 
>> There should be no user visible changes after this commit.
>> ---
>>  gdbserver/linux-amd64-ipa.cc | 4 ----
>>  1 file changed, 4 deletions(-)
>> 
>> diff --git a/gdbserver/linux-amd64-ipa.cc b/gdbserver/linux-amd64-ipa.cc
>> index 13c8a5bb360..a6346750f49 100644
>> --- a/gdbserver/linux-amd64-ipa.cc
>> +++ b/gdbserver/linux-amd64-ipa.cc
>> @@ -23,10 +23,6 @@
>>  #include "linux-x86-tdesc.h"
>>  #include "gdbsupport/x86-xstate.h"
>> 
>> -/* Defined in auto-generated file amd64-linux.c.  */
>> -void init_registers_amd64_linux (void);
>> -extern const struct target_desc *tdesc_amd64_linux;
>> -
>>  /* fast tracepoints collect registers.  */
>> 
>>  #define FT_CR_RIP 0
>> --
>> 2.25.4
>
> Approved-By: Felix Willgerodt <felix.willgerodt@intel.com>

Given this patch is pretty disjoint from the rest of the series I've
gone ahead and pushed just this patch.

Thanks,
Andrew
Willgerodt, Felix May 8, 2024, 7:49 a.m. UTC | #3 
> -----Original Message-----
> From: Andrew Burgess <aburgess@redhat.com>
> Sent: Dienstag, 7. Mai 2024 17:05
> To: Willgerodt, Felix <felix.willgerodt@intel.com>; gdb-patches@sourceware.org
> Cc: John Baldwin <jhb@FreeBSD.org>
> Subject: RE: [PATCHv5 01/11] gdbserver/ipa/x86: remove unneeded declarations
> 
> "Willgerodt, Felix" <felix.willgerodt@intel.com> writes:
> 
> >> -----Original Message-----
> >> From: Andrew Burgess <aburgess@redhat.com>
> >> Sent: Freitag, 26. April 2024 17:02
> >> To: gdb-patches@sourceware.org
> >> Cc: Andrew Burgess <aburgess@redhat.com>; Willgerodt, Felix
> >> <felix.willgerodt@intel.com>; John Baldwin <jhb@FreeBSD.org>
> >> Subject: [PATCHv5 01/11] gdbserver/ipa/x86: remove unneeded declarations
> >>
> >> Spotted some declarations in gdbserver/linux-amd64-ipa.cc that are no
> >> longer needed.  These are:
> >>
> >>   1. 'init_registers_amd64_linux' - the comment claims this function
> >>   is auto generated, but I don't believe that this is still the case.
> >>   Also the function is not used in this file,
> >>
> >>   2. 'tdesc_amd64_linux' - this variable doesn't seem to exist any
> >>   more, I suspect this was renamed to 'tdesc_amd64_linux_no_xml', but
> >>   neither are used in this file, so lets remove the declaration.
> >>
> >> The amd64 in-process-agent still builds fine after this commit.
> >>
> >> There should be no user visible changes after this commit.
> >> ---
> >>  gdbserver/linux-amd64-ipa.cc | 4 ----
> >>  1 file changed, 4 deletions(-)
> >>
> >> diff --git a/gdbserver/linux-amd64-ipa.cc b/gdbserver/linux-amd64-ipa.cc
> >> index 13c8a5bb360..a6346750f49 100644
> >> --- a/gdbserver/linux-amd64-ipa.cc
> >> +++ b/gdbserver/linux-amd64-ipa.cc
> >> @@ -23,10 +23,6 @@
> >>  #include "linux-x86-tdesc.h"
> >>  #include "gdbsupport/x86-xstate.h"
> >>
> >> -/* Defined in auto-generated file amd64-linux.c.  */
> >> -void init_registers_amd64_linux (void);
> >> -extern const struct target_desc *tdesc_amd64_linux;
> >> -
> >>  /* fast tracepoints collect registers.  */
> >>
> >>  #define FT_CR_RIP 0
> >> --
> >> 2.25.4
> >
> > Approved-By: Felix Willgerodt <felix.willgerodt@intel.com>
> 
> Given this patch is pretty disjoint from the rest of the series I've
> gone ahead and pushed just this patch.
> 
> Thanks,
> Andrew

Thanks! That is a good idea. Same for the others that you pushed.

Felix
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
diff mbox series

Patch

diff --git a/gdbserver/linux-amd64-ipa.cc b/gdbserver/linux-amd64-ipa.cc
index 13c8a5bb360..a6346750f49 100644
--- a/gdbserver/linux-amd64-ipa.cc
+++ b/gdbserver/linux-amd64-ipa.cc
@@ -23,10 +23,6 @@ 
 #include "linux-x86-tdesc.h"
 #include "gdbsupport/x86-xstate.h"
 
-/* Defined in auto-generated file amd64-linux.c.  */
-void init_registers_amd64_linux (void);
-extern const struct target_desc *tdesc_amd64_linux;
-
 /* fast tracepoints collect registers.  */
 
 #define FT_CR_RIP 0