diff mbox series

Remove fflush call from tui_refresh_cmd_win

Message ID 20240426163321.1129687-1-tom@tromey.com
State New
Headers
Series Remove fflush call from tui_refresh_cmd_win |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Testing passed

Commit Message

Tom Tromey April 26, 2024, 4:33 p.m. UTC 
  tui_refresh_cmd_win calls fflush, but there's a comment explaining
that the reason for the call is unknown.  This patch removes the call.
I don't think it can be useful, since gdb doesn't generally use stdout
in this way -- only through ui_file.
---
 gdb/tui/tui-command.c | 5 -----
 1 file changed, 5 deletions(-)
diff mbox series

Patch

diff --git a/gdb/tui/tui-command.c b/gdb/tui/tui-command.c
index 59e595525b0..b0ae8f39e0e 100644
--- a/gdb/tui/tui-command.c
+++ b/gdb/tui/tui-command.c
@@ -64,9 +64,4 @@  tui_refresh_cmd_win (void)
   WINDOW *w = TUI_CMD_WIN->handle.get ();
 
   tui_wrefresh (w);
-
-  /* FIXME: It's not clear why this is here.
-     It was present in the original tui_puts code and is kept in order to
-     not introduce some subtle breakage.  */
-  fflush (stdout);
 }