From patchwork Fri Apr 26 16:33:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 89056 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7BDB3384B013 for ; Fri, 26 Apr 2024 16:34:00 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 993393858C42 for ; Fri, 26 Apr 2024 16:33:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 993393858C42 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 993393858C42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714149221; cv=none; b=cO3Q1dQOAOWwG+rfWpbB+O8ApHgsj3hbTxcbnyhu/LhP7tjf8fC1h9XoVAETtm7rgQGtTzzsitTsecQ4JnVvEQIUrtXuEIi/4Ecv3gb5kM+rT6kDRw64Mp8QyF+DbdxdH2gsLrKGqFFhRNonNHGE+WYqr8z7JDdv76xtX2kU0gw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714149221; c=relaxed/simple; bh=cjEddP2IM7vOP8sLadNH7Y8N707TnYjkwSNdzLotDFw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=TVVRIo+aREs77TF7E2gMIIdlePKKRGkzz+4k5nig2ujDju2/Z7DcFk3Xbzmuzn/0K4S8LpYpoM6aGgYBEmxIWvII+fROZezGDDeiKuffBzSCaGZbQ1cV/Sm6iZSz56gNy1+riaJcnKCYZO1WR5LkSa8e7Uv1fVwxcInl8WmVqUc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6010a.ext.cloudfilter.net ([10.0.30.248]) by cmsmtp with ESMTPS id 0EF8sc5ioQr4S0OVwsi0HE; Fri, 26 Apr 2024 16:33:32 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 0OVvsaIUHF4Xp0OVvsko3a; Fri, 26 Apr 2024 16:33:31 +0000 X-Authority-Analysis: v=2.4 cv=UpZlNfwB c=1 sm=1 tr=0 ts=662bd75b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=raytVjVEu-sA:10 a=Qbun_eYptAEA:10 a=ZUqkfRRQqFguin276LQA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Fdb0Yk67L1xYBCaO7Jl9S/5eONWmbucRNgKNW+jpazA=; b=fvm9HZpixFrK8ig6DqQYCGWTPD kXatWDGprnY1+qE3i8kU3Nx6/+BJtLEp5hhAy0jAh3NrDemGUV3CY1Fh3y5yM8TMuFF+Qi3pLibjt 9RptB8gM5RsFpt5ip2OmSkaMV; Received: from 97-122-86-252.hlrn.qwest.net ([97.122.86.252]:52128 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1s0OVv-002qMF-02; Fri, 26 Apr 2024 10:33:31 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Remove fflush call from tui_refresh_cmd_win Date: Fri, 26 Apr 2024 10:33:21 -0600 Message-ID: <20240426163321.1129687-1-tom@tromey.com> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.86.252 X-Source-L: No X-Exim-ID: 1s0OVv-002qMF-02 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-86-252.hlrn.qwest.net (localhost.localdomain) [97.122.86.252]:52128 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfPpGcvXqcWA1JMilmOlWPLzZS1kvmnRn7A+SozYXa/0EmYs8Dk4rZcyA88LanqrMi0Q3jHYatROd2Q0DtvK1nW6oYQMO+KZs1O5LnomangiqgWmdtpKR RmURYtlRW8Oy4r4G+mYf3A230fYBPQzvmqPMU3m0ScRoRqOPaKBXreJKlmyDLWyLeFkBS8IkE9Hn59WgZU1FRSj9HXAJqzXuD7Q= X-Spam-Status: No, score=-3021.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org tui_refresh_cmd_win calls fflush, but there's a comment explaining that the reason for the call is unknown. This patch removes the call. I don't think it can be useful, since gdb doesn't generally use stdout in this way -- only through ui_file. --- gdb/tui/tui-command.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/gdb/tui/tui-command.c b/gdb/tui/tui-command.c index 59e595525b0..b0ae8f39e0e 100644 --- a/gdb/tui/tui-command.c +++ b/gdb/tui/tui-command.c @@ -64,9 +64,4 @@ tui_refresh_cmd_win (void) WINDOW *w = TUI_CMD_WIN->handle.get (); tui_wrefresh (w); - - /* FIXME: It's not clear why this is here. - It was present in the original tui_puts code and is kept in order to - not introduce some subtle breakage. */ - fflush (stdout); }