diff mbox series

[gdb/testsuite] Add missing include in gdb.base/rtld-step.exp

Message ID 20240327162329.2242-1-tdevries@suse.de
State Committed
Headers
Series [gdb/testsuite] Add missing include in gdb.base/rtld-step.exp |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 fail Patch failed to apply
linaro-tcwg-bot/tcwg_gdb_build--master-arm fail Patch failed to apply

Commit Message

Tom de Vries March 27, 2024, 4:23 p.m. UTC 
  On fedora rawhide, with test-case gdb.base/rtld-step.exp I get:
...
static-pie-static-libc.c: In function '_start':^M
static-pie-static-libc.c:1:22: error: \
  implicit declaration of function '_exit' [-Wimplicit-function-declaration]^M
    1 | void _start (void) { _exit (0); }^M
      |                      ^~~~~^M
compiler exited with status 1
  ...
UNTESTED: gdb.base/rtld-step.exp: failed to compile \
  (-static-pie not supported or static libc missing)
...

Fix this by adding the missing include.

Tested on aarch64-linux.
---
 gdb/testsuite/gdb.base/rtld-step.exp | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)


base-commit: 6f769dfd831b186258e205bd2ae0d39ae9c5c826

Comments

Kevin Buettner March 28, 2024, 2:24 a.m. UTC | #1 
Hi Tom,

On Wed, 27 Mar 2024 17:23:29 +0100
Tom de Vries <tdevries@suse.de> wrote:

> On fedora rawhide, with test-case gdb.base/rtld-step.exp I get:
> ...
> static-pie-static-libc.c: In function '_start':^M
> static-pie-static-libc.c:1:22: error: \
>   implicit declaration of function '_exit' [-Wimplicit-function-declaration]^M
>     1 | void _start (void) { _exit (0); }^M
>       |                      ^~~~~^M
> compiler exited with status 1
>   ...
> UNTESTED: gdb.base/rtld-step.exp: failed to compile \
>   (-static-pie not supported or static libc missing)
> ...
> 
> Fix this by adding the missing include.
> 
> Tested on aarch64-linux.

Thanks for fixing this.

Approved-by: Kevin Buettner <kevinb@redhat.com>
John Baldwin March 28, 2024, 5:26 p.m. UTC | #2 
On 3/27/24 12:23 PM, Tom de Vries wrote:
> On fedora rawhide, with test-case gdb.base/rtld-step.exp I get:
> ...
> static-pie-static-libc.c: In function '_start':^M
> static-pie-static-libc.c:1:22: error: \
>    implicit declaration of function '_exit' [-Wimplicit-function-declaration]^M
>      1 | void _start (void) { _exit (0); }^M
>        |                      ^~~~~^M
> compiler exited with status 1
>    ...
> UNTESTED: gdb.base/rtld-step.exp: failed to compile \
>    (-static-pie not supported or static libc missing)
> ...
> 
> Fix this by adding the missing include.
> 
> Tested on aarch64-linux.

Approved-By: John Baldwin <jhb@FreeBSD.org>
Tom de Vries March 29, 2024, 10:48 a.m. UTC | #3 
On 3/28/24 18:26, John Baldwin wrote:
> On 3/27/24 12:23 PM, Tom de Vries wrote:
>> On fedora rawhide, with test-case gdb.base/rtld-step.exp I get:
>> ...
>> static-pie-static-libc.c: In function '_start':^M
>> static-pie-static-libc.c:1:22: error: \
>>    implicit declaration of function '_exit' 
>> [-Wimplicit-function-declaration]^M
>>      1 | void _start (void) { _exit (0); }^M
>>        |                      ^~~~~^M
>> compiler exited with status 1
>>    ...
>> UNTESTED: gdb.base/rtld-step.exp: failed to compile \
>>    (-static-pie not supported or static libc missing)
>> ...
>>
>> Fix this by adding the missing include.
>>
>> Tested on aarch64-linux.
> 
> Approved-By: John Baldwin <jhb@FreeBSD.org>
> 

Hi John,

thanks for the review.

I had already committed after the approval of Kevin, so unfortunately 
this was committed without your approved-by tag.

Thanks,
- Tom
diff mbox series

Patch

diff --git a/gdb/testsuite/gdb.base/rtld-step.exp b/gdb/testsuite/gdb.base/rtld-step.exp
index 53725833aa1..198542886cc 100644
--- a/gdb/testsuite/gdb.base/rtld-step.exp
+++ b/gdb/testsuite/gdb.base/rtld-step.exp
@@ -86,7 +86,10 @@  set rtld_flags [list debug additional_flags=[list -static-pie -fPIE \
 						  -nostdlib -static -lc]]
 
 if { ![gdb_can_simple_compile static-pie-static-libc \
-	   "void _start (void) { _exit (0); }" \
+	   {
+	       #include <unistd.h>
+	       void _start (void) { _exit (0); }
+	   } \
 	   executable $rtld_flags] } {
     set reason "-static-pie not supported or static libc missing"
     untested "failed to compile ($reason)"