From patchwork Wed Mar 27 16:23:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 87709 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C0A853858D34 for ; Wed, 27 Mar 2024 16:23:56 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 9854B3858D34 for ; Wed, 27 Mar 2024 16:23:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9854B3858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9854B3858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711556613; cv=none; b=f1cLnZ632vHj89HH6dNvfAV+A7sCcFSNn28Qcj2YsZ6B5z1cSNk2eGUPk8bqo4dUumoxzLHTibI1/cordESYIMlYxJ03XNmFI/IAqTHNcCpVkX/T7iWimrO31We/qj1Rr5MHmAEAQOrJIYdmx944tNDWWhRXcJih7gWCIE673yo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711556613; c=relaxed/simple; bh=TYNaxDbaLAdoLv25VqbxzrOY2ykL6o2r8GyDZi0LrOI=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-Id:MIME-Version; b=mwOVD/rDZd8DjbTCF+I5UbAQYBiXCz81UirJsGSNXVEI2HzwJYORBbm55XtQyiSfmXLy/XiLGDT+4/b36eh5ix3VacJUDHrXjiD69RfEtQ8740LpLIairAkMjAxXq62HDz+Q4I7PVBiFzXLvUL7FYc1Xdve+fOLTaNjN69PU7sc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A9DDD38C1B for ; Wed, 27 Mar 2024 16:23:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1711556610; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=FlJCtRk3e7yN0vVSgJkzI8qTB7K2McXvwyb/5pyp4ko=; b=neXYkRcsUGckZdBak+2LP/edqVQ0mO1FJ7zKF3k8MHAk6CIlVK1822NPwKXNXNcvWB+22G g45J6cd4gbR+i4LstAjk8B26kcqtK5n1c/iC5lfUTiOOwmyrxm495CZfrDG2+Pn66wV3qT S/cqW/+hSW7pZpWBOleeIDTnixzAAws= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1711556610; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=FlJCtRk3e7yN0vVSgJkzI8qTB7K2McXvwyb/5pyp4ko=; b=yP0aCIkP/7ftn5KA6NUlYMm9kXQuuJ+JCUWIe0bkJZuFJkBQo8igdrAPqnu8s4Xbctl9+i nJHfeRIT+wYlwWCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1711556610; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=FlJCtRk3e7yN0vVSgJkzI8qTB7K2McXvwyb/5pyp4ko=; b=neXYkRcsUGckZdBak+2LP/edqVQ0mO1FJ7zKF3k8MHAk6CIlVK1822NPwKXNXNcvWB+22G g45J6cd4gbR+i4LstAjk8B26kcqtK5n1c/iC5lfUTiOOwmyrxm495CZfrDG2+Pn66wV3qT S/cqW/+hSW7pZpWBOleeIDTnixzAAws= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1711556610; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=FlJCtRk3e7yN0vVSgJkzI8qTB7K2McXvwyb/5pyp4ko=; b=yP0aCIkP/7ftn5KA6NUlYMm9kXQuuJ+JCUWIe0bkJZuFJkBQo8igdrAPqnu8s4Xbctl9+i nJHfeRIT+wYlwWCA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 948A413AB3 for ; Wed, 27 Mar 2024 16:23:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id k83UIgJIBGaMeAAAn2gu4w (envelope-from ) for ; Wed, 27 Mar 2024 16:23:30 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [gdb/testsuite] Add missing include in gdb.base/rtld-step.exp Date: Wed, 27 Mar 2024 17:23:29 +0100 Message-Id: <20240327162329.2242-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-Spam-Level: Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=neXYkRcs; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=yP0aCIkP X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-1.50 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:98:from]; R_MISSING_CHARSET(2.50)[]; TO_DN_NONE(0.00)[]; BROKEN_CONTENT_TYPE(1.50)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-2.99)[99.95%]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_MED(-2.00)[suse.de:dkim]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; RCPT_COUNT_ONE(0.00)[1]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MID_CONTAINS_FROM(1.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[] X-Spam-Score: -1.50 X-Rspamd-Queue-Id: A9DDD38C1B X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org On fedora rawhide, with test-case gdb.base/rtld-step.exp I get: ... static-pie-static-libc.c: In function '_start':^M static-pie-static-libc.c:1:22: error: \ implicit declaration of function '_exit' [-Wimplicit-function-declaration]^M 1 | void _start (void) { _exit (0); }^M | ^~~~~^M compiler exited with status 1 ... UNTESTED: gdb.base/rtld-step.exp: failed to compile \ (-static-pie not supported or static libc missing) ... Fix this by adding the missing include. Tested on aarch64-linux. --- gdb/testsuite/gdb.base/rtld-step.exp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) base-commit: 6f769dfd831b186258e205bd2ae0d39ae9c5c826 diff --git a/gdb/testsuite/gdb.base/rtld-step.exp b/gdb/testsuite/gdb.base/rtld-step.exp index 53725833aa1..198542886cc 100644 --- a/gdb/testsuite/gdb.base/rtld-step.exp +++ b/gdb/testsuite/gdb.base/rtld-step.exp @@ -86,7 +86,10 @@ set rtld_flags [list debug additional_flags=[list -static-pie -fPIE \ -nostdlib -static -lc]] if { ![gdb_can_simple_compile static-pie-static-libc \ - "void _start (void) { _exit (0); }" \ + { + #include + void _start (void) { _exit (0); } + } \ executable $rtld_flags] } { set reason "-static-pie not supported or static libc missing" untested "failed to compile ($reason)"