[v3,3/5] kfail a FinishBreakpoint test
Checks
Context |
Check |
Description |
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 |
success
|
Testing passed
|
linaro-tcwg-bot/tcwg_gdb_build--master-arm |
success
|
Testing passed
|
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 |
success
|
Testing passed
|
linaro-tcwg-bot/tcwg_gdb_check--master-arm |
success
|
Testing passed
|
Commit Message
I noticed that one particular FinishBreakpoint test is only passing by
accident -- the regexp is too broad and matches an error message.
This patch changes the test to actually check what it claims to check;
and then kfails the test because it doesn't work. I've taken this
approach because this failure is only incidental to this series.
Meanwhile I've filed a bug that I will leave open after this lands.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31391
---
gdb/testsuite/gdb.python/py-finish-breakpoint.exp | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
Comments
On 2/20/24 20:46, Tom Tromey wrote:
> I noticed that one particular FinishBreakpoint test is only passing by
> accident -- the regexp is too broad and matches an error message.
>
> This patch changes the test to actually check what it claims to check;
> and then kfails the test because it doesn't work. I've taken this
> approach because this failure is only incidental to this series.
> Meanwhile I've filed a bug that I will leave open after this lands.
>
I don't think there's a problem with gdb, so there's no need for the kfail.
I've proposed a patch here (
https://sourceware.org/pipermail/gdb-patches/2024-February/206853.html )
that fixes the test-case.
Thanks,
- Tom
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31391
> ---
> gdb/testsuite/gdb.python/py-finish-breakpoint.exp | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/gdb.python/py-finish-breakpoint.exp b/gdb/testsuite/gdb.python/py-finish-breakpoint.exp
> index 45e2630337f..6b72ddb2186 100644
> --- a/gdb/testsuite/gdb.python/py-finish-breakpoint.exp
> +++ b/gdb/testsuite/gdb.python/py-finish-breakpoint.exp
> @@ -73,7 +73,11 @@ with_test_prefix "normal conditions" {
> "check MyFinishBreakpoint hit"
> gdb_test "python print (finishbp.return_value)" "-5.*" "check return_value"
>
> - gdb_test "python print (finishbp_default.hit_count)" "1.*" "check finishBP on default frame has been hit"
> + # This test does not work and the result being checked for here
> + # used to match by accident. See PR python/31391.
> + setup_kfail "python/31391" *-*-*
> + gdb_test "python print ('HC=' + str(finishbp_default.hit_count))" "HC=1" \
> + "check finishBP on default frame has been hit"
> gdb_test "python print (finishbp.is_valid())" "False.*"\
> "ensure that finish bp is invalid afer normal hit"
>
>
@@ -73,7 +73,11 @@ with_test_prefix "normal conditions" {
"check MyFinishBreakpoint hit"
gdb_test "python print (finishbp.return_value)" "-5.*" "check return_value"
- gdb_test "python print (finishbp_default.hit_count)" "1.*" "check finishBP on default frame has been hit"
+ # This test does not work and the result being checked for here
+ # used to match by accident. See PR python/31391.
+ setup_kfail "python/31391" *-*-*
+ gdb_test "python print ('HC=' + str(finishbp_default.hit_count))" "HC=1" \
+ "check finishBP on default frame has been hit"
gdb_test "python print (finishbp.is_valid())" "False.*"\
"ensure that finish bp is invalid afer normal hit"