From patchwork Tue Feb 20 19:46:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 86079 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 150D83858C78 for ; Tue, 20 Feb 2024 19:48:13 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by sourceware.org (Postfix) with ESMTPS id 9DFA33858D28 for ; Tue, 20 Feb 2024 19:46:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9DFA33858D28 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9DFA33858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708458378; cv=none; b=oMd5gvvbznG4oLNmgbl5eX4M2IRUtOlKRQGEU2nuaEy5sgbvrQp3RqJ39b1bME6UAFdUPqAyKeTJr8PinYE2iH4AYHDcbSm+ihFbFseWTPqE9TCa9R9CGcLsxBG5NdRh1W1qDFgNi7wKPpy3KIA0CNN9k264ltzudk+uGDgoJ9E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708458378; c=relaxed/simple; bh=IVLDgjYF6AO7UyLVgTsCCLMgseMbqKPR4J2zuG+N9ws=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=SJ/hvYDDpx7mBhCO34dTT3ypTGmmZ+LtkX4P6r1MBvmL5gh1msKuqqFI9l3nSAldpfMCHZZFmecM3l7YvenA6g80sOjBluAOQjI7RQ4ZWk92n+YEaPgiyMGbu79ZnbQGJMiza9FHY7/OzOErJg66BQbvx4JWDHg8GI03CUEVLPI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd35.google.com with SMTP id ca18e2360f4ac-7bfd527d443so178120339f.3 for ; Tue, 20 Feb 2024 11:46:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1708458376; x=1709063176; darn=sourceware.org; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=W08w9mDsW/if1berqk2+vmt/mY1riIPKEc3f7BmYuMQ=; b=iA+LEUP44M0lck4nmVjkm2Oa5jDwXa3QcaGoYLQh4VhyFp3806b1wgvifhIJRzWYdC Mx1qH2MlwSmlYgJL3QWtu+szP1BBNC9VnUlWlCfw2LV0rWUUs8MWtaNV/OAgEz/URjWj UabkeqhvoQMZkeKTAepRBKfDELmLOE/C6d4Y3Bcg4TuHGiqiyLB2eUN+zd/t87Jgyczi JVMBm8ek4scP8RvXT+JRO1JdisC866iIzQzucXC1+OGcGtfCh4teUhADYJFziZs8A8D9 GTCUhTHwQlE/HEYacXbvhyKonaw8a6ZJkp0xqievgg4dKyHyKek2r1TtXfnUaqipgnlx 5kNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708458376; x=1709063176; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W08w9mDsW/if1berqk2+vmt/mY1riIPKEc3f7BmYuMQ=; b=FmK69SWf+2w7ExstTBEBGNUKGIMP9qbuMjeXaOdrbT2UO5D7hZF9I8dZxBTyZLfWQW hTU4yW7Qw7UPG+85ljR2Oa+rTyJCq7VUW149PyrNbnLA5TRK/LGRtSAHxQvtMHhMV7IL sWcn4XzuBttHwv5u9hNUEYR+wK4ME9uLWgIZ80d2qViQPWLI009tmP9Cfq+yoF8vrrot TtzkR+S9ZMuJZpNt4DBJLpUpHBDJyNJmaZGTgssheLkRoJw7RmTrxMkGsO3Dx2V1qIb1 49IoY9flFHbc/6/eBU/rKUGDIOFl2pw0UwTXlqwWhFVktFUpxMicr+XJAlYMaT7UnzpE +upQ== X-Gm-Message-State: AOJu0Ywi+q2fXdVwCHt416aRIQ2mgwIl2vDqzTy8AyPgZueeZlU3BkG0 /8eQZUS1ewJJpmq+CZ/3Sl5gWxjzIRGr/vWWp3uuh0YJcWvFVbVzDDS/cMTu3nPPlTu1fxYVo74 = X-Google-Smtp-Source: AGHT+IFiI4I/HHOSZ3mvYKm5daX+ORZNmOuGq4y4ERPoON8qSRBVrMYzI/dVFjooOTmoAD//0nYQsg== X-Received: by 2002:a05:6602:4b01:b0:7c4:82b2:2f51 with SMTP id eo1-20020a0566024b0100b007c482b22f51mr17339175iob.21.1708458375825; Tue, 20 Feb 2024 11:46:15 -0800 (PST) Received: from localhost.localdomain (71-211-170-195.hlrn.qwest.net. [71.211.170.195]) by smtp.gmail.com with ESMTPSA id q10-20020a02c8ca000000b00474284a0228sm1261811jao.61.2024.02.20.11.46.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 11:46:15 -0800 (PST) From: Tom Tromey Date: Tue, 20 Feb 2024 12:46:14 -0700 Subject: [PATCH v3 3/5] kfail a FinishBreakpoint test MIME-Version: 1.0 Message-Id: <20240220-py-simple-exc-v3-3-a2825caa4b74@adacore.com> References: <20240220-py-simple-exc-v3-0-a2825caa4b74@adacore.com> In-Reply-To: <20240220-py-simple-exc-v3-0-a2825caa4b74@adacore.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org I noticed that one particular FinishBreakpoint test is only passing by accident -- the regexp is too broad and matches an error message. This patch changes the test to actually check what it claims to check; and then kfails the test because it doesn't work. I've taken this approach because this failure is only incidental to this series. Meanwhile I've filed a bug that I will leave open after this lands. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31391 --- gdb/testsuite/gdb.python/py-finish-breakpoint.exp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.python/py-finish-breakpoint.exp b/gdb/testsuite/gdb.python/py-finish-breakpoint.exp index 45e2630337f..6b72ddb2186 100644 --- a/gdb/testsuite/gdb.python/py-finish-breakpoint.exp +++ b/gdb/testsuite/gdb.python/py-finish-breakpoint.exp @@ -73,7 +73,11 @@ with_test_prefix "normal conditions" { "check MyFinishBreakpoint hit" gdb_test "python print (finishbp.return_value)" "-5.*" "check return_value" - gdb_test "python print (finishbp_default.hit_count)" "1.*" "check finishBP on default frame has been hit" + # This test does not work and the result being checked for here + # used to match by accident. See PR python/31391. + setup_kfail "python/31391" *-*-* + gdb_test "python print ('HC=' + str(finishbp_default.hit_count))" "HC=1" \ + "check finishBP on default frame has been hit" gdb_test "python print (finishbp.is_valid())" "False.*"\ "ensure that finish bp is invalid afer normal hit"