gdb: remove some unnecessary frame_info_ptr resets
Checks
Commit Message
This code was probably needed before we had reinflatable
frame_info_ptrs, it's not necessary anymore.
Change-Id: I5474c6081ee1e39624c9266b05dbe01351a130b5
---
gdb/arm-linux-tdep.c | 3 ---
gdb/elfread.c | 2 --
gdb/infcall.c | 3 ---
gdb/infcmd.c | 3 ---
gdb/infrun.c | 3 ---
gdb/stack.c | 3 ---
6 files changed, 17 deletions(-)
base-commit: 249e54204b13f9acdd5fbca355fed305e8595f31
Comments
>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
Simon> This code was probably needed before we had reinflatable
Simon> frame_info_ptrs, it's not necessary anymore.
Thank you.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
On 1/31/24 15:42, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
>
> Simon> This code was probably needed before we had reinflatable
> Simon> frame_info_ptrs, it's not necessary anymore.
>
> Thank you.
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Tom
Thanks, pushed.
Simon
@@ -1047,9 +1047,6 @@ arm_linux_copy_svc (struct gdbarch *gdbarch, struct regcache *regs,
= set_momentary_breakpoint (gdbarch, sal, get_frame_id (frame),
bp_step_resume).release ();
- /* set_momentary_breakpoint invalidates FRAME. */
- frame = NULL;
-
/* We need to make sure we actually insert the momentary
breakpoint set above. */
insert_breakpoints ();
@@ -989,8 +989,6 @@ elf_gnu_ifunc_resolver_stop (code_breakpoint *b)
prev_frame_id,
bp_gnu_ifunc_resolver_return).release ();
- /* set_momentary_breakpoint invalidates PREV_FRAME. */
- prev_frame = NULL;
/* Add new b_return to the ring list b->related_breakpoint. */
gdb_assert (b_return->related_breakpoint == b_return);
@@ -1300,9 +1300,6 @@ call_function_by_hand_dummy (struct value *function,
= set_momentary_breakpoint (gdbarch, sal,
dummy_id, bp_call_dummy).release ();
- /* set_momentary_breakpoint invalidates FRAME. */
- frame = NULL;
-
bpt->disposition = disp_del;
gdb_assert (bpt->related_breakpoint == bpt);
@@ -1757,9 +1757,6 @@ finish_forward (struct finish_command_fsm *sm, frame_info_ptr frame)
get_stack_frame_id (frame),
bp_finish);
- /* set_momentary_breakpoint invalidates FRAME. */
- frame = nullptr;
-
set_longjmp_breakpoint (tp, frame_id);
/* We want to print return value, please... */
@@ -8848,9 +8848,6 @@ insert_exception_resume_breakpoint (struct thread_info *tp,
handler,
bp_exception_resume).release ();
- /* set_momentary_breakpoint_at_pc invalidates FRAME. */
- frame = nullptr;
-
tp->control.exception_resume_breakpoint = bp;
}
}
@@ -2307,9 +2307,6 @@ print_variable_and_value_data::operator() (const char *print_name,
print_variable_and_value (print_name, sym, frame, stream, num_tabs);
- /* print_variable_and_value invalidates FRAME. */
- frame = NULL;
-
values_printed = 1;
}