From patchwork Wed Jan 31 15:54:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 85096 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C30B038582A3 for ; Wed, 31 Jan 2024 15:54:38 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id DA12F3858C29 for ; Wed, 31 Jan 2024 15:54:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DA12F3858C29 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DA12F3858C29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706716455; cv=none; b=Pl3TP5mOKagt3xtKqugVjuo3cY7JdLMvpV9dnXtcXC6n7T/h9t+eMTXxVAVjsuZBQgFy4Y2NZ6oCm3pR92jtUf66LsP9FpmgEKG/dHysJSEj4iVREVgkCI7mjIS060zeecJhcast+zq8FCn1zIb7VjQO/kqR043JD24nOu/fxkg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706716455; c=relaxed/simple; bh=4F9EcOTJJF/Xe7H73n3xHoeNWCv2HIHqL/Uez1lFfrg=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=B50kEy6jIiCbLDv8bS52ED9eKJI6GBXUQ6izgY9MAR90pLtYgigaQ8kpyJB5vRIpqVzWKb0nwsUdragmxjK3xaoJQwuuWuxlp5Yh1E0ek1kvmrnwC37ZZRcUzEowdqI5PeuwZ/ekwStxmTD8WOb+FjYweplWPen0YrFdtUvbw5U= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from smarchi-efficios.internal.efficios.com (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 40F271E0C2; Wed, 31 Jan 2024 10:54:12 -0500 (EST) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH] gdb: remove some unnecessary frame_info_ptr resets Date: Wed, 31 Jan 2024 10:54:09 -0500 Message-ID: <20240131155411.8182-1-simon.marchi@efficios.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Spam-Status: No, score=-3496.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_SOFTFAIL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org This code was probably needed before we had reinflatable frame_info_ptrs, it's not necessary anymore. Change-Id: I5474c6081ee1e39624c9266b05dbe01351a130b5 --- gdb/arm-linux-tdep.c | 3 --- gdb/elfread.c | 2 -- gdb/infcall.c | 3 --- gdb/infcmd.c | 3 --- gdb/infrun.c | 3 --- gdb/stack.c | 3 --- 6 files changed, 17 deletions(-) base-commit: 249e54204b13f9acdd5fbca355fed305e8595f31 diff --git a/gdb/arm-linux-tdep.c b/gdb/arm-linux-tdep.c index 97debab81d6f..b559de0fb2d6 100644 --- a/gdb/arm-linux-tdep.c +++ b/gdb/arm-linux-tdep.c @@ -1047,9 +1047,6 @@ arm_linux_copy_svc (struct gdbarch *gdbarch, struct regcache *regs, = set_momentary_breakpoint (gdbarch, sal, get_frame_id (frame), bp_step_resume).release (); - /* set_momentary_breakpoint invalidates FRAME. */ - frame = NULL; - /* We need to make sure we actually insert the momentary breakpoint set above. */ insert_breakpoints (); diff --git a/gdb/elfread.c b/gdb/elfread.c index eca27008678e..e8a0c4d7a2cf 100644 --- a/gdb/elfread.c +++ b/gdb/elfread.c @@ -989,8 +989,6 @@ elf_gnu_ifunc_resolver_stop (code_breakpoint *b) prev_frame_id, bp_gnu_ifunc_resolver_return).release (); - /* set_momentary_breakpoint invalidates PREV_FRAME. */ - prev_frame = NULL; /* Add new b_return to the ring list b->related_breakpoint. */ gdb_assert (b_return->related_breakpoint == b_return); diff --git a/gdb/infcall.c b/gdb/infcall.c index 4079f9e7cab0..145ce25b0d1b 100644 --- a/gdb/infcall.c +++ b/gdb/infcall.c @@ -1300,9 +1300,6 @@ call_function_by_hand_dummy (struct value *function, = set_momentary_breakpoint (gdbarch, sal, dummy_id, bp_call_dummy).release (); - /* set_momentary_breakpoint invalidates FRAME. */ - frame = NULL; - bpt->disposition = disp_del; gdb_assert (bpt->related_breakpoint == bpt); diff --git a/gdb/infcmd.c b/gdb/infcmd.c index 5e5f75021f20..54063b37beb8 100644 --- a/gdb/infcmd.c +++ b/gdb/infcmd.c @@ -1757,9 +1757,6 @@ finish_forward (struct finish_command_fsm *sm, frame_info_ptr frame) get_stack_frame_id (frame), bp_finish); - /* set_momentary_breakpoint invalidates FRAME. */ - frame = nullptr; - set_longjmp_breakpoint (tp, frame_id); /* We want to print return value, please... */ diff --git a/gdb/infrun.c b/gdb/infrun.c index 8ccaf3326dc6..87965fb12742 100644 --- a/gdb/infrun.c +++ b/gdb/infrun.c @@ -8848,9 +8848,6 @@ insert_exception_resume_breakpoint (struct thread_info *tp, handler, bp_exception_resume).release (); - /* set_momentary_breakpoint_at_pc invalidates FRAME. */ - frame = nullptr; - tp->control.exception_resume_breakpoint = bp; } } diff --git a/gdb/stack.c b/gdb/stack.c index bf3158393efa..e44424282855 100644 --- a/gdb/stack.c +++ b/gdb/stack.c @@ -2307,9 +2307,6 @@ print_variable_and_value_data::operator() (const char *print_name, print_variable_and_value (print_name, sym, frame, stream, num_tabs); - /* print_variable_and_value invalidates FRAME. */ - frame = NULL; - values_printed = 1; }