[PATCH/committed] sim: cgen: mark cgen_rtx_error noreturn

Message ID 20231224100948.10850-1-vapier@gentoo.org
State New
Headers
Series [PATCH/committed] sim: cgen: mark cgen_rtx_error noreturn |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 warning Patch is already merged
linaro-tcwg-bot/tcwg_gdb_build--master-arm warning Patch is already merged

Commit Message

Mike Frysinger Dec. 24, 2023, 10:09 a.m. UTC
  Since this function never returns, mark it as such to fix some unused
variable warnings in error code paths.

For example, cris triggers:
sim/cris/semcrisv10f-switch.c:3558:11: error:
	variable 'tmp_newval' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]

Even though it has an "else" path that calls this error function.
---
 sim/common/cgen-ops.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Patch

diff --git a/sim/common/cgen-ops.h b/sim/common/cgen-ops.h
index 8c880fe54234..552ff5998275 100644
--- a/sim/common/cgen-ops.h
+++ b/sim/common/cgen-ops.h
@@ -705,6 +705,6 @@  SUBOFDI (DI a, DI b, BI c)
 
 #endif
 
-extern void cgen_rtx_error (SIM_CPU *, const char *);
+extern void cgen_rtx_error (SIM_CPU *, const char *) ATTRIBUTE_NORETURN;
 
 #endif /* CGEN_SEM_OPS_H */