From patchwork Sun Dec 24 10:09:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 82816 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E432D385841C for ; Sun, 24 Dec 2023 10:10:24 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id AEC5E3858D3C for ; Sun, 24 Dec 2023 10:09:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AEC5E3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AEC5E3858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703412592; cv=none; b=sak+f8jDdLUMujocWx8uP7Vi34n0UUZc/uH2nV5ruxtmuDIz60lsgXFDofAW9tP38gFgvRl0yuxkUedm7Ua9HyXMoK4BCYomcP3EZBkaGDcjI6ulW8uCLOS3zErqJjh97H9F5Fsb0nSTa+v9KkvSLzsRevzZGsORzYF3HqHwj8U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703412592; c=relaxed/simple; bh=H4OO464rHokQ4rR+5uPu5NZrGdsncW4BviBW1dXBW+w=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=EbXzRhnLOuTFwzG1CnihorQLUPaJS+0J1PKAyY8jB3/V7XyI/n3PVMaUm2q3CV8lo9VT1bQMMSb/b1bmLkPH7k3Wytwp/yfiHcuKW5sIVeIwLUUQYJ6S8KE2b65KI0lHgV9b/RJkK79zv+xDAE4pLT+qtLMj5p/V5EbyMsu93yc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 3C17E33BE3B; Sun, 24 Dec 2023 10:09:50 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH/committed] sim: cgen: mark cgen_rtx_error noreturn Date: Sun, 24 Dec 2023 05:09:48 -0500 Message-ID: <20231224100948.10850-1-vapier@gentoo.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Since this function never returns, mark it as such to fix some unused variable warnings in error code paths. For example, cris triggers: sim/cris/semcrisv10f-switch.c:3558:11: error: variable 'tmp_newval' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] Even though it has an "else" path that calls this error function. --- sim/common/cgen-ops.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sim/common/cgen-ops.h b/sim/common/cgen-ops.h index 8c880fe54234..552ff5998275 100644 --- a/sim/common/cgen-ops.h +++ b/sim/common/cgen-ops.h @@ -705,6 +705,6 @@ SUBOFDI (DI a, DI b, BI c) #endif -extern void cgen_rtx_error (SIM_CPU *, const char *); +extern void cgen_rtx_error (SIM_CPU *, const char *) ATTRIBUTE_NORETURN; #endif /* CGEN_SEM_OPS_H */