diff mbox series

[PATCH/committed,2/2] sim: sh: adjust some dsp insn masks

Message ID 20231216050047.13827-2-vapier@gentoo.org
State New
Headers
Series [PATCH/committed,1/2] sim: sh: tidy up gencode slightly |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 warning Patch is already merged
linaro-tcwg-bot/tcwg_gdb_build--master-arm warning Patch is already merged

Commit Message

Mike Frysinger Dec. 16, 2023, 5 a.m. UTC 
  The pmuls encoding is incorrect -- it looks like a copy & paste error
from the padd pmuls variant.  The SuperH software manual covers this.

On the flip side, the manual lists pwsb & pwad as insns that exist,
but no description of what they do, what the insn name means, or the
actual encoding.  Our sim implementation stubs them both out as nops.
Let's mark the fields to avoid unused variable warnings.
---
 sim/sh/gencode.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/sim/sh/gencode.c b/sim/sh/gencode.c
index 0a04e339fa18..2522ec124f86 100644
--- a/sim/sh/gencode.c
+++ b/sim/sh/gencode.c
@@ -1915,7 +1915,7 @@  static op ppi_tab[] =
     "COMPUTE_OVERFLOW;",
     "greater_equal = 0;",
   },
-  { "","", "pmuls Se,Sf,Dg",	"0100eeffxxyygguu",
+  { "","", "pmuls Se,Sf,Dg",	"0100eeff0000gg00",
     "res = (DSP_R (e) >> 16) * (DSP_R (f) >> 16) * 2;",
     "if (res == 0x80000000)",
     "  res = 0x7fffffff;",
@@ -2011,9 +2011,9 @@  static op ppi_tab[] =
     "COMPUTE_OVERFLOW;",
     "ADD_SUB_GE;",
   },
-  { "","", "pwsb Sx,Sy,Dz",	"10100100xxyyzzzz",
+  { "","", "pwsb Sx,Sy,Dz",	"10100100....zzzz",
   },
-  { "","", "pwad Sx,Sy,Dz",	"10110100xxyyzzzz",
+  { "","", "pwad Sx,Sy,Dz",	"10110100....zzzz",
   },
   { "","", "(if cc) pabs Sx,Dz",	"100010ccxx01zzzz",
     "/* FIXME: duplicate code pabs.  */",