From patchwork Sat Dec 16 05:00:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Frysinger X-Patchwork-Id: 82293 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2A9103858413 for ; Sat, 16 Dec 2023 05:01:10 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 6114C3858D33 for ; Sat, 16 Dec 2023 05:00:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6114C3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6114C3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702702856; cv=none; b=u34xs0tfGeEs/AkTeRTpC2bKt08G6wbj/CiPxog1qTPky3ptne1YrMwI54uUgOeJLyzb30GH8iSqvN0puM/Mgy2gyyUbf42qc+BiVBTQZnBEuVs4naLXaOtTkV+lVIpg8DK4cjbKZ2zFhFwzfH7LJWh/Cx6no93fxFXkoaz04Q4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702702856; c=relaxed/simple; bh=hEC4kVTzc1M7nj/aC6LDaVkaSqAyHYLda7p9xOYSvX0=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=mZbCKFku4/e4TmNUNWNCEMLqnsI2HYcD648h6+nXPKYhlaBl/DG2LTg7BXv2F/V8A7Ic6iz1S1+NgXLjZCYtW/PuqHHKtPYQwske8pOyB7993qP8eade1a+SfhGIt5TFXOmPhJRn9GvX+T6+JoAn+CEwyOBZXDlqWNHaBgdVxBg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 1064B335DC2; Sat, 16 Dec 2023 05:00:54 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: [PATCH/committed 2/2] sim: sh: adjust some dsp insn masks Date: Sat, 16 Dec 2023 00:00:47 -0500 Message-ID: <20231216050047.13827-2-vapier@gentoo.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231216050047.13827-1-vapier@gentoo.org> References: <20231216050047.13827-1-vapier@gentoo.org> MIME-Version: 1.0 X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org The pmuls encoding is incorrect -- it looks like a copy & paste error from the padd pmuls variant. The SuperH software manual covers this. On the flip side, the manual lists pwsb & pwad as insns that exist, but no description of what they do, what the insn name means, or the actual encoding. Our sim implementation stubs them both out as nops. Let's mark the fields to avoid unused variable warnings. --- sim/sh/gencode.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sim/sh/gencode.c b/sim/sh/gencode.c index 0a04e339fa18..2522ec124f86 100644 --- a/sim/sh/gencode.c +++ b/sim/sh/gencode.c @@ -1915,7 +1915,7 @@ static op ppi_tab[] = "COMPUTE_OVERFLOW;", "greater_equal = 0;", }, - { "","", "pmuls Se,Sf,Dg", "0100eeffxxyygguu", + { "","", "pmuls Se,Sf,Dg", "0100eeff0000gg00", "res = (DSP_R (e) >> 16) * (DSP_R (f) >> 16) * 2;", "if (res == 0x80000000)", " res = 0x7fffffff;", @@ -2011,9 +2011,9 @@ static op ppi_tab[] = "COMPUTE_OVERFLOW;", "ADD_SUB_GE;", }, - { "","", "pwsb Sx,Sy,Dz", "10100100xxyyzzzz", + { "","", "pwsb Sx,Sy,Dz", "10100100....zzzz", }, - { "","", "pwad Sx,Sy,Dz", "10110100xxyyzzzz", + { "","", "pwad Sx,Sy,Dz", "10110100....zzzz", }, { "","", "(if cc) pabs Sx,Dz", "100010ccxx01zzzz", "/* FIXME: duplicate code pabs. */",