diff mbox series

[22/24] gdb: don't call so_list::clear in free_so

Message ID	20231010204213.111285-23-simon.marchi@efficios.com
State	New
Headers	DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 92D623858C30 From: Simon Marchi <simon.marchi@efficios.com> To: gdb-patches@sourceware.org Cc: Simon Marchi <simon.marchi@efficios.com> Subject: [PATCH 22/24] gdb: don't call so_list::clear in free_so Date: Tue, 10 Oct 2023 16:40:17 -0400 Message-ID: <20231010204213.111285-23-simon.marchi@efficios.com> In-Reply-To: <20231010204213.111285-1-simon.marchi@efficios.com> References: <20231010204213.111285-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org
Series	C++ification of struct so_list \| [00/24] C++ification of struct so_list [01/24] gdb: remove empty clear_solib functions [02/24] gdb: add program_space parameter to target_so_ops::clear_solib [03/24] gdb: make interps_notify work with references [04/24] gdb: replace some so_list parameters to use references [05/24] gdbsupport: use "reference" and "pointer" type aliases in intrusive_list [06/24] gdbsupport: make intrusive_list's disposer accept a reference [07/24] gdb: make get_cbfd_soname_build_id static [08/24] gdb: allocate so_list with new, deallocate with delete [09/24] gdb: rename lm_info_base to lm_info [10/24] gdb: remove target_so_ops::free_so [11/24] gdb: use gdb::checked_static_cast when casting lm_info [12/24] gdb: make solib-svr4 not use so_list internally [13/24] gdb: make solib-rocm not use so_list internally [14/24] gdb: remove lm_info_vector typedef [15/24] gdb: make so_list::lm_info a unique_ptr [16/24] gdb: make clear_so a method of struct so_list [17/24] gdb: remove target_section_table typedef [18/24] gdb: make so_list::sections not a pointer [19/24] gdb: make so_list::abfd a gdb_bfd_ref_ptr [20/24] gdb: make so_list::{so_original_name, so_name} std::strings [21/24] gdb: link so_list using intrusive_list [22/24] gdb: don't call so_list::clear in free_so [23/24] gdb: remove free_so function [24/24] gdb: rename struct so_list to so

Checks

Context	Check	Description
linaro-tcwg-bot/tcwg_gdb_check--master-arm	success	Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm	success	Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64	success	Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64	success	Testing passed

Commit Message

Simon Marchi Oct. 10, 2023, 8:40 p.m. UTC

  I think this `so.clear ()` call is not useful.

 - so_list::clear deletes some things that now get automatically deleted
   when the so_list gets deleted right after in free_so.
 - so_list::clear resets some scalar fields of so_list, which we don't
   really care about since the so_list gets deleted right after.
 - so_list::clear calls target_so_ops::clear_so, of which there is a
   single implementation, svr4_clear_so.  That implementation just
   resets a field in lm_info_svr4, which we don't care about, as it will
   get deleted when the so_list gets deleted right after.

Change-Id: Ie4d72f2a04a4129e55c460bb5c69bc0af0d12b32
---
 gdb/solib.c | 1 -
 1 file changed, 1 deletion(-)

diff mbox series

Patch

diff --git a/gdb/solib.c b/gdb/solib.c
index 9c10340ff583..2e4881798339 100644
--- a/gdb/solib.c
+++ b/gdb/solib.c
@@ -664,7 +664,6 @@  lm_info::~lm_info () = default;
 void
 free_so (so_list &so)
 {
-  so.clear ();
   delete &so;
 }