diff mbox series

[01/24] gdb: remove empty clear_solib functions

Message ID	20231010204213.111285-2-simon.marchi@efficios.com
State	New
Headers	DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 078A93858D35 From: Simon Marchi <simon.marchi@efficios.com> To: gdb-patches@sourceware.org Cc: Simon Marchi <simon.marchi@efficios.com> Subject: [PATCH 01/24] gdb: remove empty clear_solib functions Date: Tue, 10 Oct 2023 16:39:56 -0400 Message-ID: <20231010204213.111285-2-simon.marchi@efficios.com> In-Reply-To: <20231010204213.111285-1-simon.marchi@efficios.com> References: <20231010204213.111285-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org
Series	C++ification of struct so_list \| [00/24] C++ification of struct so_list [01/24] gdb: remove empty clear_solib functions [02/24] gdb: add program_space parameter to target_so_ops::clear_solib [03/24] gdb: make interps_notify work with references [04/24] gdb: replace some so_list parameters to use references [05/24] gdbsupport: use "reference" and "pointer" type aliases in intrusive_list [06/24] gdbsupport: make intrusive_list's disposer accept a reference [07/24] gdb: make get_cbfd_soname_build_id static [08/24] gdb: allocate so_list with new, deallocate with delete [09/24] gdb: rename lm_info_base to lm_info [10/24] gdb: remove target_so_ops::free_so [11/24] gdb: use gdb::checked_static_cast when casting lm_info [12/24] gdb: make solib-svr4 not use so_list internally [13/24] gdb: make solib-rocm not use so_list internally [14/24] gdb: remove lm_info_vector typedef [15/24] gdb: make so_list::lm_info a unique_ptr [16/24] gdb: make clear_so a method of struct so_list [17/24] gdb: remove target_section_table typedef [18/24] gdb: make so_list::sections not a pointer [19/24] gdb: make so_list::abfd a gdb_bfd_ref_ptr [20/24] gdb: make so_list::{so_original_name, so_name} std::strings [21/24] gdb: link so_list using intrusive_list [22/24] gdb: don't call so_list::clear in free_so [23/24] gdb: remove free_so function [24/24] gdb: rename struct so_list to so

Commit Message

Simon Marchi Oct. 10, 2023, 8:39 p.m. UTC

  Make the target_so_ops::clear_solib method optional, remove two empty
implementations.

Change-Id: Ifda297d50c74327d337091c58cdb5b3b60382591
---
 gdb/solib-aix.c    | 10 +---------
 gdb/solib-target.c |  8 +-------
 gdb/solib.c        |  6 ++++--
 3 files changed, 6 insertions(+), 18 deletions(-)

diff mbox series

Patch

diff --git a/gdb/solib-aix.c b/gdb/solib-aix.c
index fd6b1e7a4543..0b6ad83eed92 100644
--- a/gdb/solib-aix.c
+++ b/gdb/solib-aix.c
@@ -373,14 +373,6 @@  solib_aix_free_so (struct so_list *so)
   delete li;
 }
 
-/* Implement the "clear_solib" target_so_ops method.  */
-
-static void
-solib_aix_clear_solib (void)
-{
-  /* Nothing needed.  */
-}
-
 /* Compute and return the OBJFILE's section_offset array, using
    the associated loader info (INFO).  */
 
@@ -715,7 +707,7 @@  const struct target_so_ops solib_aix_so_ops =
   solib_aix_relocate_section_addresses,
   solib_aix_free_so,
   nullptr,
-  solib_aix_clear_solib,
+  nullptr,
   solib_aix_solib_create_inferior_hook,
   solib_aix_current_sos,
   solib_aix_open_symbol_file_object,
diff --git a/gdb/solib-target.c b/gdb/solib-target.c
index ca9478f2ec30..865235de2995 100644
--- a/gdb/solib-target.c
+++ b/gdb/solib-target.c
@@ -281,12 +281,6 @@  solib_target_solib_create_inferior_hook (int from_tty)
   /* Nothing needed.  */
 }
 
-static void
-solib_target_clear_solib (void)
-{
-  /* Nothing needed.  */
-}
-
 static void
 solib_target_free_so (struct so_list *so)
 {
@@ -440,7 +434,7 @@  const struct target_so_ops solib_target_so_ops =
   solib_target_relocate_section_addresses,
   solib_target_free_so,
   nullptr,
-  solib_target_clear_solib,
+  nullptr,
   solib_target_solib_create_inferior_hook,
   solib_target_current_sos,
   solib_target_open_symbol_file_object,
diff --git a/gdb/solib.c b/gdb/solib.c
index a2a8a031f343..e8211814283a 100644
--- a/gdb/solib.c
+++ b/gdb/solib.c
@@ -1240,7 +1240,8 @@  clear_solib (void)
       free_so (so);
     }
 
-  ops->clear_solib ();
+  if (ops->clear_solib != nullptr)
+    ops->clear_solib ();
 }
 
 /* Shared library startup support.  When GDB starts up the inferior,
@@ -1409,7 +1410,8 @@  reload_shared_libraries (const char *ignored, int from_tty,
     {
       /* Reset or free private data structures not associated with
 	 so_list entries.  */
-      ops->clear_solib ();
+      if (ops->clear_solib != nullptr)
+	ops->clear_solib ();
 
       /* Remove any previous solib event breakpoint.  This is usually
 	 done in common code, at breakpoint_init_inferior time, but