diff mbox series

Revert "gdb/testsuite: add KFAILs to gdb.reverse/step-reverse.exp"

Message ID 20230504105022.585919-1-blarsen@redhat.com
State New
Headers
Series Revert "gdb/testsuite: add KFAILs to gdb.reverse/step-reverse.exp" |

Commit Message

Guinevere Larsen May 4, 2023, 10:50 a.m. UTC 
  This reverts commit 476410b3bca1389ee69e9c8fa18aaee16793a56d.

One of Simon's recent commits (2a740b3ba4c9f39c86dd75e0914ee00942cab471)
changed the way recording a remote target works and fixed the underlying
issue of the bug, so the KFails can be removed from the test.
---
 gdb/testsuite/gdb.reverse/step-reverse.exp | 15 ---------------
 1 file changed, 15 deletions(-)

Comments

Tom Tromey May 4, 2023, 2:46 p.m. UTC | #1 
>>>>> "Bruno" == Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes:

Bruno> This reverts commit 476410b3bca1389ee69e9c8fa18aaee16793a56d.
Bruno> One of Simon's recent commits (2a740b3ba4c9f39c86dd75e0914ee00942cab471)
Bruno> changed the way recording a remote target works and fixed the underlying
Bruno> issue of the bug, so the KFails can be removed from the test.

Thank you.
Approved-By: Tom Tromey <tom@tromey.com>

Tom
diff mbox series

Patch

diff --git a/gdb/testsuite/gdb.reverse/step-reverse.exp b/gdb/testsuite/gdb.reverse/step-reverse.exp
index 2c3b95a2eae..729218d4cb8 100644
--- a/gdb/testsuite/gdb.reverse/step-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/step-reverse.exp
@@ -29,7 +29,6 @@  if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } {
 }
 
 runto_main
-set target_remote [gdb_is_target_remote]
 
 if [supports_process_record] {
     # Activate process record/replay
@@ -272,25 +271,11 @@  if { "$step_out" == 1 } {
 # Step forward over recursion again so we can test stepping over calls
 # inside the recursion itself.
 gdb_test_no_output "set exec-dir forward" "forward again to test recursion"
-if {$target_remote} {
-    # gdb doesn't record the change of return pointer for remote targets,
-    # so we can't next forward over functions.
-    setup_kfail gdb/29745 *-*-*
-}
 gdb_test "next" "NEXT OVER THIS CALL.*" "reverse next over recursion again"
 gdb_test_no_output "set exec-dir reverse" "reverse again to test recursion"
 
-if {$target_remote} {
-    # Because of the above mentioned KFAIL, the inferior is now out of sync
-    setup_kfail gdb/29745 *-*-*
-}
 gdb_test "step" ".*EXIT RECURSIVE FUNCTION.*" "enter recursive function"
 set seen_recursive_call 0
-if {$target_remote} {
-    # Because of the above mentioned KFAIL, the inferior is now out of sync
-    # The fail state below will resync the inferior.
-    setup_kfail gdb/29745 *-*-*
-}
 gdb_test_multiple "next" "step over recursion inside the recursion" {
     -re -wrap ".*RECURSIVE CALL.*" {
 	incr seen_recursive_call