From patchwork Thu May 4 10:50:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guinevere Larsen X-Patchwork-Id: 68744 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 81F153858C31 for ; Thu, 4 May 2023 10:51:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 81F153858C31 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1683197462; bh=fsO+6GlJsN43ydXNqMsmGPSd69rNHq13F0hEnPsGoJ4=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=lo1O/WgzgtEhvFBX7VEilPTjhiLzo+q+Flc0tGMEslt95pMbPV4Ofo8LWaoHGNocD X0pe5tU7NCxpyzMSyh/5mmphkauiLMfM2kBcEeeo0re//6CeCt7Q6QNK6tI9WzyyOZ fudoh0zU0ln5Z6YcrT1JU+pmq8NKFMcryaezRUE4= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 3A8AA3858D28 for ; Thu, 4 May 2023 10:50:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A8AA3858D28 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-342-KJuW5J6uPEmiZcM6VGhYSg-1; Thu, 04 May 2023 06:50:30 -0400 X-MC-Unique: KJuW5J6uPEmiZcM6VGhYSg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E6C1F2A5954C for ; Thu, 4 May 2023 10:50:29 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.45.225.167]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BBAB7492C13; Thu, 4 May 2023 10:50:28 +0000 (UTC) To: gdb-patches@sourceware.org Cc: Bruno Larsen Subject: [PATCH] Revert "gdb/testsuite: add KFAILs to gdb.reverse/step-reverse.exp" Date: Thu, 4 May 2023 12:50:22 +0200 Message-Id: <20230504105022.585919-1-blarsen@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Bruno Larsen via Gdb-patches From: Guinevere Larsen Reply-To: Bruno Larsen Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" This reverts commit 476410b3bca1389ee69e9c8fa18aaee16793a56d. One of Simon's recent commits (2a740b3ba4c9f39c86dd75e0914ee00942cab471) changed the way recording a remote target works and fixed the underlying issue of the bug, so the KFails can be removed from the test. --- gdb/testsuite/gdb.reverse/step-reverse.exp | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/gdb/testsuite/gdb.reverse/step-reverse.exp b/gdb/testsuite/gdb.reverse/step-reverse.exp index 2c3b95a2eae..729218d4cb8 100644 --- a/gdb/testsuite/gdb.reverse/step-reverse.exp +++ b/gdb/testsuite/gdb.reverse/step-reverse.exp @@ -29,7 +29,6 @@ if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } { } runto_main -set target_remote [gdb_is_target_remote] if [supports_process_record] { # Activate process record/replay @@ -272,25 +271,11 @@ if { "$step_out" == 1 } { # Step forward over recursion again so we can test stepping over calls # inside the recursion itself. gdb_test_no_output "set exec-dir forward" "forward again to test recursion" -if {$target_remote} { - # gdb doesn't record the change of return pointer for remote targets, - # so we can't next forward over functions. - setup_kfail gdb/29745 *-*-* -} gdb_test "next" "NEXT OVER THIS CALL.*" "reverse next over recursion again" gdb_test_no_output "set exec-dir reverse" "reverse again to test recursion" -if {$target_remote} { - # Because of the above mentioned KFAIL, the inferior is now out of sync - setup_kfail gdb/29745 *-*-* -} gdb_test "step" ".*EXIT RECURSIVE FUNCTION.*" "enter recursive function" set seen_recursive_call 0 -if {$target_remote} { - # Because of the above mentioned KFAIL, the inferior is now out of sync - # The fail state below will resync the inferior. - setup_kfail gdb/29745 *-*-* -} gdb_test_multiple "next" "step over recursion inside the recursion" { -re -wrap ".*RECURSIVE CALL.*" { incr seen_recursive_call