diff mbox

[1/3] Clean up server-kill.exp

Message ID 1412749679-27076-2-git-send-email-yao@codesourcery.com
State New
Headers show

Commit Message

Yao Qi Oct. 8, 2014, 6:27 a.m. UTC
This patch is to remove some lines which looks unnecessary.  These
lines were added when server-kill.exp was added.  In the version 1,
https://sourceware.org/ml/gdb-patches/2013-03/msg00691.html the test
calls runto_main and delete breakpoint on main,

+if ![runto_main] {
+    return -1
+}
+
+# Otherwise the breakpoint at 'main' would not cause insert breakpoints during
+# first step.
+delete_breakpoints

However, in the version 2
https://sourceware.org/ml/gdb-patches/2013-03/msg00854.html runto_main
is removed but delete_breakpoints is still there.  AFAICS, the line of
delete_breakpoints can be removed too.

gdb/testsuite:

2014-10-08  Yao Qi  <yao@codesourcery.com>

	* gdb.server/server-kill.exp: Remove "delete_breakpoints".
---
 gdb/testsuite/gdb.server/server-kill.exp | 4 ----
 1 file changed, 4 deletions(-)

Comments

Pedro Alves Oct. 8, 2014, 1:48 p.m. UTC | #1
On 10/08/2014 07:27 AM, Yao Qi wrote:
> This patch is to remove some lines which looks unnecessary.  These
> lines were added when server-kill.exp was added.  In the version 1,
> https://sourceware.org/ml/gdb-patches/2013-03/msg00691.html the test
> calls runto_main and delete breakpoint on main,
> 
> +if ![runto_main] {
> +    return -1
> +}
> +
> +# Otherwise the breakpoint at 'main' would not cause insert breakpoints during
> +# first step.
> +delete_breakpoints
> 
> However, in the version 2
> https://sourceware.org/ml/gdb-patches/2013-03/msg00854.html runto_main
> is removed but delete_breakpoints is still there.  AFAICS, the line of
> delete_breakpoints can be removed too.
> 
> gdb/testsuite:
> 
> 2014-10-08  Yao Qi  <yao@codesourcery.com>
> 
> 	* gdb.server/server-kill.exp: Remove "delete_breakpoints".

OK.

Thanks,
Pedro Alves
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.server/server-kill.exp b/gdb/testsuite/gdb.server/server-kill.exp
index 5d31103..b23c2b5 100644
--- a/gdb/testsuite/gdb.server/server-kill.exp
+++ b/gdb/testsuite/gdb.server/server-kill.exp
@@ -33,10 +33,6 @@  gdb_test "disconnect" ".*"
 
 gdbserver_run ""
 
-# Otherwise the breakpoint at 'main' would not cause insert
-# breakpoints during first step.
-delete_breakpoints
-
 set server_pid [exp_pid -i [board_info target fileid]]
 remote_exec target "kill -9 $server_pid"