From patchwork Wed Oct 8 06:27:57 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yao Qi X-Patchwork-Id: 3130 Received: (qmail 30746 invoked by alias); 8 Oct 2014 06:32:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 30721 invoked by uid 89); 8 Oct 2014 06:32:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Oct 2014 06:32:30 +0000 Received: from svr-orw-fem-06.mgc.mentorg.com ([147.34.97.120]) by relay1.mentorg.com with esmtp id 1XbknT-00022q-3R from Yao_Qi@mentor.com ; Tue, 07 Oct 2014 23:32:27 -0700 Received: from qiyao.dyndns.org.com (147.34.91.1) by SVR-ORW-FEM-06.mgc.mentorg.com (147.34.97.120) with Microsoft SMTP Server id 14.3.181.6; Tue, 7 Oct 2014 23:32:26 -0700 From: Yao Qi To: CC: Subject: [PATCH 1/3] Clean up server-kill.exp Date: Wed, 8 Oct 2014 14:27:57 +0800 Message-ID: <1412749679-27076-2-git-send-email-yao@codesourcery.com> In-Reply-To: <1412749679-27076-1-git-send-email-yao@codesourcery.com> References: <543404EF.4010306@redhat.com> <1412749679-27076-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 X-IsSubscribed: yes This patch is to remove some lines which looks unnecessary. These lines were added when server-kill.exp was added. In the version 1, https://sourceware.org/ml/gdb-patches/2013-03/msg00691.html the test calls runto_main and delete breakpoint on main, +if ![runto_main] { + return -1 +} + +# Otherwise the breakpoint at 'main' would not cause insert breakpoints during +# first step. +delete_breakpoints However, in the version 2 https://sourceware.org/ml/gdb-patches/2013-03/msg00854.html runto_main is removed but delete_breakpoints is still there. AFAICS, the line of delete_breakpoints can be removed too. gdb/testsuite: 2014-10-08 Yao Qi * gdb.server/server-kill.exp: Remove "delete_breakpoints". --- gdb/testsuite/gdb.server/server-kill.exp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/gdb/testsuite/gdb.server/server-kill.exp b/gdb/testsuite/gdb.server/server-kill.exp index 5d31103..b23c2b5 100644 --- a/gdb/testsuite/gdb.server/server-kill.exp +++ b/gdb/testsuite/gdb.server/server-kill.exp @@ -33,10 +33,6 @@ gdb_test "disconnect" ".*" gdbserver_run "" -# Otherwise the breakpoint at 'main' would not cause insert -# breakpoints during first step. -delete_breakpoints - set server_pid [exp_pid -i [board_info target fileid]] remote_exec target "kill -9 $server_pid"