mbox series

[v3,0/9] Remove char-based bitfield macros

Message ID 20231103-field-bits-v3-0-273c40bcaf3d@adacore.com
Headers
Series Remove char-based bitfield macros |

Message

Tom Tromey Nov. 3, 2023, 4:09 p.m. UTC 
  This series removes the char-based bitfield macros from gdbtypes.h,
moving the associated data into 'struct field'.  A few other minor
cleanups are done along the way.

Regression tested on x86-64 Fedora 36.

---
Changes in v3:
- Updated per review comments
- Link to v2: https://inbox.sourceware.org/gdb-patches/20231027-field-bits-v2-0-cbec64f2136a@adacore.com

Changes in v2:
- Introduced accessibility enum per review
- Added two new simplification patches
- Link to v1: https://inbox.sourceware.org/gdb-patches/20230921-field-bits-v1-0-201285360900@adacore.com

---
Tom Tromey (9):
      Use .def file to stringify type codes
      Print field accessibility inline
      Remove byte vectors from cplus_struct_type
      Add field::is_public
      Remove some QUIT calls from need_access_label_p
      Remove some type field accessor macros
      Remove char-based bitfield macros
      Use enum accessibility in types and member functions
      Simplify C++ type-printing

 gdb/ada-valprint.c                       |   2 +-
 gdb/c-typeprint.c                        | 145 ++++++------------------
 gdb/c-varobj.c                           |  39 ++-----
 gdb/compile/compile-cplus-types.c        |   7 +-
 gdb/cp-valprint.c                        |   4 +-
 gdb/dwarf2/read.c                        |  94 ++++------------
 gdb/gdbtypes.c                           | 184 +++++++------------------------
 gdb/gdbtypes.h                           | 162 ++++++++++++---------------
 gdb/p-typeprint.c                        |   6 +-
 gdb/p-valprint.c                         |   4 +-
 gdb/stabsread.c                          | 127 ++++++++-------------
 gdb/testsuite/gdb.base/ptype-offsets.exp |   6 -
 12 files changed, 231 insertions(+), 549 deletions(-)
---
base-commit: 88bfe6ac8bcbaf1eb0c1e4be02c21a5c048b7335
change-id: 20230921-field-bits-9b9f802eb42b

Best regards,

Comments

Tom Tromey Nov. 21, 2023, 9:52 p.m. UTC | #1 
>>>>> "Tom" == Tom Tromey <tromey@adacore.com> writes:

Tom> This series removes the char-based bitfield macros from gdbtypes.h,
Tom> moving the associated data into 'struct field'.  A few other minor
Tom> cleanups are done along the way.

Tom> Regression tested on x86-64 Fedora 36.

I'm checking these in.

Tom