From patchwork Fri Nov 3 16:09:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 56315 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7F36D385B52D for ; Fri, 3 Nov 2023 16:09:52 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) by sourceware.org (Postfix) with ESMTPS id B70EC3858D28 for ; Fri, 3 Nov 2023 16:09:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B70EC3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B70EC3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699027779; cv=none; b=Lagn8ZIJ7q3mFFHoiCjP4HAUTabEw7x/oLLXL82HfosvsIzkeGZD2nVdXeWggIjLju983MkscbKqbX2paoo5ZWhO7HUCSouXF+XBhY3fOnzYMg4g3KYU8REHsQajraib+kgWLix2cLk/1jv/leowRQgc5x6r5che09X0y7HpZHo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699027779; c=relaxed/simple; bh=mfYWRjez2GDl94Y+150MTZwSCrjSH7wuaG0Fm77W0dw=; h=DKIM-Signature:From:Subject:Date:Message-Id:MIME-Version:To; b=mD9HMAadicR85Otn+GrsHdgkBQhBTgzc3AAuKq1iFCMUEzGBkWQiGDtzDUh4XqRWCeIe+pW+LNSGAUHU5Velp3ZPoAIaFdwDyWIAAkoFLPEEBcIX2y0nS8S3K1Z7K7DqgA0QgadvlQ2r5rewgrv4oKcu4pSUlhwMto4kw6hSxoA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2c.google.com with SMTP id ca18e2360f4ac-7ad1236c419so42264839f.0 for ; Fri, 03 Nov 2023 09:09:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1699027768; x=1699632568; darn=sourceware.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=XSik2Clk73vrkQHB6bzD2OdXM0zPVt7fXgXGKVrImiA=; b=HunXoezGPo78YI5RkoNuhBDfzpgM51JkhO3siSNX7dk3rrDvZfo2VG3xiWGyzBNnqA +ewmAEDUbVMJqWBzu/gdLVodaKQ4M5vgrTC84kD5C8rri/M5p/3x0DpndkTinA2DfhJR RoFggvH5NPlB2c0pfYkOjCig33RHHA2uc4HjN6k+mhUSZKmboEq1o0WP3pBcoSaHxUE4 02AL12Q3TUcV4DUg37h15KE9bGZg0kKzNTdV0BgkAQ27LzqZpKZ+AM+342X6SmIapeIR 98s4XZ8tAouoENCWjSWZzH5ZwKvklW94hsNaQ3wXpjWU3AQ2gyo/xZRUf08g6KhKDgHx Lgxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699027768; x=1699632568; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XSik2Clk73vrkQHB6bzD2OdXM0zPVt7fXgXGKVrImiA=; b=Wdx3gPCPWRKg2KoqzwpcpdiQY73RFRQicfjvlxNsKMGh869QQujK8QbibAgdj7N+QJ OjDTQOC8Ma3ghE0CnmCvNAObD27s1vUptPkqT6B64wHlU5vfyKyvVLFzieAT6P7s50te sJLs+P1us3FTgkrhQ5vDbdAKAgbVn/3/JdDsDc4UCYjqI1RBaJcBt4PUpBjdX5U24qkO /M1iQPn9svzclKgeO8MEfSQ/aH90N9hjfJDy8uBobGgZ+Ci2qD/c2qA5wrKoqShdghLT xzO+j9VhUTJxqJddV9IVpR+uELZ/FS/i4uXEoqDHt2CkS84bHjyT1MZ1IWTbQzIbXm7U +NnA== X-Gm-Message-State: AOJu0Yw+Zc3PhHDTcMaBsQIKBdrGF2Xf3kc+p3mctbuvpSHLpp269Hdj 4y4H0dD3JBxYBk7Ubo6MgUvO6rryYjJmUlpNqjXjew== X-Google-Smtp-Source: AGHT+IHM6X0CxEfWqnfXtXYtaKmUu9LOi6rvoLxjuWzN5xmEcf+SeFFtfNSYldG6oSI4sfyPNBGtdA== X-Received: by 2002:a05:6602:2c82:b0:7a9:afab:b979 with SMTP id i2-20020a0566022c8200b007a9afabb979mr26870784iow.15.1699027767878; Fri, 03 Nov 2023 09:09:27 -0700 (PDT) Received: from localhost.localdomain (97-122-77-73.hlrn.qwest.net. [97.122.77.73]) by smtp.gmail.com with ESMTPSA id gu16-20020a0566382e1000b0042b3dcb1106sm581839jab.47.2023.11.03.09.09.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Nov 2023 09:09:27 -0700 (PDT) From: Tom Tromey Subject: [PATCH v3 0/9] Remove char-based bitfield macros Date: Fri, 03 Nov 2023 10:09:22 -0600 Message-Id: <20231103-field-bits-v3-0-273c40bcaf3d@adacore.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIADMbRWUC/22NwQrCMBAFf6XkbGSzqbXx5H+IhyTd2IBtJClFK f13kx6EgseBN/MWlih6SuxSLSzS7JMPYwZ5qJjt9fgg7rvMDAElKBTceXp23PgpcWWUawHJ1Gh YFl6RnH9vsds9s9GJuIl6tH1JDDpNFMuw92kK8bOdzqLM//ZnwYEjCGxPsgEFcNWdtiHS0YaBl YcZf7IAPO9kzLI1ZJvaoZCN3svrun4BkiQjpPwAAAA= To: gdb-patches@sourceware.org Cc: Simon Marchi , Keith Seitz X-Mailer: b4 0.12.4 X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org This series removes the char-based bitfield macros from gdbtypes.h, moving the associated data into 'struct field'. A few other minor cleanups are done along the way. Regression tested on x86-64 Fedora 36. --- Changes in v3: - Updated per review comments - Link to v2: https://inbox.sourceware.org/gdb-patches/20231027-field-bits-v2-0-cbec64f2136a@adacore.com Changes in v2: - Introduced accessibility enum per review - Added two new simplification patches - Link to v1: https://inbox.sourceware.org/gdb-patches/20230921-field-bits-v1-0-201285360900@adacore.com --- Tom Tromey (9): Use .def file to stringify type codes Print field accessibility inline Remove byte vectors from cplus_struct_type Add field::is_public Remove some QUIT calls from need_access_label_p Remove some type field accessor macros Remove char-based bitfield macros Use enum accessibility in types and member functions Simplify C++ type-printing gdb/ada-valprint.c | 2 +- gdb/c-typeprint.c | 145 ++++++------------------ gdb/c-varobj.c | 39 ++----- gdb/compile/compile-cplus-types.c | 7 +- gdb/cp-valprint.c | 4 +- gdb/dwarf2/read.c | 94 ++++------------ gdb/gdbtypes.c | 184 +++++++------------------------ gdb/gdbtypes.h | 162 ++++++++++++--------------- gdb/p-typeprint.c | 6 +- gdb/p-valprint.c | 4 +- gdb/stabsread.c | 127 ++++++++------------- gdb/testsuite/gdb.base/ptype-offsets.exp | 6 - 12 files changed, 231 insertions(+), 549 deletions(-) --- base-commit: 88bfe6ac8bcbaf1eb0c1e4be02c21a5c048b7335 change-id: 20230921-field-bits-9b9f802eb42b Best regards,