Patchwork [v2,00/23] All-stop on top of non-stop

login
register
mail settings
Submitter Pedro Alves
Date April 8, 2015, 10:30 a.m.
Message ID <5525032C.6060805@redhat.com>
Download mbox | patch
Permalink /patch/6082/
State New
Headers show

Comments

Pedro Alves - April 8, 2015, 10:30 a.m.
On 04/08/2015 11:17 AM, Pedro Alves wrote:
> How odd.  Passes for me with x86_64 gdbserver+sss.
> 
> The "find lwp id" messages indicate that this:
> 
> if { [info exists lwp6] } then {
>     gdb_test "echo $lwp6\\n" "$lwp6" "got lwp ids"
> }
> 
> ... was reached.  Are you running the testsuite with two boards
> at the same time?  In that case, I'd guess that the test first
> ran against the native target, which left $lwp6 set, and then
> it run against gdbserver, with $lwp6 stale.
> 
>> > Maybe, thread list in GDB side is out of date?
> Don't think so, there are a bunch of "info threads" calls.
> 

Confirmed, if I do that, I get the same fails:

$ make check RUNTESTFLAGS="--target_board='unix native-gdbserver' thread-find.exp"
...
Native configuration is x86_64-unknown-linux-gnu

                === gdb tests ===

Schedule of variations:
    unix
    native-gdbserver

...
Running /home/pedro/gdb/mygit/src/gdb/testsuite/gdb.threads/thread-find.exp ...

                === gdb Summary for unix ===

# of expected passes            40
Running target native-gdbserver
...
Running /home/pedro/gdb/mygit/src/gdb/testsuite/gdb.threads/thread-find.exp ...
FAIL: gdb.threads/thread-find.exp: find lwp id 6
FAIL: gdb.threads/thread-find.exp: find lwp id 5
FAIL: gdb.threads/thread-find.exp: find lwp id 4
FAIL: gdb.threads/thread-find.exp: find lwp id 3
FAIL: gdb.threads/thread-find.exp: find lwp id 2
FAIL: gdb.threads/thread-find.exp: find lwp id 1

                === gdb Summary for native-gdbserver ===

# of expected passes            34
# of unexpected failures        6

                === gdb Summary ===

# of expected passes            74
# of unexpected failures        6


This trivial patch fixes it:

From 8f31ed0db2fb3d34942c72c859e52857468d46e8 Mon Sep 17 00:00:00 2001
From: Pedro Alves <palves@redhat.com>
Date: Wed, 8 Apr 2015 11:25:09 +0100
Subject: [PATCH] thread-find.exp: fix stale variables

---
 gdb/testsuite/gdb.threads/thread-find.exp | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

Patch

diff --git a/gdb/testsuite/gdb.threads/thread-find.exp b/gdb/testsuite/gdb.threads/thread-find.exp
index 1cd39de..1508ca3 100644
--- a/gdb/testsuite/gdb.threads/thread-find.exp
+++ b/gdb/testsuite/gdb.threads/thread-find.exp
@@ -55,6 +55,9 @@  gdb_test "thread apply 6 thread name threadname_6" \
     "name thread 6"
 
 # Collect thread ids, if any.
+
+set thread6 ""
+
 gdb_test_multiple "info threads" "collect thread id" {
     -re ". 6 .*\[Tt\]hread (\[0-9a-fA-Fx\]+).* \"threadname_6\" \[^\r\n\]*" {
 	set thread6 $expect_out(1,string)
@@ -85,11 +88,14 @@  gdb_test_multiple "info threads" "collect thread id" {
     }
 }
 
-if { [info exists thread6] } then {
+if { $thread6 != "" } then {
     gdb_test "echo $thread6\\n" "$thread6" "got thread ids"
 }
 
 # Collect process ids, if any.
+
+set process6 ""
+
 gdb_test_multiple "info threads" "collect thread id" {
     -re ". 6 .*\[Pp\]rocess (\[0-9a-fA-Fx\]+).* \"threadname_6\" \[^\r\n\]*" {
 	set process6 $expect_out(1,string)
@@ -125,6 +131,9 @@  if { [info exists process6] } then {
 }
 
 # Collect lwp ids, if any.
+
+set lwp6 ""
+
 gdb_test_multiple "info threads" "collect thread id" {
     -re ". 6 .*LWP (\[0-9a-fA-Fx\]+).* \"threadname_6\" \[^\r\n\]*" {
 	set lwp6 $expect_out(1,string)
@@ -155,7 +164,7 @@  gdb_test_multiple "info threads" "collect thread id" {
     }
 }
 
-if { [info exists lwp6] } then {
+if { $lwp6 != "" } then {
     gdb_test "echo $lwp6\\n" "$lwp6" "got lwp ids"
 }
 
@@ -180,7 +189,7 @@  gdb_test "thread find threadname_1" \
 # Test 'thread find' with thread ids, if any.
 #
 
-if { [info exists thread6] } then {
+if { $thread6 != "" } then {
     gdb_test "thread find $thread6" \
 	"Thread 6 has .*$thread6.*" "find thread id 6"
     gdb_test "thread find $thread5" \
@@ -199,7 +208,7 @@  if { [info exists thread6] } then {
 # Test 'thread find' with process ids, if any.
 #
 
-if { [info exists process6] } then {
+if { $process6 != "" } then {
     gdb_test "thread find $process6" \
 	"Thread 6 has .*$process6.*" "find process id 6"
     gdb_test "thread find $process5" \
@@ -218,7 +227,7 @@  if { [info exists process6] } then {
 # Test 'thread find' with lwp ids, if any.
 #
 
-if { [info exists lwp6] } then {
+if { $lwp6 != "" } then {
     gdb_test "thread find $lwp6" \
 	"Thread 6 has .*$lwp6.*" "find lwp id 6"
     gdb_test "thread find $lwp5" \