From patchwork Wed Apr 8 10:30:04 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Alves X-Patchwork-Id: 6082 Received: (qmail 97776 invoked by alias); 8 Apr 2015 10:30:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 97470 invoked by uid 89); 8 Apr 2015 10:30:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 08 Apr 2015 10:30:09 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t38AU6aH027372 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 8 Apr 2015 06:30:06 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t38AU5rW007385; Wed, 8 Apr 2015 06:30:05 -0400 Message-ID: <5525032C.6060805@redhat.com> Date: Wed, 08 Apr 2015 11:30:04 +0100 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH v2 00/23] All-stop on top of non-stop References: <1428410990-28560-1-git-send-email-palves@redhat.com> <86mw2jvtqk.fsf@gmail.com> <55250048.9050801@redhat.com> In-Reply-To: <55250048.9050801@redhat.com> On 04/08/2015 11:17 AM, Pedro Alves wrote: > How odd. Passes for me with x86_64 gdbserver+sss. > > The "find lwp id" messages indicate that this: > > if { [info exists lwp6] } then { > gdb_test "echo $lwp6\\n" "$lwp6" "got lwp ids" > } > > ... was reached. Are you running the testsuite with two boards > at the same time? In that case, I'd guess that the test first > ran against the native target, which left $lwp6 set, and then > it run against gdbserver, with $lwp6 stale. > >> > Maybe, thread list in GDB side is out of date? > Don't think so, there are a bunch of "info threads" calls. > Confirmed, if I do that, I get the same fails: $ make check RUNTESTFLAGS="--target_board='unix native-gdbserver' thread-find.exp" ... Native configuration is x86_64-unknown-linux-gnu === gdb tests === Schedule of variations: unix native-gdbserver ... Running /home/pedro/gdb/mygit/src/gdb/testsuite/gdb.threads/thread-find.exp ... === gdb Summary for unix === # of expected passes 40 Running target native-gdbserver ... Running /home/pedro/gdb/mygit/src/gdb/testsuite/gdb.threads/thread-find.exp ... FAIL: gdb.threads/thread-find.exp: find lwp id 6 FAIL: gdb.threads/thread-find.exp: find lwp id 5 FAIL: gdb.threads/thread-find.exp: find lwp id 4 FAIL: gdb.threads/thread-find.exp: find lwp id 3 FAIL: gdb.threads/thread-find.exp: find lwp id 2 FAIL: gdb.threads/thread-find.exp: find lwp id 1 === gdb Summary for native-gdbserver === # of expected passes 34 # of unexpected failures 6 === gdb Summary === # of expected passes 74 # of unexpected failures 6 This trivial patch fixes it: From 8f31ed0db2fb3d34942c72c859e52857468d46e8 Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Wed, 8 Apr 2015 11:25:09 +0100 Subject: [PATCH] thread-find.exp: fix stale variables --- gdb/testsuite/gdb.threads/thread-find.exp | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/gdb/testsuite/gdb.threads/thread-find.exp b/gdb/testsuite/gdb.threads/thread-find.exp index 1cd39de..1508ca3 100644 --- a/gdb/testsuite/gdb.threads/thread-find.exp +++ b/gdb/testsuite/gdb.threads/thread-find.exp @@ -55,6 +55,9 @@ gdb_test "thread apply 6 thread name threadname_6" \ "name thread 6" # Collect thread ids, if any. + +set thread6 "" + gdb_test_multiple "info threads" "collect thread id" { -re ". 6 .*\[Tt\]hread (\[0-9a-fA-Fx\]+).* \"threadname_6\" \[^\r\n\]*" { set thread6 $expect_out(1,string) @@ -85,11 +88,14 @@ gdb_test_multiple "info threads" "collect thread id" { } } -if { [info exists thread6] } then { +if { $thread6 != "" } then { gdb_test "echo $thread6\\n" "$thread6" "got thread ids" } # Collect process ids, if any. + +set process6 "" + gdb_test_multiple "info threads" "collect thread id" { -re ". 6 .*\[Pp\]rocess (\[0-9a-fA-Fx\]+).* \"threadname_6\" \[^\r\n\]*" { set process6 $expect_out(1,string) @@ -125,6 +131,9 @@ if { [info exists process6] } then { } # Collect lwp ids, if any. + +set lwp6 "" + gdb_test_multiple "info threads" "collect thread id" { -re ". 6 .*LWP (\[0-9a-fA-Fx\]+).* \"threadname_6\" \[^\r\n\]*" { set lwp6 $expect_out(1,string) @@ -155,7 +164,7 @@ gdb_test_multiple "info threads" "collect thread id" { } } -if { [info exists lwp6] } then { +if { $lwp6 != "" } then { gdb_test "echo $lwp6\\n" "$lwp6" "got lwp ids" } @@ -180,7 +189,7 @@ gdb_test "thread find threadname_1" \ # Test 'thread find' with thread ids, if any. # -if { [info exists thread6] } then { +if { $thread6 != "" } then { gdb_test "thread find $thread6" \ "Thread 6 has .*$thread6.*" "find thread id 6" gdb_test "thread find $thread5" \ @@ -199,7 +208,7 @@ if { [info exists thread6] } then { # Test 'thread find' with process ids, if any. # -if { [info exists process6] } then { +if { $process6 != "" } then { gdb_test "thread find $process6" \ "Thread 6 has .*$process6.*" "find process id 6" gdb_test "thread find $process5" \ @@ -218,7 +227,7 @@ if { [info exists process6] } then { # Test 'thread find' with lwp ids, if any. # -if { [info exists lwp6] } then { +if { $lwp6 != "" } then { gdb_test "thread find $lwp6" \ "Thread 6 has .*$lwp6.*" "find lwp id 6" gdb_test "thread find $lwp5" \