Patchwork please document if ENOTSUP == EOPNOTSUPP

login
register
mail settings
Submitter Nicolas Boulenguez
Date Aug. 22, 2019, 11:41 p.m.
Message ID <20190822234109.GA23375@nicolasthinkpad>
Download mbox | patch
Permalink /patch/34254/
State New
Headers show

Comments

Nicolas Boulenguez - Aug. 22, 2019, 11:41 p.m.
> > Author: Florian Weimer <fweimer@redhat.com>
> Florian,
> Are you part-author of these changes?

In case he does not remember, I have added Florian because of the
corrections he suggested in comment 6.

> Please post a v2.

The new patch is available at
https://sourceware.org/bugzilla/attachment.cgi as attachment 11962.

Here are the changes:

Patch

--- a/manual_same_errno.diff
+++ b/manual_same_errno.diff
@@ -3,6 +3,7 @@ 
 Forwarded: https://sourceware.org/bugzilla/show_bug.cgi?id=2363
 Author: Nicolas Boulenguez <nicolas@debian.org>
 Author: Florian Weimer <fweimer@redhat.com>
+Author: Carlos O'Donell <carlos@redhat.com>
 
 --- a/manual/errno.texi
 +++ b/manual/errno.texi
@@ -17,10 +18,10 @@ 
 +so they can be used as labels in a @code{switch} statement.
 +Your program should not make any other assumptions about
  the specific values of these symbolic constants.
-+Moreover, @theglibc{} does two exceptions:
++There are two exceptions to this rule:
 +@itemize @bullet
-+@item The values of @code{AGAIN} and @code{EWOULDBLOCK} are the
-+same on every supported operating system.
++@item The values of @code{EAGAIN} and @code{EWOULDBLOCK} are
++equal on every supported operating system.
 +@item The values of @code{ENOTSUP} and @code{EOPNOTSUPP} are equal
 +on some supported operating systems, for example GNU/Linux.
 +@end itemize
@@ -79,7 +80,7 @@ 
  nothing to do for that call.
 +
 +@strong{Portability Note:} Depending on the operating system, the
-+@code{EOPNOTSUPP} and @code{ENOTSUP} macros may have the same value.
++values of @code{EOPNOTSUPP} and @code{ENOTSUP} may be equal.
 +Portable code should check for both errors and treat them the same.
  @end deftypevr
  
@@ -90,7 +91,7 @@ 
  it returns @code{ENOSYS} instead.
 +
 +@strong{Portability Note:} Depending on the operating system, the
-+@code{EOPNOTSUPP} and @code{ENOTSUP} macros may have the same value.
++values of @code{EOPNOTSUPP} and @code{ENOTSUP} may be equal.
 +Portable code should check for both errors and treat them the same.
  @end deftypevr