From patchwork Thu Aug 22 23:41:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Boulenguez X-Patchwork-Id: 34254 Received: (qmail 82656 invoked by alias); 22 Aug 2019 23:41:16 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 82648 invoked by uid 89); 22 Aug 2019 23:41:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.6 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 spammy=H*i:sk:3027116, H*f:sk:3027116 X-HELO: smtp6-g21.free.fr Date: Fri, 23 Aug 2019 01:41:09 +0200 From: Nicolas Boulenguez To: Carlos O'Donell Cc: libc-alpha@sourceware.org, Florian Weimer Subject: Re: [PATCH] please document if ENOTSUP == EOPNOTSUPP Message-ID: <20190822234109.GA23375@nicolasthinkpad> References: <20190821150658.GA32668@nicolasthinkpad> <3027116a-0f0e-d392-2493-427a2d37fe04@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3027116a-0f0e-d392-2493-427a2d37fe04@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) > > Author: Florian Weimer > Florian, > Are you part-author of these changes? In case he does not remember, I have added Florian because of the corrections he suggested in comment 6. > Please post a v2. The new patch is available at https://sourceware.org/bugzilla/attachment.cgi as attachment 11962. Here are the changes: --- a/manual_same_errno.diff +++ b/manual_same_errno.diff @@ -3,6 +3,7 @@ Forwarded: https://sourceware.org/bugzilla/show_bug.cgi?id=2363 Author: Nicolas Boulenguez Author: Florian Weimer +Author: Carlos O'Donell --- a/manual/errno.texi +++ b/manual/errno.texi @@ -17,10 +18,10 @@ +so they can be used as labels in a @code{switch} statement. +Your program should not make any other assumptions about the specific values of these symbolic constants. -+Moreover, @theglibc{} does two exceptions: ++There are two exceptions to this rule: +@itemize @bullet -+@item The values of @code{AGAIN} and @code{EWOULDBLOCK} are the -+same on every supported operating system. ++@item The values of @code{EAGAIN} and @code{EWOULDBLOCK} are ++equal on every supported operating system. +@item The values of @code{ENOTSUP} and @code{EOPNOTSUPP} are equal +on some supported operating systems, for example GNU/Linux. +@end itemize @@ -79,7 +80,7 @@ nothing to do for that call. + +@strong{Portability Note:} Depending on the operating system, the -+@code{EOPNOTSUPP} and @code{ENOTSUP} macros may have the same value. ++values of @code{EOPNOTSUPP} and @code{ENOTSUP} may be equal. +Portable code should check for both errors and treat them the same. @end deftypevr @@ -90,7 +91,7 @@ it returns @code{ENOSYS} instead. + +@strong{Portability Note:} Depending on the operating system, the -+@code{EOPNOTSUPP} and @code{ENOTSUP} macros may have the same value. ++values of @code{EOPNOTSUPP} and @code{ENOTSUP} may be equal. +Portable code should check for both errors and treat them the same. @end deftypevr