Message ID | 20200226200542.746617-7-sergiodj@redhat.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 101010 invoked by alias); 26 Feb 2020 20:06:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 100941 invoked by uid 89); 26 Feb 2020 20:06:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Languages-Length:962 X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (205.139.110.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Feb 2020 20:06:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582747585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xHjG5FjzrmgB7b+SfDPPas8FuZreGF0YrWBicvsUaMw=; b=dMQMn0+DjL0hM+grJgRdLOLZSjX6rL5XxYejVqsP8YAd96pR7Wwyat9kzU6yoMgR/4mtJe OZufUSFyLQbccZqRMmMliXxBU1uen891XfSHfkvpwQ/qMwrWPw14MI8YPlvnTSZAAtyuxZ +K+ah/4BKWf00dMNnAJxQI1es8BNe1I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-66-hLKrVvI0NlSufuqPe1uTKA-1; Wed, 26 Feb 2020 15:06:23 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9850A800D50; Wed, 26 Feb 2020 20:06:22 +0000 (UTC) Received: from psique.yyz.redhat.com (unused-10-15-17-54.yyz.redhat.com [10.15.17.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id EE38B5DA76; Wed, 26 Feb 2020 20:06:21 +0000 (UTC) From: Sergio Durigan Junior <sergiodj@redhat.com> To: GDB Patches <gdb-patches@sourceware.org> Cc: Pedro Alves <palves@redhat.com>, Tom Tromey <tom@tromey.com>, Eli Zaretskii <eliz@gnu.org>, Ruslan Kabatsayev <b7.10110111@gmail.com>, Sergio Durigan Junior <sergiodj@redhat.com> Subject: [PATCH 6/6] Fix comment for 'gdb_dlopen' Date: Wed, 26 Feb 2020 15:05:42 -0500 Message-Id: <20200226200542.746617-7-sergiodj@redhat.com> In-Reply-To: <20200226200542.746617-1-sergiodj@redhat.com> References: <20190926042155.31481-1-sergiodj@redhat.com> <20200226200542.746617-1-sergiodj@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes |
Commit Message
Sergio Durigan Junior
Feb. 26, 2020, 8:05 p.m. UTC
The 'gdb_dlopen' function doesn't return NULL if the shlib load fails;n it actually throws an error. This patch updates the comment to reflect this. gdbsupport/ChangeLog: yyyy-mm-dd Sergio Durigan Junior <sergiodj@redhat.com> * gdb-dlfcn.h (gdb_dlopen): Update comment. --- gdbsupport/gdb-dlfcn.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On Wed, Feb 26, 2020 at 2:06 PM Sergio Durigan Junior <sergiodj@redhat.com> wrote: > > The 'gdb_dlopen' function doesn't return NULL if the shlib load > fails;n it actually throws an error. This patch updates the comment Typo here (;n) > to reflect this. > > gdbsupport/ChangeLog: > yyyy-mm-dd Sergio Durigan Junior <sergiodj@redhat.com> > > * gdb-dlfcn.h (gdb_dlopen): Update comment. > --- > gdbsupport/gdb-dlfcn.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdbsupport/gdb-dlfcn.h b/gdbsupport/gdb-dlfcn.h > index 258cfebbc3..9e72a53dc0 100644 > --- a/gdbsupport/gdb-dlfcn.h > +++ b/gdbsupport/gdb-dlfcn.h > @@ -32,8 +32,8 @@ struct dlclose_deleter > typedef std::unique_ptr<void, dlclose_deleter> gdb_dlhandle_up; > > /* Load the dynamic library file named FILENAME, and return a handle > - for that dynamic library. Return NULL if the loading fails for any > - reason. */ > + for that dynamic library. Throw an error if the loading fails for > + any reason. */ > > gdb_dlhandle_up gdb_dlopen (const char *filename); > > -- > 2.24.1 >
On Wednesday, February 26 2020, Christian Biesinger wrote: > On Wed, Feb 26, 2020 at 2:06 PM Sergio Durigan Junior > <sergiodj@redhat.com> wrote: >> >> The 'gdb_dlopen' function doesn't return NULL if the shlib load >> fails;n it actually throws an error. This patch updates the comment > > Typo here (;n) Thanks! I fixed this locally. After I submitted the series, I thought that this one should probably have been merged with 5/6. Oh, well... Cheers,
>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
Sergio> gdbsupport/ChangeLog:
Sergio> yyyy-mm-dd Sergio Durigan Junior <sergiodj@redhat.com>
Sergio> * gdb-dlfcn.h (gdb_dlopen): Update comment.
This one could go in immediately under the obvious rule.
Tom
On Friday, February 28 2020, Tom Tromey wrote: >>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes: > > Sergio> gdbsupport/ChangeLog: > Sergio> yyyy-mm-dd Sergio Durigan Junior <sergiodj@redhat.com> > > Sergio> * gdb-dlfcn.h (gdb_dlopen): Update comment. > > This one could go in immediately under the obvious rule. Thanks, Tom. Pushed: d7592e974706637058867b02626c52a30ef0a2ee
diff --git a/gdbsupport/gdb-dlfcn.h b/gdbsupport/gdb-dlfcn.h index 258cfebbc3..9e72a53dc0 100644 --- a/gdbsupport/gdb-dlfcn.h +++ b/gdbsupport/gdb-dlfcn.h @@ -32,8 +32,8 @@ struct dlclose_deleter typedef std::unique_ptr<void, dlclose_deleter> gdb_dlhandle_up; /* Load the dynamic library file named FILENAME, and return a handle - for that dynamic library. Return NULL if the loading fails for any - reason. */ + for that dynamic library. Throw an error if the loading fails for + any reason. */ gdb_dlhandle_up gdb_dlopen (const char *filename);