Message ID | alpine.DEB.2.21.1911282305510.9015@digraph.polyomino.org.uk |
---|---|
State | Committed |
Headers |
Received: (qmail 127173 invoked by alias); 28 Nov 2019 23:06:13 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 127165 invoked by uid 89); 28 Nov 2019 23:06:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: esa3.mentor.iphmx.com IronPort-SDR: fDqSXL74NQJcs4Y/3oydowiXLlXBaflvYM4hQd6Ue8D4orAWO9EtK6lgvlWBDQ3Ogmf0KWtLWr GXZi9JpVlSwCacf7owPrATjdmv6z3ZpBCPJA26GRlcgBxYops4aM7H1A39orWk3sS1CGq5uIKj pNBG0Vsy9y5hjv52nHxzfvm8Fa4l5+oiWkCcE8gii0TURn5uki8VmSd/p0ieuF2drlCRwpciyu xLuagu/IHhGjQSBxrsQ0VP9UxWh/4uTIM+EyvuUrJbII0uayUrxn8qnhNKW45VPuGayV/BVMjV HPE= IronPort-SDR: jC549A+AITanC/fsqux4blW5AzpphyZPrdwJfz4LYova4q1mKJRQc5a8vVSeJbF5PkdO/wirui L+aWW69g3U0EH0aq1qh029MpRGutl7Wl6cLiqKo4mi5g/r6663gztwp/UjQB4S2aOpcm/4BJFn rW3rgV5z8vYTBJ+l+RL+D7MFwrRoX5eaRBpBjDGLfEFp6M/5oHwPFUeZ2AnEBLonsZVoqqQCqM VqXa6Q/xiLxMlSjFFY0XCh58Df72q+eCWL2BtB7IVgcak94TjMy414PSfF0Hjm6oCGYGI+asfc WLg= Date: Thu, 28 Nov 2019 23:06:05 +0000 From: Joseph Myers <joseph@codesourcery.com> To: <libc-alpha@sourceware.org> Subject: Update kernel version to 5.4 in tst-mman-consts.py Message-ID: <alpine.DEB.2.21.1911282305510.9015@digraph.polyomino.org.uk> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Return-Path: joseph@codesourcery.com |
Commit Message
Joseph Myers
Nov. 28, 2019, 11:06 p.m. UTC
This patch updates the kernel version in the test tst-mman-consts.py to 5.4. (There are no new constants covered by this test in 5.4 that need any other header changes.) Tested with build-many-glibcs.py.
Comments
On 11/28/19 6:06 PM, Joseph Myers wrote: > This patch updates the kernel version in the test tst-mman-consts.py > to 5.4. (There are no new constants covered by this test in 5.4 that > need any other header changes.) > > Tested with build-many-glibcs.py. > > diff --git a/sysdeps/unix/sysv/linux/tst-mman-consts.py b/sysdeps/unix/sysv/linux/tst-mman-consts.py > index c11e2ea4ac..3aaf2218f5 100644 > --- a/sysdeps/unix/sysv/linux/tst-mman-consts.py > +++ b/sysdeps/unix/sysv/linux/tst-mman-consts.py > @@ -41,7 +41,7 @@ def main(): > help='C compiler (including options) to use') > args = parser.parse_args() > linux_version_headers = linux_kernel_version(args.cc) > - linux_version_glibc = (5, 3) > + linux_version_glibc = (5, 4) > sys.exit(glibcextract.compare_macro_consts( > '#define _GNU_SOURCE 1\n' > '#include <sys/mman.h>\n', > I reviewed kernel 5.4 and also found no new constants that would require us to adjust the regexp. I looked specifically at: ./include/linux/mman.h ./include/uapi/asm-generic/mman.h ./include/uapi/linux/mman.h And also the arch specific mman.h. I noticed the test doesn't appear to cover PROT_*, MS_*, MADV_*, MCL_* or PKEY_* constants? Is that an oversight or a conscious choice? OK for master. Reviewed-by: Carlos O'Donell <carlos@redhat.com>
On Thu, 28 Nov 2019, Carlos O'Donell wrote: > I noticed the test doesn't appear to cover PROT_*, MS_*, MADV_*, MCL_* > or PKEY_* constants? Is that an oversight or a conscious choice? The idea when adding the test was to add something sufficient to be useful that could also be a starting point for adding more such tests later. It would certainly make sense to test more such macros there. We now have three such tests (tst-mman-consts.py tst-signal-numbers.py tst-socket-consts.py). My expectation is that once we have enough, there will be clear common patterns that allow us to move to having a single Python script to run them, and text files that describe the headers, macros (and hopefully structure layouts as well) to compare and any relevant kernel version information, rather than a separate Python script for each test. (Cf. how the constant extraction for assembly sources - which shares code used by these tests - has .sym files rather than a separate script for each generated header.)
On 11/29/19 11:36 AM, Joseph Myers wrote: > On Thu, 28 Nov 2019, Carlos O'Donell wrote: > >> I noticed the test doesn't appear to cover PROT_*, MS_*, MADV_*, MCL_* >> or PKEY_* constants? Is that an oversight or a conscious choice? > > The idea when adding the test was to add something sufficient to be > useful that could also be a starting point for adding more such tests > later. It would certainly make sense to test more such macros there. > > We now have three such tests (tst-mman-consts.py tst-signal-numbers.py > tst-socket-consts.py). My expectation is that once we have enough, there > will be clear common patterns that allow us to move to having a single > Python script to run them, and text files that describe the headers, > macros (and hopefully structure layouts as well) to compare and any > relevant kernel version information, rather than a separate Python script > for each test. (Cf. how the constant extraction for assembly sources - > which shares code used by these tests - has .sym files rather than a > separate script for each generated header.) Thanks, that makes sense, I was just curious.
diff --git a/sysdeps/unix/sysv/linux/tst-mman-consts.py b/sysdeps/unix/sysv/linux/tst-mman-consts.py index c11e2ea4ac..3aaf2218f5 100644 --- a/sysdeps/unix/sysv/linux/tst-mman-consts.py +++ b/sysdeps/unix/sysv/linux/tst-mman-consts.py @@ -41,7 +41,7 @@ def main(): help='C compiler (including options) to use') args = parser.parse_args() linux_version_headers = linux_kernel_version(args.cc) - linux_version_glibc = (5, 3) + linux_version_glibc = (5, 4) sys.exit(glibcextract.compare_macro_consts( '#define _GNU_SOURCE 1\n' '#include <sys/mman.h>\n',